Page MenuHomePhorge

PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests
Closed, ResolvedPublic

Description

  1. PHP 8.3.10; Arcanist at 901f0607716679792800e39015c7cc63cbb0d43c
  2. Ran ./bin/arc/diff to create D25797 for review
  3. Unit tests showed error output:
   [...]
   PASS  145ms   XHPASTNodeTestCase::testGetStringVariables
   PASS   91ms   XHPASTNodeTestCase::testGetNamespace
[2024-08-23 10:56:20] ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/api/XHPASTNode.php:243]
arcanist(head=phpDocParamVarnames, ref.master=901f06077166, ref.phpDocParamVarnames=b2ba7c67ed9b)
  #0 preg_match(string, NULL) called at [<arcanist>/src/parser/xhpast/api/XHPASTNode.php:243]
  #1 XHPASTNode::newStringLiteralFromSemanticString(string) called at [<arcanist>/src/parser/xhpast/api/XHPASTNode.php:220]
  #2 XHPASTNode::getStringLiteralValue() called at [<arcanist>/src/parser/xhpast/api/XHPASTNode.php:36]
  #3 XHPASTNode::evalStatic() called at [<arcanist>/src/parser/xhpast/api/XHPASTNode.php:33]
  #4 XHPASTNode::evalStatic() called at [<arcanist>/src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php:136]
  #5 XHPASTTreeTestCase::assertEval(string, string) called at [<arcanist>/src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php:112]
  #6 XHPASTTreeTestCase::testEvalStaticString() called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:639]
  #7 PhutilTestCase::run() called at [<arcanist>/src/unit/engine/PhutilUnitTestEngine.php:69]
  #8 PhutilUnitTestEngine::run() called at [<arcanist>/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:148]
  #9 ArcanistConfigurationDrivenUnitTestEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:170]
  #10 ArcanistUnitWorkflow::run() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1231]
  #11 ArcanistDiffWorkflow::runUnit() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1133]
  #12 ArcanistDiffWorkflow::runLintUnit() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:363]
  #13 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]
   PASS  265ms   XHPASTTreeTestCase::testEvalStaticString
[2024-08-23 10:56:21] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:85]
arcanist(head=phpDocParamVarnames, ref.master=901f06077166, ref.phpDocParamVarnames=b2ba7c67ed9b)
  #0 PHPASTParserTestCase::executeParserTest(string, string) called at [<arcanist>/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:18]
  #1 PHPASTParserTestCase::testParser() called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:639]
  #2 PhutilTestCase::run() called at [<arcanist>/src/unit/engine/PhutilUnitTestEngine.php:69]
  #3 PhutilUnitTestEngine::run() called at [<arcanist>/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:148]
  #4 ArcanistConfigurationDrivenUnitTestEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:170]
  #5 ArcanistUnitWorkflow::run() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1231]
  #6 ArcanistDiffWorkflow::runUnit() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:1133]
  #7 ArcanistDiffWorkflow::runLintUnit() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:363]
  #8 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]
   PASS  549ms   PHPASTParserTestCase::testParser
   PASS   88ms   PhutilReadableSerializerTestCase::testPrintableValue
   [...]

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.