Looks good! I want to play with it locally before accepting.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 24 2024
Jun 24 2024
aklapper renamed T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest from PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment data in AphrontRequest to PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest.
aklapper updated the task description for T15864: PHP 8.1 "strlen(null)" exceptions in PhabricatorEditEngine handling empty comment metadata in AphrontRequest.
avivey awarded D25698: Make the Remarkup Help Page Extensible a Yellow Medal token.
Fix call to non-existing newEmptyValue() in…
Jun 23 2024
Jun 23 2024
Make the Remarkup Help Page Extensible
Make the Remarkup Help Page Extensible
It also collected lots of commits, since May 2023.
I don't understand what happened here?
I only had these files changed/added:
- src/applications/reference/src/application/ReferenceApplication.php
- src/applications/reference/src/controller/CowayReferenceController.php
- src/applications/reference/src/controller/FigletReferenceController.php
- src/applications/reference/src/controller/ReferenceController.php
- src/applications/reference/src/controller/RemarkupReferenceController.php
- src/infrastructure/markup/interface/RemarkupSyntaxDocumentationProvider.php
- src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
- src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
- src/view/form/control/PhabricatorRemarkupControl.php
speck accepted D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.
ty
valerio.bozzolan added a comment to D25697: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.
This might (or should be) covered by the unit tests
valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Feel free to kill this method violently 🗡 since as you said this is protected (no external usages) + final (no overrides) and visibly broken since 5 years
Partially related, it's damn easy to type a dagger "🗡" since it appears by typing :D ... lol
aklapper added inline comments to D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.
@valerio.bozzolan Any thoughts/opinion regarding my last comment? :) TIA
Warn in comment field if task is closed as duplicate
aklapper committed rARC21fbc806e4e1: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in….
Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in…
avivey added a comment to D25697: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.
In D25697#19176, @20after4 wrote:I obviously failed to run ./bin/celerity map one more time before running arc diff.
There should really be some way to detect and prevent that mistake. It's one I've made probably 100 times before.
Jun 22 2024
Jun 22 2024
aklapper committed rPeda7a608e58d: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.
Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f
20after4 added a comment to D25697: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.
I obviously failed to run ./bin/celerity map one more time before running arc diff.
Sigh I screwed up (again) by not running ./bin/celerity map one more time. :( Followup in D25697
aklapper requested review of D25697: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.
aklapper planned changes to D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
Meh, after removing the value from the "Page Size" field on phorge.localhost/maniphest/query/advanced/, field entry will incorrectly display "0" but list 100 results. Need to find out how to keep the value displayed/reset after manually removing it to avoid PHP converting an empty integer to a 0.
aklapper updated the diff for D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
Make Celerity happy (I hope)
aklapper updated the diff for D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
We pushed rPfbe07fbeefcadea3abdb4dc3e4d4558c2b91ada9 in the meantime so no more String but Int field
aklapper added a comment to D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
Current patch does not work anymore since merging rPfbe07fbeefcadea3abdb4dc3e4d4558c2b91ada9; need to remove getDefaultValue() from PhabricatorSearchIntField instead of PhabricatorSearchTextField now
aklapper closed T15820: Update d3 from version 5.9.2 to 6.7.0 as Resolved by committing rP1fa8c79b1ef8: Update d3 from version 5.9.2 to 6.7.0.
Update d3 from version 5.9.2 to 6.7.0
Great, I appreciate your thoroughness here!
https://secure.phabricator.com/T13624#255069 and https://secure.phabricator.com/T13624#255072 provide the bigger context why it's "temporarily disabled".
aklapper committed rPddcdd6eaf24b: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a….
Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a…
Thanks for taking a look! Grep'ing the Phorge codebase I could not find any other consumers of d3 than Chart.js used by the Facts application. The d3 API has changed between 5.9.2 and 6.7.0 but the only changes relevant to Phorge which I found are covered in the three lines touched in Chart.js in this very patch.
In D25341#14044, @matmarex wrote:I had no idea that I am supposed to "land" these changes. Surely it should be the responsibility of the maintainers to decide into which release a change will go and when?
Anyway, I have been waiting for several months for someone to stop ignoring me and accept my patch, until @aklapper explained it to me… This seems like an awful workflow.
speck accepted D25518: Allow setting default value for SearchFields; set Maniphest Page Size to 100.
seems good
I take it the api used by Phorge hasn’t updated or changed in the update?
I didn’t find changes in our fork regarding this. We should either change these parameters to be optional in their definition or throw exceptions when they aren’t specified. Changing them to be optional seems the better behavior.
speck added inline comments to D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.
speck accepted D25690: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word.
Not having a title seems j like a bug elsewhere
Jun 21 2024
Jun 21 2024
Add fallback languages for locale files
mturdus committed rP1f5c54c35a1a: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Conduit API: allow phriction.edit to modify viewPolicy and editPolicy
aklapper updated the test plan for D25648: Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine.
valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
aklapper added inline comments to D25690: Fix "Undefined offset: 1" exception in Diviner when @task value in PHPDoc is a single word.
valerio.bozzolan updated the task description for T15855: Fix "arc diff" in Subversion for non-English languages.
In D25691#19103, @aklapper wrote:Any chance to share the related stacktrace?
I realize how little I remember SVN to set up testing, sigh... Any chance to share the related stacktrace?
aklapper retitled D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles from Fixes overflowing of AphrontSideNavFilterView on small screens and tidies up nav bar styles
Per my last comment
Add Standard Custom Fields to Item List
avivey renamed Blog Post: 2024 "Not Officially Summer" release blog post from 2024 "Not officially summer" release to 2024 "Not Officially Summer" release.
Promote 2024.19 to stable
Promote 2024.19 to stable
valerio.bozzolan added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
In D25694#19020, @avivey wrote:What if $cdn has some evil characters? Do we have some escaping
Jun 20 2024
Jun 20 2024
valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
valerio.bozzolan updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.
git rebase master
speck added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
valerio.bozzolan updated the name of F2236006: Phorge error Unknown objects.png from "image.png" to "Phorge error Unknown objects.png".
pppery added a comment to T15862: Some messages that support PLURAL are not detected as such by the i18n string extractor.
From an attempt I made to fix this before running out of motivation (this lists all parameters that vary on number in the US English translation but the i18n extractor thinks they don't)
WARNING /applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php:269: missing PhutilNumber call? WARNING /applications/config/check/PhabricatorExtraConfigSetupCheck.php:72: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:58: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:73: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:316: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:321: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:347: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:390: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:397: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:524: missing PhutilNumber call? WARNING /applications/config/view/PhabricatorSetupIssueView.php:578: missing PhutilNumber call? WARNING /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:74: missing PhutilNumber call? WARNING /applications/conpherence/xaction/ConpherenceThreadParticipantsTransaction.php:80: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:36: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:48: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:78: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php:92: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:39: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:51: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:81: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php:95: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:34: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php:46: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:18: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:30: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:61: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php:75: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:33: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:45: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:76: missing PhutilNumber call? WARNING /applications/differential/edge/DifferentialRevisionHasTaskEdgeType.php:90: missing PhutilNumber call? WARNING /applications/differential/mail/DifferentialCreateMailReceiver.php:75: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:523: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:525: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:529: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:531: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:556: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:558: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:562: missing PhutilNumber call? WARNING /applications/differential/render/DifferentialChangesetHTMLRenderer.php:564: missing PhutilNumber call? WARNING /applications/differential/storage/DifferentialTransaction.php:593: missing PhutilNumber call? WARNING /applications/differential/storage/DifferentialTransaction.php:597: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:34: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php:46: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:33: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:45: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:76: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php:90: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:22: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:34: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:64: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php:78: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:25: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:37: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:67: missing PhutilNumber call? WARNING /applications/diffusion/edge/DiffusionCommitRevertsCommitEdgeType.php:81: missing PhutilNumber call? WARNING /applications/legalpad/edge/LegalpadObjectNeedsSignatureEdgeType.php:17: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:32: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:44: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:74: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php:88: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:37: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:49: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:79: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php:93: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:33: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:45: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:76: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php:90: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:21: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php:33: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:33: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:45: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:76: missing PhutilNumber call? WARNING /applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php:90: missing PhutilNumber call? WARNING /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:54: missing PhutilNumber call? WARNING /applications/owners/xaction/PhabricatorOwnersPackageOwnersTransaction.php:60: missing PhutilNumber call? WARNING /applications/pholio/edge/PholioMockHasTaskEdgeType.php:21: missing PhutilNumber call? WARNING /applications/pholio/edge/PholioMockHasTaskEdgeType.php:33: missing PhutilNumber call? WARNING /applications/pholio/xaction/PholioImageFileTransaction.php:61: missing PhutilNumber call? WARNING /applications/pholio/xaction/PholioImageFileTransaction.php:67: missing PhutilNumber call? WARNING /applications/phortune/controller/account/PhortuneAccountOverviewController.php:116: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:17: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneAccountHasMemberEdgeType.php:29: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:17: missing PhutilNumber call? WARNING /applications/phortune/edge/PhortuneMerchantHasMemberEdgeType.php:29: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:22: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectMemberOfProjectEdgeType.php:34: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:24: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:36: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:67: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectObjectHasProjectEdgeType.php:81: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:22: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:34: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:64: missing PhutilNumber call? WARNING /applications/project/edge/PhabricatorProjectProjectHasMemberEdgeType.php:78: missing PhutilNumber call? WARNING /applications/project/storage/PhabricatorProjectTransaction.php:108: missing PhutilNumber call? WARNING /applications/project/storage/PhabricatorProjectTransaction.php:120: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:56: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:62: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:90: missing PhutilNumber call? WARNING /applications/project/xaction/PhabricatorProjectSlugsTransaction.php:97: missing PhutilNumber call? WARNING /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:77: missing PhutilNumber call? WARNING /applications/repository/worker/PhabricatorRepositoryPushMailWorker.php:108: missing PhutilNumber call? WARNING /applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php:98: missing PhutilNumber call? WARNING /applications/subscriptions/view/SubscriptionListStringBuilder.php:67: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:22: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasContributorEdgeType.php:34: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:21: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:33: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:63: missing PhutilNumber call? WARNING /applications/transactions/edges/PhabricatorObjectHasWatcherEdgeType.php:77: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:38: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:39: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:44: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:55: missing PhutilNumber call? WARNING /applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php:56: missing PhutilNumber call? WARNING /applications/transactions/storage/PhabricatorApplicationTransaction.php:1042: missing PhutilNumber call? WARNING /applications/transactions/storage/PhabricatorApplicationTransaction.php:1053: missing PhutilNumber call? WARNING /infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php:140: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:66: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:78: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:109: missing PhutilNumber call? WARNING /infrastructure/edges/type/PhabricatorEdgeType.php:123: missing PhutilNumber call?
Not all of these should be fixed in the obvious way, or even can be.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0