Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions handling empty comment metadata in PhabricatorEditEngine
ClosedPublic

Authored by aklapper on Jun 24 2024, 13:15.
Tags
None
Referenced Files
F2943503: D25699.1738196736.diff
Wed, Jan 29, 00:25
F2935257: D25699.1737838614.diff
Fri, Jan 24, 20:56
F2934936: D25699.1737810609.diff
Fri, Jan 24, 13:10
F2934780: D25699.1737803265.diff
Fri, Jan 24, 11:07
F2934555: D25699.1737793457.diff
Fri, Jan 24, 08:24
F2934383: D25699.1737786063.diff
Fri, Jan 24, 06:21
F2934355: D25699.1737785035.diff
Fri, Jan 24, 06:03
F2934349: D25699.1737785020.diff
Fri, Jan 24, 06:03

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:1923]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:2023]

Closes T15864

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable