Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions handling empty comment metadata in PhabricatorEditEngine
ClosedPublic

Authored by aklapper on Jun 24 2024, 13:15.
Tags
None
Referenced Files
F3801767: D25699.1745963946.diff
Mon, Apr 28, 21:59
F3776922: D25699.1745865729.diff
Sun, Apr 27, 18:42
F3763167: D25699.1745839001.diff
Sun, Apr 27, 11:16
F3759298: D25699.1745827667.diff
Sun, Apr 27, 08:07
F3748964: D25699.1745789807.diff
Sat, Apr 26, 21:36
F3497362: D25699.1744790909.diff
Tue, Apr 15, 08:08
F3426441: D25699.1744650648.diff
Sun, Apr 13, 17:10
F3390891: D25699.1744473320.diff
Fri, Apr 11, 15:55

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:1923]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/transactions/editengine/PhabricatorEditEngine.php:2023]

Closes T15864

Test Plan

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable