Page MenuHomePhorge

Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine
ClosedPublic

Authored by aklapper on May 16 2024, 11:16.

Details

Summary

PhabricatorDashboardPortalProfileMenuEngine calls $this->newEmptyValue() but neither PhabricatorDashboardPortalProfileMenuEngine nor its parent PhabricatorProfileMenuEngine define a newEmptyValue() method.
Thus use existing newNoContentView() in parent PhabricatorProfileMenuEngine (which according to its string output is supposed to cover this case).

Test Plan

Go to a Portal with no content. Before applying the patch, Phorge shows the message defined in the parent class PhabricatorProfileMenuEngine: No Content; No visible menu items can render content.
After applying this change, it correctly shows the message defined in PhabricatorDashboardPortalProfileMenuEngine: No Portal Content; None of the visible menu items in this portal can render any content.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

speck added inline comments.
src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php
40

Does this line need to use the same no content view function?

aklapper added inline comments.
src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php
40

No, this is a different case (portal with no objects, instead of portal with objects you cannot access). Parent class PhabricatorProfileMenuEngine defines final protected function newEmptyView($title, $message).

This revision is now accepted and ready to land.Jun 23 2024, 17:32