Remove comment cloning

In D25568#16354, @valerio.bozzolan wrote:

In this way, do we skip that column creating a column shift?

Maybe we need to promote that NULL to empty string

add minor comment - ready again - tested

I never use them, because there is no real method search. I think, we should be considering generating a documentation with a real php documention tool. But whatever we do: I think we can remove them in their current form.

introduce a nice applyExternalEffect() to change external things (the orginal file)

All of this should maybe go under "applyExternalEffects()"

All of this should maybe go under "applyExternalEffects()", but I can't find any doc that explains what should go there. Looks like external runs after all the internal and the object being saved, and before final. 🤷‍♂️

See also note in https://we.phorge.it/D25475#inline-3542 - looks like "creating a transformation" is done in many places.

In D25568#16354, @valerio.bozzolan wrote:

In this way, do we skip that column creating a column shift?

In this way, do we skip that column creating a column shift?

Address review feedback:

The change looks reasonable though I’m not familiar at this level of the database schema design

In T15670#16064, @valerio.bozzolan wrote:

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

I'll test this locally, I can't see any reason we shouldn't merge it.

@kat: I've added you to the Trusted Contributors project, so you can now land this change!

Traced the Flags in Revision back to its origin in https://secure.phabricator.com/T1557. I knew about this one - but I was 100% sure that the feature was lost when the SearchEngine classes were introduced.

Whops, typo "Seperate" in the title - sorry for not noticing

Congratulations to both bekay and avivey. Minimum change, maximum result.

beautified even more - all logic inside the Transaction itself

I can reproduce this, on an hosted Subversion repository.

In D25538#16175, @avivey wrote:

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

• Moves readme to the top in home view

Well, my idea was to use the already implemented logic of the diagram extension and just extend it with another diagram renderer. But @mturdus is not responding 😁

Well, you know what would be next level for a dev? If (s)he clicks on it, the color is copied to the clipboard. We can't use this behavior, because behaviors loose their state in the remarkup cache...

The Github syntax for this is bad. That's the code block syntax. It makes it impossible to have code-block with mermaid syntax.

If Phorge adds this feature, it is a good opportunity to be nice to thousands of people who use GitLab and GitHub, to unify with their syntax. Visible here:

I've added additional context since interestingly this feature is available since 2017 in GitLab :O wow

1. Are we interested in #fff?

Looking at the mentioned question, it seems a NULL pointer arrives as first argument in phutil_encode_log(). Fortunately that function is used by only 3 places:

Yes will be great to see a SAML or Oauth support for external authorities like:

• Keycloak
• Entra ID
• Github
• Facebook
• WeChat / WeCom

Ah yep, GET with body will get flagged in a number of cases.

looks good to me - couple of small inlines....

(Flags only show up in Maniphest on this one; I'll add them to more apps in a layer diff)

This D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes should be ready to merge now, if someone wouldn't mind reviewing it.

Discussed on IRC: it seems that this should have been POST all along.

In D25540#16124, @valerio.bozzolan wrote:

About your Remarkup unit tests, try to rebase. Maybe related to D25559.

• Fixed a logic bug.
• Added passing unit tests.

IIUC this adds Flags in Differential, Maniphest, etc list views, and adds the repository in Differential list view?

Remove another change which is unneeded now

Remove two changes from patch which got already fixed in the meantime; rebase

Abandoning per last comment

Abandoning per last comment

Argh, sorry!

(Whops! wrong summary)