Done:

I wonder if xhpast can be ditched. Eg:
For linters, use something off-the-shelf such as phpcs (https://github.com/squizlabs/PHP_CodeSniffer)
For diviner parsing of PHP code, I look at the class documentation (eg https://we.phorge.it/book/libphutil/class/ArcanistConduitCallFuture/) and question as to whether this provides anyone with any benefit.

and I'm sorry that this is becoming so time expensive

I guess another question is whether to define an abstract public function getCommentFieldPlaceholderText() in parent PhabricatorEditEngine and then add to all and every child EditEngine a default public function getCommentFieldPlaceholderText($object_phid) { return '' };. Feels cleaner to me.

Ouch I see that receiving the engine was very complicated.

Abstract logic: Move application specific conditions to display a comment field placeholder text into the corresponding EditEngine of the object that the comment field is displayed in, by defining a public getCommentFieldPlaceholderText() function.

In D25546#15665, @valerio.bozzolan wrote:

I also don't get if in this part we have access to any thing related to Maniphest, ManiphestEditEngine or this kind of stuff, to just call $something->getCommentPanelPlaceholder() and have the business logic there in the specific application itself.

In T15047#1308, @speck wrote:

Sorry for the late reply.
The Diagrams extension (which just references the draw.io codebase) already has something like that in it.
You can use {DIAG1} in remarkup for showing Diagram 1 in e.g. a wiki document.
You can also import Mermaid diagrams in here.

A weird but... expandable, fast, easy possibility is introducing this syntax:

Also apologies for not testing this locally in the phab ui, I was far too confident in my TDD.

man I didn't even consider that you could actually have a valid project named #0dba11 ... maybe the syntax should be something different. #{00ffff} perhaps?

Did that Phactory: Hosting Projects Here

This script can be used to download the entire graph:

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

It's something to do with the priority - it works if the priority is 150.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)

Doesn't actually work for me either after arc patch:

...or Pharkdown :D

It's kind of a shame that remarkup wasn't named Pharkup.

Actually add the rule to the remarkup engine.

LOL I only ever tested the unit test case. I forgot to add the rule to PhabricatorMarkupEngine:

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

• Don't exist in Diffusion
• Do exist in Paste
• Don't exist in Differential

In D25505#14536, @avivey wrote:

Alternatively, maybe catch the existing exception and show a nice error message + the form?

+celerity map

If it's that easy

FTR I gave this last version another test locally, feeding an mbox file with no subject header (which is accepted now without complaints), and bugging input again (which prints a correct error message instead of misleadingly complaining about a missing subject line)

I do not understand why it does not work to me.

There's no easy way to do that...
The diviner flow loads code from a repository, creates "cache" files, and then loads them directly to DB. I'm not sure it's even reasonable to try to run it on a different workspace copy.

Go MoreMimeMailParserPeouw

Simplify logic (thanks Mukunda!)

You should be able to just arc land this now...

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

Ah, also adding a smalll meta "noindex" HTML tag on legacy file.php$123 pages and similar ones, would maybe help a little bit.

In T15670#15501, @avivey wrote:

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Anyway, I vote to revert the change - commit pages can have discussions in.

If it's that easy, then I'm both impressed and surprised it remained this way for so long. I'm actually not quite sure I understand the reasoning for not using # to begin with.

In D25558#16391, @avivey wrote:

(The images aren't public/attached, so I can't see them)

Are there mechanisms to re-gen the doc after we land changes? If not that might be something we should be able to do with harnormaster, and we can bring the docs back after something like that is set up to ensure they’re always updated

As a work-around, you can probably add ?offset=0 to the URL.

(The images aren't public/attached, so I can't see them)

Agree with last comment

I'm curious about the use-case for copying comments as well - I'm guessing that there's some extra data that's added in the comments?

Add pht to string

Fix linting issues