Page MenuHomePhorge
Feed All Stories

Jan 12 2024

doommius requested review of D25513: Work in progress discord auth.
Jan 12 2024, 11:54
doommius created T15708: Discord as auth method.
Jan 12 2024, 11:49 · Auth
aklapper added a comment to D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
if (!is_array($value)) {  // ←←←←←←←←← May be this needs to be converted to is_string($value) or similar thing

This seems reasonable since it's nonsense to me to decode an integer, or decode a float. Only decoding a string makes sense to me.

Jan 12 2024, 11:47
aklapper updated the diff for D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.

Only call json_decode() in PhabricatorStandardCustomFieldPHIDs.php on string values, instead of not calling setValueFromApplicationTransactions() in PhabricatorCustomFieldEditField.php as proposed by Valerio

Jan 12 2024, 11:46
doommius added a revision to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML.: D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
Jan 12 2024, 11:35 · Auth, Bug Reports
doommius added a task to D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML: T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..
Jan 12 2024, 11:35
doommius requested review of D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
Jan 12 2024, 11:34
valerio.bozzolan added a comment to D25507: Config User Extra Fields: link to the doc (like Maniphest).

Yeah I honestly don't know if uppercase or lowercase.

Jan 12 2024, 11:15
aklapper added a comment to D25507: Config User Extra Fields: link to the doc (like Maniphest).

Tested locally, all in all +1 but capitalization is inconsistent comparing to maniphest.custom-field-definitions: Custom Fields twice and User Profiles once should use lower-case.

Jan 12 2024, 10:59
valerio.bozzolan planned changes to D25118: Remarkup: make less internal links open in new tabs.
Jan 12 2024, 10:16
valerio.bozzolan changed the visibility for F709421: After D25509.png.
Jan 12 2024, 09:57
valerio.bozzolan changed the visibility for F709419: Before D25509.png.
Jan 12 2024, 09:57
valerio.bozzolan accepted D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

I sincerely think this is lovely. Thanks. I do not understand how you figure it out all these keywords and in what order and associated to what, but hey, it works.

Jan 12 2024, 09:55
valerio.bozzolan retitled D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode from Fix remarkup codeblock syntax highlighting when using Dark Mode
Jan 12 2024, 09:53
valerio.bozzolan added a comment to T15673: Phorge participation at FOSDEM 2024.

I set this to unbreak now just to give extra visibility on the homepage :^)

Jan 12 2024, 09:38 · Blessed Communicators, Phorge
valerio.bozzolan renamed T15673: Phorge participation at FOSDEM 2024 from Phorge participation at FOSDEM 2024 (Deadline: 10th December) to Phorge participation at FOSDEM 2024.
Jan 12 2024, 09:38 · Blessed Communicators, Phorge
valerio.bozzolan added a comment to D25478: Use predictable filenames when downloading raw diffs from a revision.

Ah, before landing, please consider an additional line in the comment (like the proposed one)

Jan 12 2024, 09:24
valerio.bozzolan accepted D25478: Use predictable filenames when downloading raw diffs from a revision.

As far as I can understand, the generated file name here is 100% for commodity purposes: not used for anything on the filesystem, not used as unique key in something, not used to check whenever the file should be created again or not.

Jan 12 2024, 09:22
valerio.bozzolan accepted D25503: Allow to uninstall (hide) Audit application.

I'm testing this. It works and this makes me happy. Please wait Sunday before landing this, so others can give an eye.

Jan 12 2024, 09:10
valerio.bozzolan added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Can you try changing this line in your local install?

Jan 12 2024, 08:58 · Auth, Bug Reports
valerio.bozzolan raised a concern with rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error.

Probably causing problems with Facebook OAuth

Jan 12 2024, 08:56
valerio.bozzolan awarded T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML. a Grey Medal token.
Jan 12 2024, 08:53 · Auth, Bug Reports
valerio.bozzolan added Q103: Ponder: "New Answer" input box should be hidden for those without permissions. (Answer 131).
Jan 12 2024, 08:19
valerio.bozzolan added a member for Trusted Contributors: sirocyl.
Jan 12 2024, 08:18
aklapper closed T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Jan 12 2024, 07:40 · PHP 8 support
aklapper closed T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured as Resolved by committing rP8e09dbfee343: Fix PHP 8.1 exception creating task when custom select field configured.
Jan 12 2024, 07:40 · PHP 8 support
aklapper closed D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Jan 12 2024, 07:40
aklapper committed rP8e09dbfee343: Fix PHP 8.1 exception creating task when custom select field configured.
Fix PHP 8.1 exception creating task when custom select field configured
Jan 12 2024, 07:40
fgaz updated fgaz.
Jan 12 2024, 07:37
aklapper closed T15687: PHP 8.1 "strlen(null)" exception when custom select field configured, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Jan 12 2024, 01:05 · PHP 8 support
aklapper closed T15687: PHP 8.1 "strlen(null)" exception when custom select field configured as Resolved by committing rP40d10fbe1ae6: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Jan 12 2024, 01:05 · PHP 8 support
aklapper closed D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Jan 12 2024, 01:05
aklapper committed rP40d10fbe1ae6: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Fix PHP 8.1 "strlen(null)" exception when custom select field configured
Jan 12 2024, 01:05
aklapper updated the diff for D25494: Fix PHP 8.1 exception creating task when custom select field configured.

Use strlen() instead of empty string check

Jan 12 2024, 01:04

Jan 11 2024

speck accepted D25494: Fix PHP 8.1 exception creating task when custom select field configured.

Same comment about keeping strlen. Up to you if you want to switch before landing.

Jan 11 2024, 23:25
aklapper updated the diff for D25503: Allow to uninstall (hide) Audit application.

Simplify some code / fix TODOs as proposed by Valerio

Jan 11 2024, 23:22
speck accepted D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.

ty

Jan 11 2024, 23:21
aklapper added a comment to D25503: Allow to uninstall (hide) Audit application.

Just for the records and bystanders: All expectations described in D25503#14539 are also what the patch currently does.

Jan 11 2024, 23:21
aklapper updated the diff for D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.

Use strlen() instead of empty string check

Jan 11 2024, 22:33
aklapper added inline comments to D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Jan 11 2024, 22:32
speck accepted D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Jan 11 2024, 21:22
aklapper added a comment to D25503: Allow to uninstall (hide) Audit application.

Ideally, comments are a general things and should be kept. Also changing Tags and Subscribers etc. is generic and should be kept.

Jan 11 2024, 21:20
aklapper added a comment to D25494: Fix PHP 8.1 exception creating task when custom select field configured.

Does anyone dare to accept the last revision? :)

Jan 11 2024, 21:09
aklapper added a comment to D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.

The updated one-liner welcomes another review :)

Jan 11 2024, 21:00
aklapper requested review of D25511: Ellipsize long labels in Add Action area to avoid text overlap.
Jan 11 2024, 18:16
aklapper added a revision to T15707: Long labels overlap in Add Action area: D25511: Ellipsize long labels in Add Action area to avoid text overlap.
Jan 11 2024, 18:16
aklapper created T15707: Long labels overlap in Add Action area.
Jan 11 2024, 18:16
doommius updated the task description for T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..
Jan 11 2024, 17:23 · Auth, Bug Reports
doommius updated the task description for T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..
Jan 11 2024, 17:17 · Auth, Bug Reports
doommius created T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..
Jan 11 2024, 17:15 · Auth, Bug Reports
valerio.bozzolan added a member for Trusted Contributors: doommius.
Jan 11 2024, 16:51
sirocyl updated the question details for Q103: Ponder: "New Answer" input box should be hidden for those without permissions..
Jan 11 2024, 16:41 · UX
sirocyl asked Q103: Ponder: "New Answer" input box should be hidden for those without permissions..
Jan 11 2024, 16:38 · UX
sirocyl added a comment to T15006: Re-brand Phorge.

Noticed a few dangling phacility references in URLs in documentation, which could lead users to grabbing upstream Phabricator versions by mistake:

phorge/src/docs/user/field/xhprof.diviner:  $ git clone https://github.com/phacility/xhprof.git
phorge/src/docs/user/userguide/arcanist.diviner:  some_install_path/ $ git clone https://github.com/phacility/arcanist.git
phorge/src/docs/user/userguide/arcanist_quick_start.diviner:  somewhere/ $ git clone https://github.com/phacility/arcanist.git

corresponding to:
https://we.phorge.it/book/phorge/article/xhprof/#installing-xhprof
https://we.phorge.it/book/phorge/article/arcanist/#installing-arcanist
https://we.phorge.it/book/phorge/article/arcanist_quick_start/#installing-arcanist

Jan 11 2024, 15:36 · Phorge
aklapper closed D25510: Fix invalid CSS property value.
Jan 11 2024, 12:54
aklapper committed rP49c3fe619342: Fix invalid CSS property value.
Fix invalid CSS property value
Jan 11 2024, 12:54
speck accepted D25510: Fix invalid CSS property value.
Jan 11 2024, 12:32
bekay added a comment to T15645: Implement "Locate File" input in Browse view.

Under the hood branches are already supported by the locate feature. The whole file tree is loaded via AJAX, when you first click in the input field. This tree represents the current selected branch.

Jan 11 2024, 12:30 · Diffusion
aklapper requested review of D25510: Fix invalid CSS property value.
Jan 11 2024, 10:58
fgaz added a comment to Q91: How can I tell phorge to use a different local.json file at runtime? (Answer 114).

did you find a solution for this?

Jan 11 2024, 09:03

Jan 10 2024

valerio.bozzolan awarded D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode a Love token.
Jan 10 2024, 20:54
valerio.bozzolan updated the diff for D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

Run arc diff from my computer that has Xdebug enabled

Jan 10 2024, 20:54
mturdus added a comment to D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.

Can someone explain what these "Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'" messages mean ?
Are these automated unit tests run on we.phorge.it or on my system ?

Jan 10 2024, 17:57
avivey awarded T15705: Lower the search ranking of disabled user accounts a Evil Spooky Haunted Tree token.
Jan 10 2024, 14:37 · UX
valerio.bozzolan added a comment to T15705: Lower the search ranking of disabled user accounts.

Completely agree on lowering their ranking as default

Jan 10 2024, 10:06 · UX
avivey updated subscribers of Q91: How can I tell phorge to use a different local.json file at runtime? (Answer 114).

@fgaz - did you find a solution for this?
For the "make Phorge extensions easy to install" feature (which I can't find the ticket for), I have a vague plan of adding another file describing available/installed extensions. I'd like to make packaging harder if I can avoid it, so possibly whatever solves local.json can solve this file too.

Jan 10 2024, 04:59
speck added a comment to T15566: Make is easier to install Phorge in the smallest case.

I have some containers I put together for development which could provide a place to start
https://github.com/neandrake/phab-dev

Jan 10 2024, 04:21 · Phorge

Jan 9 2024

20after4 added a comment to T15566: Make is easier to install Phorge in the smallest case.

I've just found again this

https://github.com/cooperspencer/phorge/

Jan 9 2024, 22:53 · Phorge
20after4 added a comment to T15673: Phorge participation at FOSDEM 2024.

OH MY GOD FOR SOME REASONS THEY RE-OPENED OUR PROPOSAL \o/ IT'S HAPPENING!

https://pretalx.fosdem.org/fosdem-2024/talk/review/EXZNAUXQKMJ7HRYYRD7MKFXTTV8JFQDJ

Jan 9 2024, 22:49 · Blessed Communicators, Phorge
20after4 created T15705: Lower the search ranking of disabled user accounts.
Jan 9 2024, 22:42 · UX
mturdus requested review of D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.
Jan 9 2024, 21:56
mturdus added a revision to T15056: Improve Dark Mode: D25509: Improve remarkup codeblock syntax highlighting when using Dark Mode.
Jan 9 2024, 21:56 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
valerio.bozzolan added a project to T15566: Make is easier to install Phorge in the smallest case: Phorge.

I do not remember who was developing Docker stuff for this. I've just found again this

Jan 9 2024, 13:32 · Phorge
valerio.bozzolan triaged T15673: Phorge participation at FOSDEM 2024 as High priority.
Jan 9 2024, 12:37 · Blessed Communicators, Phorge
valerio.bozzolan reopened T15673: Phorge participation at FOSDEM 2024 as "Open".

OH MY GOD FOR SOME REASONS THEY RE-OPENED OUR PROPOSAL \o/ IT'S HAPPENING!

Jan 9 2024, 12:37 · Blessed Communicators, Phorge

Jan 8 2024

bd808 updated the task description for T15566: Make is easier to install Phorge in the smallest case.
Jan 8 2024, 23:48 · Phorge
valerio.bozzolan added a comment to D25118: Remarkup: make less internal links open in new tabs.

Just discovered this from secure dot, 2017

Jan 8 2024, 19:41
valerio.bozzolan added a comment to D25494: Fix PHP 8.1 exception creating task when custom select field configured.

This works as long as getFieldValue() never returns an object (that has a toString, that may be empty)

Jan 8 2024, 18:15
valerio.bozzolan edited the content of Next Up.
Jan 8 2024, 18:08
valerio.bozzolan closed D25508: Add support for FIDO2-backed SSH keys.
Jan 8 2024, 18:08
valerio.bozzolan committed rP6fe942a8f9f6: Add support for FIDO2-backed SSH keys.
Add support for FIDO2-backed SSH keys
Jan 8 2024, 18:08
avivey accepted D25508: Add support for FIDO2-backed SSH keys.

notmyfault

Jan 8 2024, 14:28
valerio.bozzolan accepted D25500: Add getQueryApplicationClass() to *TransactionQuery.php classes.

Thanks. Don't take my comments seriously. Probably they have no sense.

Jan 8 2024, 13:24
valerio.bozzolan added inline comments to D25503: Allow to uninstall (hide) Audit application.
Jan 8 2024, 13:19
valerio.bozzolan closed Q96: Support for FIDO2-backed SSH keys as obsolete.
Jan 8 2024, 13:14
valerio.bozzolan added Q96: Support for FIDO2-backed SSH keys (Answer 129).
Jan 8 2024, 13:14
antonia accepted D25508: Add support for FIDO2-backed SSH keys.

This is exactly the same as I've done on the system I patched at my workplace. I apologize for not submitting my own patch, I didn't have access to my work systems during the holidays.

Jan 8 2024, 13:07
valerio.bozzolan added a comment to Q96: Support for FIDO2-backed SSH keys.

Hoping to be useful I've added you as reviewer in D25508: Add support for FIDO2-backed SSH keys

Jan 8 2024, 13:02
valerio.bozzolan added a reviewer for D25508: Add support for FIDO2-backed SSH keys: antonia.
Jan 8 2024, 13:02
valerio.bozzolan requested review of D25508: Add support for FIDO2-backed SSH keys.
Jan 8 2024, 13:01
valerio.bozzolan updated the task description for T15703: Workboard Cover Image: the cropped "Transform" is orphan.
Jan 8 2024, 11:19 · Bug Reports, User-valerio.bozzolan, Cover Image
valerio.bozzolan added a revision to T15703: Workboard Cover Image: the cropped "Transform" is orphan: D25475: Drag & Drop Task Cover Image: also attach.
Jan 8 2024, 11:01 · Bug Reports, User-valerio.bozzolan, Cover Image
valerio.bozzolan updated the summary of D25475: Drag & Drop Task Cover Image: also attach.
Jan 8 2024, 11:01
valerio.bozzolan added a comment to D25118: Remarkup: make less internal links open in new tabs.

Some possibilities:

Jan 8 2024, 09:36
valerio.bozzolan requested review of D25507: Config User Extra Fields: link to the doc (like Maniphest).
Jan 8 2024, 09:07
valerio.bozzolan updated the diff for D25475: Drag & Drop Task Cover Image: also attach.

fix missing Transform entry

Jan 8 2024, 08:07

Jan 7 2024

speck added a comment to D25118: Remarkup: make less internal links open in new tabs.

Also instead of “Goodie” maybe “Helper” or something. Maybe there’s a similar naming elsewhere in the code base

Jan 7 2024, 14:43
speck added a comment to D25118: Remarkup: make less internal links open in new tabs.

I forgot I had this requesting changes. Any idea of the performance hit in markup rendering now that PhutilURI is constructed for every link? I think its constructor does a fair amount.

Jan 7 2024, 14:42
valerio.bozzolan added inline comments to D25503: Allow to uninstall (hide) Audit application.
Jan 7 2024, 10:19
valerio.bozzolan added a comment to D25503: Allow to uninstall (hide) Audit application.

You are doing a nice work.

Jan 7 2024, 10:09