Page MenuHomePhorge

Config User Extra Fields: link to the doc (like Maniphest)
ClosedPublic

Authored by valerio.bozzolan on Jan 8 2024, 09:07.
Tags
None
Referenced Files
F2167244: D25507.id1614.diff
Sat, Apr 27, 17:35
F2167095: D25507.diff
Sat, Apr 27, 15:26
Unknown Object (File)
Wed, Apr 24, 23:03
Unknown Object (File)
Wed, Apr 17, 18:19
Unknown Object (File)
Wed, Apr 17, 06:48
Unknown Object (File)
Fri, Apr 12, 18:25
Unknown Object (File)
Fri, Apr 12, 14:38
Unknown Object (File)
Thu, Apr 4, 01:35

Details

Summary

Add a documentation link in a specific Config page, that is:

Config > Setting > user.custom-field-definitions

Test Plan

Visit the page and click on the new link:

  • /config/edit/user.custom-field-definitions/

Visit this page that was the inspirational page:

  • /config/edit/maniphest.custom-field-definitions/

No nuclear implosions.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tested locally, all in all +1 but capitalization is inconsistent comparing to maniphest.custom-field-definitions: Custom Fields twice and User Profiles once should use lower-case.

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...

This revision is now accepted and ready to land.Jan 13 2024, 02:37