Page MenuHomePhorge

Config User Extra Fields: link to the doc (like Maniphest)
ClosedPublic

Authored by valerio.bozzolan on Jan 8 2024, 09:07.
Tags
None
Referenced Files
F3480305: D25507.1744767180.diff
Tue, Apr 15, 01:33
F3399382: D25507.1744546800.diff
Sat, Apr 12, 12:20
F3391300: D25507.1744475533.diff
Fri, Apr 11, 16:32
F3390160: D25507.1744463535.diff
Fri, Apr 11, 13:12
F3372925: D25507.1744255772.diff
Wed, Apr 9, 03:29
F3372232: D25507.1744249140.diff
Wed, Apr 9, 01:39
F3369585: D25507.1744215593.diff
Tue, Apr 8, 16:19
F3369037: D25507.1744212767.diff
Tue, Apr 8, 15:32

Details

Summary

Add a documentation link in a specific Config page, that is:

Config > Setting > user.custom-field-definitions

Test Plan

Visit the page and click on the new link:

  • /config/edit/user.custom-field-definitions/

Visit this page that was the inspirational page:

  • /config/edit/maniphest.custom-field-definitions/

No nuclear implosions.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tested locally, all in all +1 but capitalization is inconsistent comparing to maniphest.custom-field-definitions: Custom Fields twice and User Profiles once should use lower-case.

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...

This revision is now accepted and ready to land.Jan 13 2024, 02:37