Page MenuHomePhorge

Config User Extra Fields: link to the doc (like Maniphest)
ClosedPublic

Authored by valerio.bozzolan on Jan 8 2024, 09:07.
Tags
None
Referenced Files
F2963131: D25507.1739198091.diff
Sun, Feb 9, 14:34
F2963130: D25507.1739198087.diff
Sun, Feb 9, 14:34
F2961693: D25507.1739169810.diff
Sun, Feb 9, 06:43
F2961690: D25507.1739169803.diff
Sun, Feb 9, 06:43
F2961506: D25507.1739163666.diff
Sun, Feb 9, 05:01
F2961025: D25507.1739155204.diff
Sun, Feb 9, 02:40
F2947347: D25507.1738464398.diff
Sat, Feb 1, 02:46
F2935543: D25507.1737855080.diff
Sat, Jan 25, 01:31

Details

Summary

Add a documentation link in a specific Config page, that is:

Config > Setting > user.custom-field-definitions

Test Plan

Visit the page and click on the new link:

  • /config/edit/user.custom-field-definitions/

Visit this page that was the inspirational page:

  • /config/edit/maniphest.custom-field-definitions/

No nuclear implosions.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tested locally, all in all +1 but capitalization is inconsistent comparing to maniphest.custom-field-definitions: Custom Fields twice and User Profiles once should use lower-case.

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...

This revision is now accepted and ready to land.Jan 13 2024, 02:37