Page MenuHomePhorge
Differential D25512

Fix config transaction rendering error on auth page by allowing PhutilSafeHTML
ClosedPublic
Actions

Authored by doommius on Jan 12 2024, 11:34.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 15:27
Unknown Object (File)
Sun, Apr 28, 04:49
Unknown Object (File)
Thu, Apr 25, 22:35
Unknown Object (File)
Wed, Apr 17, 18:20
Unknown Object (File)
Wed, Apr 17, 06:50
Unknown Object (File)
Thu, Apr 4, 01:41
Unknown Object (File)
Thu, Apr 4, 01:34
Unknown Object (File)
Mar 30 2024, 16:31
View All 33 Files
Subscribers
Cigaryno
Matthew
sirocyl
tobiaswiese
valerio.bozzolan

Details

Reviewers
speck
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML.
Commits
rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing…
rPb445e1d80df9: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML
Summary

Closes T15706

Test Plan

Checked that the page worked as expected with changes implemented

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

doommius created this revision.Jan 12 2024, 11:34
Owners added a reviewer: O1: Blessed Committers.Jan 12 2024, 11:34
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJan 12 2024, 11:34
doommius requested review of this revision.Jan 12 2024, 11:34
Harbormaster completed remote builds in B1014: Diff 1627.Jan 12 2024, 11:34
doommius added a task: T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..Jan 12 2024, 11:35
aklapper retitled this revision from Fixed get title error when opening auth page, see T15706 to Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.Jan 12 2024, 11:58
aklapper edited the summary of this revision. (Show Details)
aklapper edited the test plan for this revision. (Show Details)
aklapper mentioned this in D25513: Work in progress discord auth.Jan 12 2024, 12:26
speck accepted this revision.Jan 12 2024, 13:23
This revision is now accepted and ready to land.Jan 12 2024, 13:23
valerio.bozzolan accepted this revision.Jan 12 2024, 13:58

Double-accept yeah

valerio.bozzolan added a parent revision: D25513: Work in progress discord auth.Jan 12 2024, 14:01
valerio.bozzolan added a comment.Jan 14 2024, 14:29

Thanks again for this change. Please try "landing" with these two commands:

arc patch D25512
arc land
valerio.bozzolan added a subscriber: sirocyl.Feb 12 2024, 10:47

@sirocyl Does this fix your issue? if yes, I can help in landing

sirocyl added a comment.Feb 12 2024, 10:52
In D25512#15325, @valerio.bozzolan wrote:

@sirocyl Does this fix your issue? if yes, I can help in landing

Works a charm.

Closed by commit rPb445e1d80df9: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML. · Explain WhyFeb 12 2024, 10:52
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rPb445e1d80df9: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
valerio.bozzolan removed a parent revision: D25513: Work in progress discord auth.Feb 12 2024, 10:56
valerio.bozzolan added a child revision: D25513: Work in progress discord auth.
avivey added a commit: rPd519f75dfdee: (stable) Fix config transaction rendering error on auth page by allowing….Mon, Apr 15, 16:36
valerio.bozzolan mentioned this in 2023 week 49.Tue, Apr 30, 09:55

Revision Contents
Changeset List

PathSizePackages
src/
applications/
auth/
storage/
2 linesO1: Blessed Committers

Diff 1692

View Options

src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0