Hi deric,
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 7 2024
Alternatively, maybe catch the existing exception and show a nice error message + the form?
Still red light? Thanks :)
the simplest other-solution would be to extract the exception thrown to its own method, and override that method in the child-class:
How about other functions that might require a logged-in user? "current Viewer's Projects" for example?
Jan 6 2024
In D25505#14525, @20after4 wrote:Is this needed simply because PhabricatorApplicationSearchController doesn't actually have a try { } block to catch this particular case? Maybe we could improve the exception handling instead of return null?
Jan 5 2024
Is this needed simply because PhabricatorApplicationSearchController doesn't actually have a try { } block to catch this particular case? Maybe we could improve the exception handling instead of return null?
Jan 4 2024
Without D25505 applied:
Remove a forgotten debug line
This is not ready for merge yet.
Jan 2 2024
Indeed ideally I'd prefer to convert the current use of PhabricatorSearchTextField for an integer value to a functioning PhabricatorSearchIntField (which should return a future new AphrontFormIntControl()) instead, thus I'm reluctant to land this (though it remains a mystery to me how to set a default value (not: placeholder) in any non-dropdown field).
Replace minus dash by its UTF8 representation to pass lint
Dec 31 2023
Dec 30 2023
In D25501#14443, @aklapper wrote:This also needs rework because I still get a Query overheated when not being logged in and going to http://phorge.localhost/feed/transactions/query/all/
Dec 29 2023
So, as default, a transform is created. Should we attach that transform instead?
Dec 28 2023
Dec 27 2023
Would you like to propose a small cute patch for this? It's just a matter of running arc diff or ../arcanist/bin/arc diff
In addition, it seems only the owner can see their stuff here.
unknown magic accepts any kind of input (e.g. letters) and converts it into a 0.
Thanks! some quick tips maybe relevant:
In D25479#14404, @avivey wrote:Yeah, looks like IntField isn't doing much now (yet?). It could get setDefault() like PhabricatorSearchSelectField, plus validateControlValue()
Dec 26 2023
This also needs rework because I still get a Query overheated when not being logged in and going to http://phorge.localhost/feed/transactions/query/all/
There might be room for performance improvements - currently for each $query, PhabricatorApplication::isClassInstalledForViewer is called again though some queries share the same application.
Dec 25 2023
Document abstract function that it can return string|null
Also looked into very hackish $application_of_query = preg_split('/(?=[A-Z])/', get_class($query)); but the *TransactionQuery.php class naming scheme is too inconsistent, e.g. PhabricatorSpacesTransactionQuery instead of SpacesTransactionQuery (same for Slowvote, Phurl, Owners, Badges, Calendar, Packages, Paste, maybe more).
If it still works, feel free to land
Dec 24 2023
probably "low", but might be interesting to investigate.
Dec 23 2023
Improve performance (as proposed by Valerio)
Yeah, looks like IntField isn't doing much now (yet?)
Dec 21 2023
That's so weird! My instinct is of course to say that it should be completely unrelated to this patch since no CSS is touched in this one-line change... I have no idea how to debug this ☹️
I ended up running this
I think it might be applicable here and in several other places that follow the general pattern of “look up all subclasses of a given feature and then loop over all of them to run extension hooks “
@20after4 suggested an "is-application-installed"-aware class-finder recently - I wonder if that would also handle this?
Argh, note to myself: Simply define $hide_packages = (!id(new PhabricatorPackagesApplication())->isInstalled()); and add ->setIsHidden($hide_packages)...
Dec 20 2023
They have no space at FOSDEM 2024 for Phorge, nor in Collaboration and..., nor in Lightning talks :(
I close this as invalid since we received no additional feedback. Feel free to add more details :) Thanks \o/
Nah my friend, sorry me, my example was incomplete. I've updated that.
Dec 19 2023
I'm too stupid to see the exact optimization, performance-wise (but probably not important). :)
I think that the best alternative we have for that, is YunoHost. So, an Open Source suite to easily deploy applications on your server. Give it a try. If you like it, I think that, there, Phorge may land.