task @ https://we.phorge.it/T15708 contains information on status, TODOs and questions about implementation
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15708: Discord as auth method
It's a work in progress but auth using discord and passing of basic user information works.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- master
- Lint
Lint Warnings Severity Location Code Message Warning src/applications/auth/adapter/PhutilDiscordAuthAdapter.php:40 TXT3 Line Too Long Warning src/applications/auth/adapter/PhutilDiscordAuthAdapter.php:96 TXT3 Line Too Long Warning src/applications/auth/adapter/PhutilDiscordAuthAdapter.php:117 XHP26 Space After Control Statement - Unit
Test Failures - Build Status
Buildable 1016 Build 1016: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 153 ms | PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`.
These entries differ: .
| |
| 261 ms | PhabricatorAuthPasswordTestCase::testCompare 2 assertions passed. | |
| 10 ms | PhabricatorAuthPasswordTestCase::testPasswordBlocklisting 15 assertions passed. | |
| 1,073 ms | PhabricatorAuthPasswordTestCase::testPasswordEngine 20 assertions passed. | |
| 223 ms | PhabricatorAuthPasswordTestCase::testPasswordUpgrade 9 assertions passed. | |
| View Full Test Results (1 Failed · 11 Passed) |
Event Timeline
Comment Actions
Also, apart from the linter results, this patch should not include the changes from D25512
Comment Actions
(Small tip: never work in master. Create a git branch for each feature, in sync with origin/master, and with your commits on top of that, so your patch is minimal and arc diff works)
Comment Actions
I am working in a separate branch locally but arc diff gave me some issues with trying to create the diff via the tool locally so i just merged to master and created the diff.
Comment Actions
Yes, but that patch is required for the development of this feature as the string parsing breaks the auth config page :)
| src/applications/auth/adapter/PhutilDiscordAuthAdapter.php | ||
|---|---|---|
| 40 | We have urisprintf, that might work better here. | |