Nuance has a "GitHub Repository: Import issues and pull requests from a GitHub repository" Source Type - it might already be doing something related?

LGTM! :D

hey, @ton - is this useful for you?

yeah, just default to https if it doesn't include a schema, and I think it should be fine in that regards.
There's probably already some method somewhere that looks at a uri and chooses HTTPFuture or HTTPSFuture based on the schema...

I'm guessing this would break existing configurations. (Or we could detect if the endpoint contains the schema and prepend https:// only if it doesn't - for backwards compatibility).

• rollback CSS change

Better now?

• integrate tips from reviewers

Just to inform that maybe a sub-task bug report will be created soon. Related discussion: https://phabricator.wikimedia.org/T333885#9132176

(I accepted but before landing please first review all not-done inline comments: https://we.phorge.it/differential/revision/inlines/25420/ and this comment: https://we.phorge.it/D25420#12264 )

In D25420#12264, @waldyrious wrote:

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

• Instead of "You can ignore this conflict or adjust your profile setting to match your client", we should use the same order in the sentence as the options are shown to the user: "You can adjust your profile setting to match your client, or ignore this conflict."
• The label for the checkbox should be just "Ignore Conflict", without the "Or" at the start.
• When the "Ignore Conflict" checkbox is selected, the timezone dropdown should be disabled (and re-enabled if the checkbox is unmarked)

Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".

In D25425#12230, @valerio.bozzolan wrote:

maybe in the future we can have a CSS selector to be applied just to the "phorge/" pathname, in order to avoid mouse selection, and select just the command.

In D25426#12221, @avivey wrote:

See D25420 for a conflicting change...

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

Check out https://we.phorge.it/book/contrib/article/javascript_coding_standards/ and the Javeline docs here: https://github.com/phacility/javelin/tree/master/src/docs/concepts
(I'll try to render the Javeline guide here later).

Sorry, I mean this link:

I absolutely don't know what we are doing here since I don't know the supposed "Phabricator way" to interact with the DOM via JavaScript using its library.

Screenshot from:

We were able to push Phorge subliminal messages in an official Wikimedia video \o/

Yeah thanks! Maybe we can somehow keep the footer, in order to have a link for people like me that just have their brain switched-off and just look at the bottom link. Also maybe we can simplify a little bit.

Thanks for this patch. Yeah if I understand correctly, this should work:

I'm Valerio, a simple person: I see "GNU/Linux" and I say "yeah, land".

See D25420 for a conflicting change...

ooh, check out D25349 for basically this exact use-case...

IMO the added text should be connected to the second sentence of the existing third paragraph, maybe as a separate paragraph. In fact I'd suggest re-grouping the paragraphs differently, to focus on a brief intro, info for users, and info for contributors. Perhaps something like this:

@valerio.bozzolan I found the js section where with the listener for open/close the persistent chat. From there I can get element somehow (by ID I don't think it would be good, because it seems to be auto-generated (UQ3_0)) and remove the class "core-menu-item" and the invisible gear icon will no longer be clickable. If the chat is not minimized, we add the class back so we can see it and click it.

cosmetic whitespace changes

Updating D25420:

This is very promising. Just added an inline comment

if you check the checkbox, it will use the current setting timezone.