Page MenuHomePhorge
Feed Advanced Search

Aug 19 2023

valerio.bozzolan added a comment to D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.

Thanks my friend

Aug 19 2023, 04:03
valerio.bozzolan accepted D25393: Fix answer background color when using Dark Mode in Ponder.

You are a good minion, thanks bob

Aug 19 2023, 03:52
valerio.bozzolan resigned from D25305: Workboard: have thin scrollbars.

I will kindly resign since I'm terrible at frontend :) Others: please help here

Aug 19 2023, 03:48
valerio.bozzolan added a comment to D25305: Workboard: have thin scrollbars.

For faster review I would like to try to explain better to others why it was necessary to change so many selectors to change the Workboards scrollbar, but I'm not 100% sure about .phui-flank-view-body and the shadow thing.

Aug 19 2023, 03:41
valerio.bozzolan added a comment to D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Can somebody else test this? I need more time, since I have issues with hosted repositories at the moment :(

Aug 19 2023, 02:55
valerio.bozzolan retitled D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
Aug 19 2023, 02:52
valerio.bozzolan accepted D25411: Fix PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar.

Thanks! Tested locally. This seems separated from the mentioned regression. Indeed the recurrence ID and the instance ISO seems that must be strings, or NULL, and any other value will cause a violent nuclear implosion as usual, and Phorge somehow likes it.

Aug 19 2023, 02:51
valerio.bozzolan triaged T15619: Calendar: Impossible to import .ics file (Phorge checks for a non-existing remote URI) as Normal priority.

Interesting. ICS URI import was fixed in 02a4f8b0c8f1279fc but at the cost of breaking ICS file import.

Aug 19 2023, 02:45 · Affects-Wikimedia, Bug Reports, Calendar
valerio.bozzolan retitled D25413: Show a link to the Phorge homepage from Show a link to the Phorge homepage It seems we were missing a link to the project homepage. Also we set the language of the HTML document.
Aug 19 2023, 02:38
valerio.bozzolan requested review of D25413: Show a link to the Phorge homepage.
Aug 19 2023, 02:37
valerio.bozzolan accepted D25412: PHP 8 and Diviner Technical Documentation.

Tested both cases, thanks

Aug 19 2023, 01:46
valerio.bozzolan updated the summary of D25412: PHP 8 and Diviner Technical Documentation.
Aug 19 2023, 01:45

Aug 18 2023

valerio.bozzolan closed D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 16:02
valerio.bozzolan committed rP3cc5ee6a33df: Documentation: fix unexisting path sshd_config.phabricator.example.
Documentation: fix unexisting path sshd_config.phabricator.example
Aug 18 2023, 16:02
valerio.bozzolan retitled D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
Aug 18 2023, 11:05
valerio.bozzolan added inline comments to D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 11:03
valerio.bozzolan retitled D25410: Documentation: fix unexisting path sshd_config.phabricator.example from Documentation: fix unexisting path sshd_config.phabricator.example Since the example file was renamed, this change makes the documentation consistent with it. Also we added exactly one-space somewhere, to create a super-satisfying indentation in...
Aug 18 2023, 11:01
valerio.bozzolan requested review of D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 11:00
valerio.bozzolan added a revision to T15006: Re-brand Phorge: D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
Aug 18 2023, 11:00 · Phorge
valerio.bozzolan accepted D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Yeah anyway this looks great

Aug 18 2023, 10:35
valerio.bozzolan accepted D25387: Error handling: send Deprecation messages as explicit Event.

SUPER NICE \o/ THANKS

Aug 18 2023, 09:58
valerio.bozzolan accepted D25386: log deprecation events in Dark Console.

Tested with and without D25387.

Aug 18 2023, 09:47
valerio.bozzolan added inline comments to D25305: Workboard: have thin scrollbars.
Aug 18 2023, 09:35
valerio.bozzolan requested review of D25408: Fix Exception in Chat room when you are not a Participant.
Aug 18 2023, 08:55
valerio.bozzolan added a revision to T15497: Exception when viewing incoming Chat room messages, when not in Participants: D25408: Fix Exception in Chat room when you are not a Participant.
Aug 18 2023, 08:55 · Conpherence
valerio.bozzolan renamed T15497: Exception when viewing incoming Chat room messages, when not in Participants from Exception when opening room to Exception when viewing incoming Chat room messages, when not in Participants.
Aug 18 2023, 08:52 · Conpherence
valerio.bozzolan updated subscribers of T15497: Exception when viewing incoming Chat room messages, when not in Participants.

This happened some minutes ago to our friend @waldyrious and I was able to reproduce it on my local computer. I've attached my reproducing instructions.

Aug 18 2023, 08:50 · Conpherence
valerio.bozzolan triaged T15497: Exception when viewing incoming Chat room messages, when not in Participants as Normal priority.
Aug 18 2023, 08:48 · Conpherence
valerio.bozzolan added a comment to D25343: Rebrand: Add "path" entries to PlatformSymbols.

Maybe to be it consistent with "super-rebranded-product/" :D I don't know

Aug 18 2023, 08:46
valerio.bozzolan updated the test plan for D25079: Trigger: Add Sound "Coin".
Aug 18 2023, 07:58
valerio.bozzolan added a comment to T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally.

Yeah fixed in D25104

Aug 18 2023, 07:51 · PHP 8 support
valerio.bozzolan updated the diff for D25079: Trigger: Add Sound "Coin".

I've just:

Aug 18 2023, 07:51
valerio.bozzolan awarded T15616: PHP 8.1 "strlen(null)" exception when setting up Phorge locally a Cup of Joe token.
Aug 18 2023, 07:44 · PHP 8 support
valerio.bozzolan renamed T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer from PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer to PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer.
Aug 18 2023, 07:41 · PHP 8 support
valerio.bozzolan updated the test plan for D25079: Trigger: Add Sound "Coin".
Aug 18 2023, 07:38
valerio.bozzolan added a member for Trusted Contributors: waldyrious.
Aug 18 2023, 07:32
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.

git rebase master

Aug 18 2023, 07:21
valerio.bozzolan requested changes to D25403: Improve CelerityDarkModePostprocessor shade colors.

Let's visually mark this as needing still some work

Aug 18 2023, 07:18
valerio.bozzolan accepted D25401: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

Aug 18 2023, 07:16
valerio.bozzolan accepted D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

I've tested this in place with my eyes on a friend's laptop with PHP 8.1 in the very same problem

Aug 18 2023, 06:26
valerio.bozzolan added a comment to D25403: Improve CelerityDarkModePostprocessor shade colors.

Nice job, my little and cute bob.. OH NO! a super-important regression! all of you minions will be fired soon!1!

Aug 18 2023, 04:43
valerio.bozzolan updated the name of F336217: Overcard Maniphest regress.png from "image.png" to "Overcard Maniphest regress.png".
Aug 18 2023, 04:43
valerio.bozzolan updated the test plan for D25403: Improve CelerityDarkModePostprocessor shade colors.
Aug 18 2023, 04:40
valerio.bozzolan accepted D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create.

OK I've found that this is about the legacy Conduit entry point for Paste.

Aug 18 2023, 02:59
valerio.bozzolan retitled D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create from Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit
Aug 18 2023, 02:51
valerio.bozzolan added a comment to D25405: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in Conduit paste.create.

I'm not able to trigger that part of the code.

Aug 18 2023, 02:49
valerio.bozzolan created P21 Command-Line Input.
Aug 18 2023, 02:42
valerio.bozzolan created P20 Command-Line Input.
Aug 18 2023, 02:39
valerio.bozzolan accepted D25406: Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit.

Tested with and without a value, thaaanks \o/

Aug 18 2023, 02:11
valerio.bozzolan closed T15615: Mobile: Differential lines should not be wrapped as Resolved by committing rP761134a1a9fe: Line counters: do not wrap when over 999 on mobile.
Aug 18 2023, 01:54 · UX, Differential
valerio.bozzolan closed D25407: Line counters: do not wrap when over 999 on mobile.
Aug 18 2023, 01:54
valerio.bozzolan committed rP761134a1a9fe: Line counters: do not wrap when over 999 on mobile.
Line counters: do not wrap when over 999 on mobile
Aug 18 2023, 01:54

Aug 17 2023

valerio.bozzolan requested review of D25407: Line counters: do not wrap when over 999 on mobile.
Aug 17 2023, 16:36
valerio.bozzolan added a revision to T15615: Mobile: Differential lines should not be wrapped: D25407: Line counters: do not wrap when over 999 on mobile.
Aug 17 2023, 16:36 · UX, Differential
valerio.bozzolan changed the visibility for F335624: Before.png.
Aug 17 2023, 16:30
valerio.bozzolan changed the visibility for F335621: After.png.
Aug 17 2023, 16:30
valerio.bozzolan changed the visibility for F335620: Before.png.
Aug 17 2023, 16:30
valerio.bozzolan added a cover image to T15615: Mobile: Differential lines should not be wrapped.
Aug 17 2023, 16:30 · UX, Differential
valerio.bozzolan triaged T15615: Mobile: Differential lines should not be wrapped as Low priority.
Aug 17 2023, 16:30 · UX, Differential
valerio.bozzolan edited the content of Next Up.
Aug 17 2023, 12:06
valerio.bozzolan edited the content of 2023 Week 32.
Aug 17 2023, 12:03
valerio.bozzolan edited the content of Next Up.
Aug 17 2023, 11:57
valerio.bozzolan accepted D25402: Fix hovercard background color when using Dark Mode.

Tested, nice thaaaanks, with and without dark mode.

Aug 17 2023, 10:56
valerio.bozzolan added a comment to D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Also this is an excuse to run arc diff again, since tests and lints were skippeds :^)

Aug 17 2023, 10:36
valerio.bozzolan added a comment to D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

I just mean that if($something) is usually avoided in Phorge "only and mainly" because if("0") is counter-intuitively false (so "0" is falsy even if it's a non-empty string). But here, we have not that problem, since "0" is a don't care value.

Aug 17 2023, 10:35
valerio.bozzolan retitled D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
Aug 17 2023, 09:30
valerio.bozzolan added a comment to D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Thaanks bob

Aug 17 2023, 09:27
valerio.bozzolan added a comment to D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

For some reasons I'm not able to trigger this problem, but that seems perfect to me, thaaaaanks

Aug 17 2023, 09:15
valerio.bozzolan added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.

Yeah feel free to land this as-is, that was easy-peasy accepted

Aug 17 2023, 08:34
valerio.bozzolan accepted D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Aug 17 2023, 08:25
valerio.bozzolan added a comment to D25396: Fix source code viewer background color when using Dark Mode in Diffusion.

Nice thaaanks

Aug 17 2023, 08:24
valerio.bozzolan retitled D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of preg_match with a NULL argument
Aug 17 2023, 08:00
valerio.bozzolan accepted D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.

Yeah thanks

Aug 17 2023, 08:00
valerio.bozzolan retitled D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
Aug 17 2023, 07:47
valerio.bozzolan added a comment to D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Thanks for this change! Just a small thing

Aug 17 2023, 07:45
valerio.bozzolan added inline comments to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Aug 17 2023, 02:33

Aug 16 2023

valerio.bozzolan accepted D25392: Fix PHP 8.1 "strlen(null)" exception listing >100 task search results.

I tested this without finding any nuclear implosion. Thanks!

Aug 16 2023, 04:02
valerio.bozzolan added inline comments to D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.
Aug 16 2023, 02:49

Aug 15 2023

valerio.bozzolan awarded D25378: Fix PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster a Orange Medal token.
Aug 15 2023, 13:58
valerio.bozzolan updated the diff for D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.

arc lint
arc unit

Aug 15 2023, 09:13
valerio.bozzolan accepted D25362: Show more in Application Detail and List view.

Please wait more feedback from avivey, but I wanted to say that I tested this and I love it

Aug 15 2023, 08:02
valerio.bozzolan accepted D25343: Rebrand: Add "path" entries to PlatformSymbols.

Yeah why not. asd

Aug 15 2023, 07:55
valerio.bozzolan accepted D25391: Fix call to undefined method PhutilJSON::encodeAsObject().

Thanks for this change that looks absolutely reasonable.

Aug 15 2023, 07:30
valerio.bozzolan accepted D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.

This seems totally backward compatible to me

Aug 15 2023, 04:36
valerio.bozzolan added a comment to D25391: Fix call to undefined method PhutilJSON::encodeAsObject().

Thanks for this. I need a double-check since I'm quite scared by the background of this root problem but fortunately this seems to have just one occurrence, the one you are fixing.

Aug 15 2023, 04:22
valerio.bozzolan accepted D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.

I love this change, I've looked inside the logic and it seems very correct to me,

Aug 15 2023, 03:54
valerio.bozzolan accepted D25384: Fix icon background color when using Dark Mode.

Yeah bob this change was already accepted, and now it's super-accepted. This change is adorable, thanks!

Aug 15 2023, 00:57
valerio.bozzolan updated the summary of D25384: Fix icon background color when using Dark Mode.
Aug 15 2023, 00:56
valerio.bozzolan updated the name of F331623: Choose User Icon Dark Mode - Fixed.png from "image.png" to "Choose User Icon Dark Mode - Fixed.png".
Aug 15 2023, 00:56
valerio.bozzolan updated the name of F331622: Choose User Icon Dark Mode - Broken.png from "image.png" to "Choose User Icon Dark Mode - Broken.png".
Aug 15 2023, 00:55
valerio.bozzolan updated the task description for T15056: Improve Dark Mode.
Aug 15 2023, 00:52 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
valerio.bozzolan added a revision to T15056: Improve Dark Mode: D25384: Fix icon background color when using Dark Mode.
Aug 15 2023, 00:50 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
valerio.bozzolan updated the summary of D25384: Fix icon background color when using Dark Mode.
Aug 15 2023, 00:50
valerio.bozzolan updated the test plan for D25384: Fix icon background color when using Dark Mode.
Aug 15 2023, 00:48

Aug 11 2023

valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Aug 11 2023, 17:01 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to D25384: Fix icon background color when using Dark Mode.

Please also manually run this

Aug 11 2023, 17:00
valerio.bozzolan attached a referenced file: F310031: Screenshot from 2023-06-14 20-30-01.png.
Aug 11 2023, 16:59
valerio.bozzolan attached a referenced file: F310033: Screenshot from 2023-06-14 20-29-29.png.
Aug 11 2023, 16:59
valerio.bozzolan added a comment to T15056: Improve Dark Mode.

Yeah bob, feel free to add your nice screenshots in the Task description for more visibility. You are a good minion!

Aug 11 2023, 16:58 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
valerio.bozzolan added a comment to D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.

Thanks! Interestingly you fixed an incomplete fix since D25128

Aug 11 2023, 09:51