Page MenuHomePhorge

DifferentialTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Mar 1 2024

avivey added a revision to T15133: Differential List View should show Repository: D25548: Add (Advanced) Custom Fields to Item List.
Mar 1 2024, 11:36 · Differential
avivey claimed T15133: Differential List View should show Repository.
Mar 1 2024, 09:37 · Differential

Feb 22 2024

aklapper added a comment to T15738: "parent"/"child" relationship for "Related Revisions" is different to "Related Tasks".

See discussion and reasons in https://secure.phabricator.com/T11833

Feb 22 2024, 13:21 · UX, Differential
aklapper renamed T15738: "parent"/"child" relationship for "Related Revisions" is different to "Related Tasks" from Make "Related Revisions" more similar to "Related Tasks" (magical quiz inside) to "parent"/"child" relationship for "Related Revisions" is different to "Related Tasks".
Feb 22 2024, 13:21 · UX, Differential

Feb 12 2024

bekay added a comment to T15039: Add a button to copy key information.
In T15039#1358, @bekay wrote:

The clone repo modal could really use some copy buttons.

image.png (282×854 px, 20 KB)

Preferably replacing the Read / Write Button.

Feb 12 2024, 16:50 · Differential
valerio.bozzolan added a comment to T15410: Discussion: stacked diffs / dependent revisions.

So maybe this is just a matter of parsing that commit part "Depends-on:" since everything else seem already implemented to me. Partially related quiz in T15738

Feb 12 2024, 13:49 · Differential
valerio.bozzolan triaged T15738: "parent"/"child" relationship for "Related Revisions" is different to "Related Tasks" as Wishlist priority.
Feb 12 2024, 13:43 · UX, Differential

Feb 9 2024

philj0st asked Q109: Multiple commits in one Audit?.
Feb 9 2024, 14:08 · Diffusion, Differential

Feb 1 2024

20after4 added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

can confirm, https://we.phorge.it/D25342?id=1111 does show an error for me in an incognito window.

Feb 1 2024, 15:52 · Bug Reports, Differential
valerio.bozzolan added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

Probably, something should "Attach" these files by default to that Diff, during the upload phase.

Feb 1 2024, 12:09 · Bug Reports, Differential
valerio.bozzolan added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

A workaround is to make all files as "Public". I fixed for example the diff D25079: Trigger: Add Sound "Coin" by setting the audio file F1271256 as public.

Feb 1 2024, 12:08 · Bug Reports, Differential
valerio.bozzolan raised the priority of T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out from Normal to High.
Feb 1 2024, 12:03 · Bug Reports, Differential

Jan 13 2024

aklapper closed T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark as Resolved by committing rARC6c7caf3572f4: Correct manual upload of Differential patch with a leading BOM.
Jan 13 2024, 21:05 · Differential
speck added a comment to T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark.

Hmm I’ve used mercurial and arcanist/Phab for years at my company and don’t believe we’ve ever run into this. Any idea what’s causing the presence of the BOM? We’ll apply a change to handle the UTF-8 bom but I am curious what may have caused it to show up. Is your hgrc configured in some way for this or maybe an environment variable?

Jan 13 2024, 15:42 · Differential
aklapper added a revision to T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark: D25514: Correct manual upload of Differential patch with a leading BOM.
Jan 13 2024, 10:21 · Differential
aklapper renamed T15452: Differential drops a diff's first hunk if the file starts with a Byte-order-Mark from Differntial drops a diff's first hunk if the file starts with a Byte-order-Mark to Differential drops a diff's first hunk if the file starts with a Byte-order-Mark.
Jan 13 2024, 02:50 · Differential

Sep 23 2023

avivey added a project to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land": UX.

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

Sep 23 2023, 06:11 · UX, Differential
avivey updated the task description for T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".
Sep 23 2023, 05:53 · UX, Differential

Sep 22 2023

waldyrious added a comment to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".

By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.

Sep 22 2023, 20:30 · UX, Differential
waldyrious added a comment to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".

How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.

Sep 22 2023, 20:28 · UX, Differential

Sep 20 2023

valerio.bozzolan added a comment to T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".

I'm trying to imagine a title that also involves the UX in general about accepting revisions, since it's also about the "Accept Revision" button, but my brain is not helping me right now in this

Sep 20 2023, 15:43 · UX, Differential
valerio.bozzolan updated the task description for T15510: Make email clear about "Someone accepted revision" vs "Revision is ready to land".
Sep 20 2023, 15:42 · UX, Differential

Sep 17 2023

Dylsss merged task T15618: Lots of "Unknown Object"s referenced from revisions into T15110: File reference not removed when file is deleted.
Sep 17 2023, 23:32 · Differential, Bug Reports

Aug 31 2023

valerio.bozzolan triaged T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out as Normal priority.
Aug 31 2023, 07:46 · Bug Reports, Differential

Aug 20 2023

avivey added a parent task for T15250: Raw use of "git diff" provides insufficient Diff Context: T15535: Using Differential with plain Git, without requiring Arc.
Aug 20 2023, 08:20 · Affects-FreeBSD, Differential

Aug 18 2023

avivey added a project to T15618: Lots of "Unknown Object"s referenced from revisions: Differential.
Aug 18 2023, 09:07 · Differential, Bug Reports
valerio.bozzolan closed T15615: Mobile: Differential lines should not be wrapped as Resolved by committing rP761134a1a9fe: Line counters: do not wrap when over 999 on mobile.
Aug 18 2023, 01:54 · UX, Differential

Aug 17 2023

valerio.bozzolan added a revision to T15615: Mobile: Differential lines should not be wrapped: D25407: Line counters: do not wrap when over 999 on mobile.
Aug 17 2023, 16:36 · UX, Differential
valerio.bozzolan added a cover image to T15615: Mobile: Differential lines should not be wrapped.
Aug 17 2023, 16:30 · UX, Differential
valerio.bozzolan triaged T15615: Mobile: Differential lines should not be wrapped as Low priority.
Aug 17 2023, 16:30 · UX, Differential

Aug 15 2023

aklapper added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

I confirm for e.g. https://we.phorge.it/D25079 or https://we.phorge.it/D25079?id=355 or https://we.phorge.it/D25079?id=360 that this only happens when not being logged in. Or on https://we.phorge.it/D25342?id=1111 stacking four errors on top of each other.

Aug 15 2023, 17:57 · Bug Reports, Differential
aklapper renamed T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out from Unhandled exception shown for open differential revisions containing changes to images to Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
Aug 15 2023, 17:57 · Bug Reports, Differential

Aug 6 2023

valerio.bozzolan renamed T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends from Generate [From, Subject, Date] fields in download raw .diff URL to Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Aug 6 2023, 19:59 · Affects-FreeBSD, Differential

Aug 3 2023

valerio.bozzolan added a comment to T15410: Discussion: stacked diffs / dependent revisions.

I think that D25359 is a nice example of a complete use case, where one Diff from one repo depends from another Diff from another repo.

Aug 3 2023, 08:17 · Differential

Aug 2 2023

valerio.bozzolan merged T15252: Using a raw git diff asks for repository, then loses it into T15537: When creating revision from raw diff, "Repository" field is lost.
Aug 2 2023, 21:31 · UX, User-valerio.bozzolan, Differential
valerio.bozzolan merged task T15252: Using a raw git diff asks for repository, then loses it into T15537: When creating revision from raw diff, "Repository" field is lost.
Aug 2 2023, 21:31 · UX, Differential

Jul 27 2023

valerio.bozzolan closed T15170: Allow to edit Differential "inline comments" as Wontfix.

I've explored a bit the codebase and this seems a desired non-feature.

Jul 27 2023, 13:42 · Differential, User-valerio.bozzolan

Jul 26 2023

avivey updated the task description for T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Jul 26 2023, 15:48 · Affects-FreeBSD, Differential
valerio.bozzolan updated the task description for T15332: Allow comment authors to change their inline comment Status (Done / Not Done).
Jul 26 2023, 10:41 · User-valerio.bozzolan, Differential
valerio.bozzolan added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Uh thanks! Feel free to increase the "Hours invested" counter in the Task description ihih

Jul 26 2023, 07:22 · Affects-FreeBSD, Differential
avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

Ok, I got bored.

Jul 26 2023, 04:47 · Affects-FreeBSD, Differential
avivey added a revision to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends: D25359: Generate more fields in Download Raw Diff.
Jul 26 2023, 04:43 · Affects-FreeBSD, Differential
avivey added a revision to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends: D25358: Let ArcanistBundle print some Git patch headers.
Jul 26 2023, 04:36 · Affects-FreeBSD, Differential

Jul 25 2023

valerio.bozzolan renamed T15332: Allow comment authors to change their inline comment Status (Done / Not Done) from Allow more people to mark an inline comment as "Done" to Allow comment authors to change their inline comment Status (Done / Not Done).
Jul 25 2023, 12:38 · User-valerio.bozzolan, Differential
valerio.bozzolan closed T15538: Update Patch: it's dead-end if not yours as Resolved by committing rP1e3c9bdfee76: Update Diff: fix dead-end when not yours.
Jul 25 2023, 12:15 · User-valerio.bozzolan, UX, Differential
valerio.bozzolan updated the task description for T15538: Update Patch: it's dead-end if not yours.
Jul 25 2023, 08:34 · User-valerio.bozzolan, UX, Differential

Jul 24 2023

valerio.bozzolan added a comment to T15538: Update Patch: it's dead-end if not yours.

I think we have an implementation:

Jul 24 2023, 08:59 · User-valerio.bozzolan, UX, Differential
valerio.bozzolan updated the task description for T15538: Update Patch: it's dead-end if not yours.
Jul 24 2023, 08:58 · User-valerio.bozzolan, UX, Differential

Jul 22 2023

avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

My plan is:

  • If there's a commit information in the revision, use the author name and email from there. Not that this might not be the same as the revision's Author
  • If there's no git commit - use author name from Author field, and make up email address (annonymos@example.com).
Jul 22 2023, 21:42 · Affects-FreeBSD, Differential
ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

@avivey Yes I think this is what we need.
There is a caveat though:

Jul 22 2023, 20:50 · Affects-FreeBSD, Differential