Page MenuHomePhorge

avivey (Aviv Eyal)
UserAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 05:36 (197 w, 2 d)
Roles
Administrator
Availability
Available
Timezone
UTC+2

Recent Activity

Thu, Mar 20

avivey added a comment to T16016: Phantom notification.

I don't understand the problem described...

Thu, Mar 20, 09:15 · Maniphest

Wed, Mar 19

avivey added a comment to T16007: Discuss the policy for contributing to prototype applications.

I'm not familiar with MediaWiki's packages - the model I'm copying is VSCode.
My thought is that in the install manual we'll say "now run ./bin/extensions install phorge-recommended-extensions" (near the ./bin/storage) step, and phorge-recommended-extensions would be the equivalent of "extension pack" hosted on the default Extension Store, which is hosted here.
(VSCode also has "bundled extensions", which I think doesn't work for us because we use "clone the repo" as the primary distribution system).

Wed, Mar 19, 09:10 · Discussion Needed, User-Cigaryno
avivey added a comment to T16007: Discuss the policy for contributing to prototype applications.

The "Prototype" concept was a way for Phacility to experiment with things without committing - but we have a different model today.

Really!? Phacility SaaS instances do not allow enabling prototypes and self-hosted Support (from the Support application on admin.phacility.com that was oddly marked as Prototype) likely wasn't even available for prototype applications.

Wed, Mar 19, 07:54 · Discussion Needed, User-Cigaryno
avivey added a comment to T15203: Remarkup: allow to mention a Slowvote (without embedding).

On this server, we changed the config to /^(Q|V|M)\d$/ because we don't have P1 tickets.
I'm also not sure what M is short for.

Wed, Mar 19, 07:40 · User-valerio.bozzolan, Remarkup
avivey added a comment to T15450: Configure another Ponder Question status "Closed, Graduated".

To me, "obsolete" manes "no longer appliable" - basically, "the information in this page doesn't apply any more".
Some (made up) examples:

  • "Can Phorge run on PHP 7.0?" (The answer is no, because of a specific bug in 7.0, which was EOL a long time ago)
  • "I have this problem in the Chatbot app" (We've deleted the chatbot app)
Wed, Mar 19, 07:34 · Feature Requests, Ponder, phorge.it install
avivey added a comment to T15203: Remarkup: allow to mention a Slowvote (without embedding).

The V123 syntax is disabled by remarkup.ignored-object-names config by default; The default is /^(Q|V|M|P)\d$/ (basically anything starting with Q, V, M, or P), for "Q1" (biz-talk for April), "V1" (for versions), "M1" (for ?????) and "P1" (Jira for "important bug").

Wed, Mar 19, 07:07 · User-valerio.bozzolan, Remarkup

Mon, Mar 17

avivey updated the task description for T16007: Discuss the policy for contributing to prototype applications.
Mon, Mar 17, 07:39 · Discussion Needed, User-Cigaryno
avivey added a comment to T16007: Discuss the policy for contributing to prototype applications.

My thought on this is that long term, we'll remove the concept of "prototype" completely in favor of Extensions.
The "Prototype" concept was a way for Phacility to experiment with things without committing - but we have a different model today.

Mon, Mar 17, 07:39 · Discussion Needed, User-Cigaryno

Sat, Mar 15

avivey added Q166: Support for request header and body in "Make HTTP Request" step in Harbormaster (Answer 214).
Sat, Mar 15, 15:53

Fri, Mar 7

avivey added a comment to D25905: Remove No Prototype Changes section from Contributing Code document.

@Cigaryno please create a task under Discussion Needed for this - I'm not sure we want to make this policy change.

Fri, Mar 7, 08:08 · Documentation

Thu, Mar 6

avivey added a comment to D25904: Update XHPast for Windows binary to 7.1.6.

Do we have a task to remove this file from source-control?

Thu, Mar 6, 12:12

Mon, Mar 3

avivey added inline comments to D25897: Added a Mentions tab to the Differential Revision View.
Mon, Mar 3, 07:20
avivey awarded T16003: Differential Revision should show "Mentions" tab similar to how Maniphest Tasks do a Like token.
Mon, Mar 3, 07:15 · Differential

Sun, Mar 2

avivey added a comment to D25898: Add instructions to Create Repository form fields for Callsign and Short Name.

close enough for my taste; Just add . at the end of each sentence.

Sun, Mar 2, 08:24

Thu, Feb 27

avivey added a comment to D25898: Add instructions to Create Repository form fields for Callsign and Short Name.
  • There's already a "description" field on these, which I think was supposed to be displayed; We might have lost it at some point, which is concerning.
  • Use pht() for all human-visible text, to allow translation.
Thu, Feb 27, 16:04
avivey added a comment to Q171: Is there a way to disable pushes to master except for arc land? (Answer 212).

Need to go over the relevant code for deciding if a commit has an approved Revision - I think it looks mostly on the commit message.

Thu, Feb 27, 07:59

Wed, Feb 26

avivey added Q171: Is there a way to disable pushes to master except for arc land? (Answer 212).
Wed, Feb 26, 09:08

Sun, Feb 23

avivey added a comment to Q170: Is there a way to unland a diff? (Answer 211).

See also https://secure.phabricator.com/T1751 and rARC3116d3656ad017783e75df7e863368053d753e7f - looks like we had arc backout at some point for this, but it's no longer there.

Sun, Feb 23, 11:43
avivey added Q170: Is there a way to unland a diff? (Answer 211).
Sun, Feb 23, 10:49

Sat, Feb 22

avivey added a comment to T16001: Celerity unit test not triggered: mitigate thanks to Herald.

try now

Sat, Feb 22, 15:01 · User-valerio.bozzolan, phorge.it install
avivey changed the Can Manage Global Rules policy for application Herald from Administrators to Blessed Committers (Project).
Sat, Feb 22, 15:01
avivey added a comment to T16001: Celerity unit test not triggered: mitigate thanks to Herald.

@valerio.bozzolan go ahead and give it a try? I think you have access to create rules.

Sat, Feb 22, 10:15 · User-valerio.bozzolan, phorge.it install

Feb 15 2025

avivey added a comment to D25877: Mention on landing page that Phorge is a community fork of Phabricator.

I've deployed it (https://www.phorge.it/)

image.png (545×540 px, 88 KB)

Feb 15 2025, 11:25
avivey accepted D25877: Mention on landing page that Phorge is a community fork of Phabricator.
Feb 15 2025, 09:45

Feb 14 2025

avivey accepted D25874: Update installation guide to point to GitHub mirrors.

I'd like people to clone from GH less for the bandwidth and more for the availability - GH is more likely to be up then us.
Technically I guess GH might have an issue with that, but they probably won't notice anyway.

Feb 14 2025, 14:15

Feb 3 2025

avivey added a comment to T15987: Preview for patch files.

https://secure.phabricator.com/T13105 is the relevant historical meta-task, I didn't find a matching one here.

Feb 3 2025, 08:14 · Files

Feb 2 2025

waldyrious awarded T15504: If registration is disabled, show the button as disabled a Like token.
Feb 2 2025, 20:25 · Auth, Good Starter Task, UX

Jan 21 2025

avivey added inline comments to D25862: Communicate max dimensions of profile images before upload.
Jan 21 2025, 08:33
avivey added a comment to T15984: Communicate maximum dimensions of avatar images.

Oh, I miss-understood the problem statement. The 4096 limit is on the size of the image that we can resize from...

Jan 21 2025, 08:26 · Projects

Jan 20 2025

avivey added a comment to T15984: Communicate maximum dimensions of avatar images.

I'd expect it to just resize the image as needed....

Jan 20 2025, 13:33 · Projects

Dec 29 2024

avivey accepted D25860: Fix typos etc..

two items re: phrasing, but otherwise LGTM.

Dec 29 2024, 12:23

Dec 24 2024

keithzg awarded T15233: Projects: add "Tasks", "Revisions" menu items a Like token.
Dec 24 2024, 20:45 · Feature Requests, Affects-Wikimedia
avivey added Q162: Custom searches attached to project menus that filter to current project? (Answer 203).
Dec 24 2024, 09:16
avivey created T15981: In feed story for "Edited Phriction doc", add link to diff.
Dec 24 2024, 09:09 · Feed, Good Starter Task, Phriction
avivey added Q163: Failure starting after upgrade from Phabricator (Answer 202).
Dec 24 2024, 09:04

Dec 23 2024

avivey added Q161: strange things (typo and other) in Phabricator (Answer 201).
Dec 23 2024, 07:44
avivey created T15980: Handle typos from Q161.
Dec 23 2024, 07:42 · Good Starter Task

Dec 22 2024

avivey added a comment to T15207: Legalpad restrictions on this install.

I've set can create to Trusted Contributors for now. I don't see a problem with people being able to create documents.

Dec 22 2024, 09:29 · Governance, User-Cigaryno
avivey changed the Can Create Documents policy for application Legalpad from All Users to Trusted Contributors (Project).
Dec 22 2024, 09:27

Dec 20 2024

avivey accepted D25858: Phriction: define an object creation title.
Dec 20 2024, 08:40

Dec 19 2024

avivey accepted D25857: Replace some Phabricator references in PhabricatorStartup.php on comments and errors.
Dec 19 2024, 14:00
avivey added a comment to T15643: Support marking text with <ins> in Remarkup.

If the goal is to make it denote "inserted text", I think it should be visually different to "underline" - something more similar to the green we use for actual diff views, maybe more subtle. Will need special handling in the color-blindness themes.

Dec 19 2024, 08:09 · Feature Requests, Remarkup

Dec 18 2024

avivey added a comment to T15979: Can't grant notification permission to browser.

The "Grant permission" button works for me on Chrome/Windows.

Dec 18 2024, 07:49 · User-Cigaryno, Bug Reports

Dec 17 2024

avivey added a comment to T15121: Contributor Agreement.

I think that for the "the name I use is not my legal name" use-case, I'm pretty sure it's fine to use the name that is actually used (because that's what the person is normally known as). It's probably easier to justify accepting a name that is used in real life then "internet handle", but ㄟ( ▔, ▔ )ㄏ

Dec 17 2024, 10:24 · Phorge

Dec 15 2024

avivey added a comment to T15121: Contributor Agreement.

Would the CLA have to be signed with one's legal name?

Dec 15 2024, 08:35 · Phorge

Dec 11 2024

avivey added a comment to T15972: Add config option for maximum file size.

(we can probably keep this ticket open, so that we have the 2nd part on the backlog. I'm pretty sure we want it to happen "eventually".)

Dec 11 2024, 07:20 · Feature Requests, Config, Discussion Needed, Files

Dec 9 2024

avivey added a comment to T15972: Add config option for maximum file size.

Sounds reasonable.

Dec 9 2024, 08:12 · Feature Requests, Config, Discussion Needed, Files
avivey added a comment to T15965: Repository Identity "Automatically Detected User": it reads unverified emails, with spam concerns.

"Steal credit" might actually lead to a real issue: If a new user can get themselves identified as an old, trusted, user based on commit history, their changes might not be checked as rigorously by the rest of the team - similar to the XZ Utils backdoor issue, only faster.

Dec 9 2024, 07:56 · Spam mitigation, Diffusion, Security

Dec 8 2024

avivey accepted D25851: docs: Remove extra 'B' from PHP config value.
Dec 8 2024, 12:19

Dec 4 2024

valerio.bozzolan awarded T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses a Cup of Joe token.
Dec 4 2024, 08:06 · phorge.it install
avivey claimed T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses.

Please "remind" me about this ticket as often as possible, so I will fix it. I have everything I need to actually fix this, except the willpower.

Dec 4 2024, 08:05 · phorge.it install

Dec 3 2024

avivey changed the visibility for D25043: Upload compressed logo, update HTML.
Dec 3 2024, 16:22
avivey changed the visibility for D25041: Home Page.
Dec 3 2024, 16:21
avivey added a comment to D25839: Fix parsing of incoming mail with UTF-8 encoded headers.

@3tayesh Please don't do that again.

Dec 3 2024, 16:17
avivey changed the visibility for D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Dec 3 2024, 16:17

Dec 2 2024

avivey accepted D25843: Delete Repository button: disable if not admin, but show popup to all.

Since the button doesn't do anything in any case except say why it doesn't do anything, it might always be disabled? Do we have any other similar buttons?
I'm never sure if users discover that disabled buttons are actually clickable (and try to explain why they're disabled). It's a UI feature I really like, but I don't think I've seen it anywhere else.

Dec 2 2024, 21:24

Nov 26 2024

avivey awarded T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them a Burninate token.
Nov 26 2024, 13:08 · Bug Reports

Nov 24 2024

avivey accepted D25792: Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated" exception.

It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.

Nov 24 2024, 09:32

Nov 21 2024

avivey accepted D25837: Fix a typo in documentation.

Ah, the mythical Platypus Ornithopter!

Nov 21 2024, 07:16

Nov 2 2024

Rexogamer awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Nov 2 2024, 12:58 · Comments

Oct 30 2024

nemoralis awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Oct 30 2024, 07:21 · Comments

Oct 29 2024

avivey added Q158: Is there a way to create a task in Maniphest via a webhook? (Answer 198).
Oct 29 2024, 07:48

Oct 27 2024

avivey accepted D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 14:06
avivey added inline comments to D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 13:13
avivey accepted D25833: APC: Set ttl to 0 when ttl is not given.
Oct 27 2024, 13:13

Oct 24 2024

avivey accepted D25832: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 24 2024, 09:56
avivey accepted D25831: Fix implicitly nullable parameter declarations for PHP 8.4.
Oct 24 2024, 09:55

Oct 23 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

(The Arguments have a supports feature for these cases - like https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 . Not sure what it actually does, but 🤷🏻‍♂️)

Oct 23 2024, 07:22 · Arcanist

Oct 20 2024

avivey added Q156: How to support project commercialy? (Answer 196).
Oct 20 2024, 10:00
avivey added a comment to Q153: php-fpm memory leak.

If it's the daemons that are having problems, you can probably see in the /daemons/ dashboard which tasks are causing problems, and narrow it down from there.

Oct 20 2024, 09:05

Oct 18 2024

avivey added a comment to Q153: php-fpm memory leak.

Repository update is based on how recent the last commit is, but that's only for collecting the list of commits to analyze.
But that should be done in the Daemons, which should at least recover nicely and not break the web side of the application. I don't know if they should be running as php or php-fpm.

Oct 18 2024, 06:44

Oct 15 2024

avivey created Blog Post: 2024 Summer Edition.
Oct 15 2024, 16:48
avivey edited the content of Change Log.
Oct 15 2024, 16:42
avivey committed rPd3c0a7edc3fc: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:42
avivey committed rARC05abd055019c: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:37

Oct 10 2024

avivey awarded T15948: Allow public API access when equivalent public web access exists a Like token.
Oct 10 2024, 06:54 · Policy, Conduit, Phorge

Oct 9 2024

avivey added a comment to T15947: Add method to query if user is member of a list of projects.

Maybe express it as allowed by Policy xxx? (Related to T15277)

Oct 9 2024, 10:29 · Feature Requests

Sep 30 2024

avivey added a comment to Q154: Modifying Celerity postprocessors - is there a cache I should flush?.

it might be in the APCu cache (https://we.phorge.it/config/cache/) - I'll try to check later. Also make sure you've set the Developer Mode in settings.

Sep 30 2024, 06:34

Sep 28 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

Ok, so --branch probably doesn't make much sense in that case, right.

Sep 28 2024, 18:58 · Arcanist

Sep 26 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

Sep 26 2024, 13:59 · Arcanist

Sep 25 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

a. I'm not sure I like isBranchJustFilesystemPath() to check Is this SVN - if we're trying to be generic, then there may be a different vcs that does this particular trick, but has different logic; And if we're not trying to be generic, then isSVN() is probably a good-ish name? or isVCS('SVN').

Sep 25 2024, 14:01 · Arcanist

Sep 18 2024

avivey added Q152: Tips on setting up a Phorge instance to track its own live code? (Answer 189).
Sep 18 2024, 08:31

Sep 6 2024

dtf awarded Update From Phabricator a Mountain of Wealth token.
Sep 6 2024, 08:36

Sep 3 2024

avivey accepted D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Sep 3 2024, 07:57

Aug 28 2024

avivey edited the content of Change Log.
Aug 28 2024, 09:28
avivey renamed Next Up from Next Up to 2024.35.
Aug 28 2024, 09:27

Aug 24 2024

avivey added Q148: dockerized/terraform builds of phorge? (Answer 185).
Aug 24 2024, 09:43
avivey added a comment to T15566: Make is easier to install Phorge in the smallest case.

Also related: T15025

Aug 24 2024, 09:42 · Phorge
avivey added a project to T15027: Build a VM-based developer environment: Phorge Development Tools.
Aug 24 2024, 09:39 · Phorge Development Tools
avivey added a project to T15061: Create a docker development environment : Phorge Development Tools.
Aug 24 2024, 09:39 · Phorge Development Tools

Aug 8 2024

avivey moved T15908: More Useful "Quick Create" button on Workboard Columns from Backlog to Feature Requests on the Workboard board.
Aug 8 2024, 15:05 · Feature Requests, Workboard
avivey accepted D25617: docs/file_domain: remove cloudflare mention of autominify.
Aug 8 2024, 15:04
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

I've filed T15908 for the "quick create from column to do what I mean".

Aug 8 2024, 14:54
avivey created T15908: More Useful "Quick Create" button on Workboard Columns.
Aug 8 2024, 14:52 · Feature Requests, Workboard
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

(@arp - the images you pasted did not get Attached, so they are Private; Please set them manually to Public so they can be seen. We have an open ticket for that somewhere)

Aug 8 2024, 14:24

Aug 7 2024

avivey added a comment to D25766: Arcanist Text Linter: do not break the "ics" special format.

It's probably better to exclude ICS files from TXT in .arclint, or define their own section, rather then add hard-coded exceptions in here.

Aug 7 2024, 11:57
avivey added a member for Trusted Contributors: arp.
Aug 7 2024, 07:47
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

It's not "impossible" on the technical level, it's just not obviously the right solution.

Aug 7 2024, 07:46

Aug 6 2024

avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

...set it by default to the space that the project belongs to...

Aug 6 2024, 13:59
avivey updated the answer details for Q145: Auto-set user task access depending on the project visibility (Answer 180).
Aug 6 2024, 12:03