User Details
- User Since
- Jun 10 2021, 05:36 (203 w, 2 d)
- Roles
- Administrator
- Availability
- Available
- Timezone
- UTC+2
Today
To put it another way:
I think the described use-case is too narrow, and a naive expansion of the use-case isn't scalable.
The described use-case fails for at least one possible use-case ("some bots have something useful to say").
Yes, this is where my first comment enters - I feel this is a rabbit-hole we shouldn't venture into, etc.
The current script appears to have 3 names, and referring to "legacy data" implies that there won't be any new names to add.
the legacy data can be handled by the already-existing hard-coded names...
I feel this is a rabbit-hole we shouldn't venture into.
The slippery-slope argument will make us adding a custom class for each individual user, so css extensions can be used to hide/highlight comments from boss/intern/etc.
It's also probably not enough to remove the hard-coded requirement either - in some environments, one "bot" user is copying comments from another platform, and another is making statistical updates about a jira ticket, so you'd still need a better filter.
Yesterday
Thu, May 1
Re "implement in php" - AFAICT, there's no built-in support for websockets in php, but I found at least 2 pure-php implementations out there that might work.
Possible ways to reduce risk for future issues:
- add a Setup Check that runs npm audit
- remove node, use php-based websocket implementation
@aklapper want to land this?
I figure users need to just run npm audit fix to be safe, and then fix the mess it did on the git diff.
Wed, Apr 30
- Can we specify the .10 in packages.json itself?
- Do installs need upgrade instructions to complete the upgrade?
As a general rule, I prefer the have the abstractions as much as possible, to allow extensions to do things.
In this case, an abstraction would also make this feature easier to enable/disable, which I think is desired.
Sun, Apr 27
All these options make me want to just go with Sprites (See "Tokens" and "Authentication" in https://we.phorge.it/uiexample/view/PHUIIconExample/).
Wed, Apr 23
Tue, Apr 22
That's almost a year old. Time to update.
Thu, Apr 17
Fri, Apr 11
Tue, Apr 8
Mon, Apr 7
Sun, Apr 6
Sure, 7 years is probably long enough to migrate cookies.
Mar 31 2025
Looks good, yeah.
Mar 30 2025
So, this turns out to be a lot harder than I thought.
Mar 26 2025
There might be some security implications to this.
Why is this needed?
Mar 20 2025
I don't understand the problem described...
Mar 19 2025
I'm not familiar with MediaWiki's packages - the model I'm copying is VSCode.
My thought is that in the install manual we'll say "now run ./bin/extensions install phorge-recommended-extensions" (near the ./bin/storage) step, and phorge-recommended-extensions would be the equivalent of "extension pack" hosted on the default Extension Store, which is hosted here.
(VSCode also has "bundled extensions", which I think doesn't work for us because we use "clone the repo" as the primary distribution system).
On this server, we changed the config to /^(Q|V|M)\d$/ because we don't have P1 tickets.
I'm also not sure what M is short for.
To me, "obsolete" manes "no longer appliable" - basically, "the information in this page doesn't apply any more".
Some (made up) examples:
- "Can Phorge run on PHP 7.0?" (The answer is no, because of a specific bug in 7.0, which was EOL a long time ago)
- "I have this problem in the Chatbot app" (We've deleted the chatbot app)
The V123 syntax is disabled by remarkup.ignored-object-names config by default; The default is /^(Q|V|M|P)\d$/ (basically anything starting with Q, V, M, or P), for "Q1" (biz-talk for April), "V1" (for versions), "M1" (for ?????) and "P1" (Jira for "important bug").
Mar 17 2025
My thought on this is that long term, we'll remove the concept of "prototype" completely in favor of Extensions.
The "Prototype" concept was a way for Phacility to experiment with things without committing - but we have a different model today.
Mar 15 2025
Mar 7 2025
@Cigaryno please create a task under Discussion Needed for this - I'm not sure we want to make this policy change.
Mar 6 2025
Do we have a task to remove this file from source-control?
Mar 3 2025
Mar 2 2025
close enough for my taste; Just add . at the end of each sentence.
Feb 27 2025
- There's already a "description" field on these, which I think was supposed to be displayed; We might have lost it at some point, which is concerning.
- Use pht() for all human-visible text, to allow translation.
Need to go over the relevant code for deciding if a commit has an approved Revision - I think it looks mostly on the commit message.
Feb 26 2025
Feb 23 2025
See also https://secure.phabricator.com/T1751 and rARC3116d3656ad017783e75df7e863368053d753e7f - looks like we had arc backout at some point for this, but it's no longer there.
Feb 22 2025
try now
@valerio.bozzolan go ahead and give it a try? I think you have access to create rules.
Feb 15 2025
I've deployed it (https://www.phorge.it/)
Feb 14 2025
I'd like people to clone from GH less for the bandwidth and more for the availability - GH is more likely to be up then us.
Technically I guess GH might have an issue with that, but they probably won't notice anyway.
Feb 3 2025
https://secure.phabricator.com/T13105 is the relevant historical meta-task, I didn't find a matching one here.
Feb 2 2025
Jan 21 2025
Oh, I miss-understood the problem statement. The 4096 limit is on the size of the image that we can resize from...
Jan 20 2025
I'd expect it to just resize the image as needed....
Dec 29 2024
two items re: phrasing, but otherwise LGTM.
Dec 24 2024
Dec 23 2024
Dec 22 2024
I've set can create to Trusted Contributors for now. I don't see a problem with people being able to create documents.
Dec 20 2024
Dec 19 2024
If the goal is to make it denote "inserted text", I think it should be visually different to "underline" - something more similar to the green we use for actual diff views, maybe more subtle. Will need special handling in the color-blindness themes.
Dec 18 2024
The "Grant permission" button works for me on Chrome/Windows.
Dec 17 2024
I think that for the "the name I use is not my legal name" use-case, I'm pretty sure it's fine to use the name that is actually used (because that's what the person is normally known as). It's probably easier to justify accepting a name that is used in real life then "internet handle", but ㄟ( ▔, ▔ )ㄏ
Dec 15 2024
Dec 11 2024
(we can probably keep this ticket open, so that we have the 2nd part on the backlog. I'm pretty sure we want it to happen "eventually".)
Dec 9 2024
Sounds reasonable.
"Steal credit" might actually lead to a real issue: If a new user can get themselves identified as an old, trusted, user based on commit history, their changes might not be checked as rigorously by the rest of the team - similar to the XZ Utils backdoor issue, only faster.
Dec 8 2024
Dec 4 2024
Please "remind" me about this ticket as often as possible, so I will fix it. I have everything I need to actually fix this, except the willpower.
Dec 3 2024
@3tayesh Please don't do that again.
Dec 2 2024
Since the button doesn't do anything in any case except say why it doesn't do anything, it might always be disabled? Do we have any other similar buttons?
I'm never sure if users discover that disabled buttons are actually clickable (and try to explain why they're disabled). It's a UI feature I really like, but I don't think I've seen it anywhere else.
Nov 26 2024
Nov 24 2024
It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.
Nov 21 2024
Ah, the mythical Platypus Ornithopter!