Page MenuHomePhorge

avivey (Aviv Eyal)
UserAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 10 2021, 05:36 (179 w, 3 d)
Roles
Administrator
Availability
Available
Timezone
UTC+2

Recent Activity

Sat, Nov 2

Rexogamer awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Sat, Nov 2, 12:58 · Comments

Wed, Oct 30

nemoralis awarded T15048: Allow awarding Tokens to individual Comments a Love token.
Wed, Oct 30, 07:21 · Comments

Tue, Oct 29

avivey added Q158: Is there a way to create a task in Maniphest via a webhook? (Answer 198).
Tue, Oct 29, 07:48

Sun, Oct 27

avivey accepted D25833: APC: Set ttl to 0 when ttl is not given.
Sun, Oct 27, 14:06
avivey added inline comments to D25833: APC: Set ttl to 0 when ttl is not given.
Sun, Oct 27, 13:13
avivey accepted D25833: APC: Set ttl to 0 when ttl is not given.
Sun, Oct 27, 13:13

Thu, Oct 24

avivey accepted D25832: Fix implicitly nullable parameter declarations for PHP 8.4.
Thu, Oct 24, 09:56
avivey accepted D25831: Fix implicitly nullable parameter declarations for PHP 8.4.
Thu, Oct 24, 09:55

Wed, Oct 23

avivey added a comment to D25823: arc browse: add support to Subversion repos.

(The Arguments have a supports feature for these cases - like https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 . Not sure what it actually does, but 🤷🏻‍♂️)

Wed, Oct 23, 07:22

Sun, Oct 20

avivey added Q156: How to support project commercialy? (Answer 196).
Sun, Oct 20, 10:00
avivey added a comment to Q153: php-fpm memory leak.

If it's the daemons that are having problems, you can probably see in the /daemons/ dashboard which tasks are causing problems, and narrow it down from there.

Sun, Oct 20, 09:05

Oct 18 2024

avivey added a comment to Q153: php-fpm memory leak.

Repository update is based on how recent the last commit is, but that's only for collecting the list of commits to analyze.
But that should be done in the Daemons, which should at least recover nicely and not break the web side of the application. I don't know if they should be running as php or php-fpm.

Oct 18 2024, 06:44

Oct 15 2024

avivey created Blog Post: 2024 Summer Edition.
Oct 15 2024, 16:48
avivey edited the content of Change Log.
Oct 15 2024, 16:42
avivey committed rPd3c0a7edc3fc: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:42
avivey committed rARC05abd055019c: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:37

Oct 10 2024

avivey awarded T15948: Allow public API access when equivalent public web access exists a Like token.
Oct 10 2024, 06:54 · Conduit, Phorge

Oct 9 2024

avivey added a comment to T15947: Add method to query if user is member of a list of projects.

Maybe express it as allowed by Policy xxx? (Related to T15277)

Oct 9 2024, 10:29 · Feature Requests

Sep 30 2024

avivey added a comment to Q154: Modifying Celerity postprocessors - is there a cache I should flush?.

it might be in the APCu cache (https://we.phorge.it/config/cache/) - I'll try to check later. Also make sure you've set the Developer Mode in settings.

Sep 30 2024, 06:34

Sep 28 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

Ok, so --branch probably doesn't make much sense in that case, right.

Sep 28 2024, 18:58

Sep 26 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

Sep 26 2024, 13:59

Sep 25 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

a. I'm not sure I like isBranchJustFilesystemPath() to check Is this SVN - if we're trying to be generic, then there may be a different vcs that does this particular trick, but has different logic; And if we're not trying to be generic, then isSVN() is probably a good-ish name? or isVCS('SVN').

Sep 25 2024, 14:01

Sep 18 2024

avivey added Q152: Tips on setting up a Phorge instance to track its own live code? (Answer 189).
Sep 18 2024, 08:31

Sep 6 2024

dtf awarded Update From Phabricator a Mountain of Wealth token.
Sep 6 2024, 08:36

Sep 3 2024

avivey accepted D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Sep 3 2024, 07:57

Aug 28 2024

avivey edited the content of Change Log.
Aug 28 2024, 09:28
avivey renamed Next Up from Next Up to 2024.35.
Aug 28 2024, 09:27

Aug 24 2024

avivey added Q148: dockerized/terraform builds of phorge? (Answer 185).
Aug 24 2024, 09:43
avivey added a comment to T15566: Make is easier to install Phorge in the smallest case.

Also related: T15025

Aug 24 2024, 09:42 · Phorge
avivey added a project to T15027: Build a VM-based developer environment: Phorge Development Tools.
Aug 24 2024, 09:39 · Phorge Development Tools

Aug 8 2024

avivey moved T15908: More Useful "Quick Create" button on Workboard Columns from Backlog to Features on the Workboard board.
Aug 8 2024, 15:05 · Feature Requests, Workboard
avivey accepted D25617: docs/file_domain: remove cloudflare mention of autominify.
Aug 8 2024, 15:04
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

I've filed T15908 for the "quick create from column to do what I mean".

Aug 8 2024, 14:54
avivey created T15908: More Useful "Quick Create" button on Workboard Columns.
Aug 8 2024, 14:52 · Feature Requests, Workboard
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

(@arp - the images you pasted did not get Attached, so they are Private; Please set them manually to Public so they can be seen. We have an open ticket for that somewhere)

Aug 8 2024, 14:24

Aug 7 2024

avivey added a comment to D25766: Arcanist Text Linter: do not break the "ics" special format.

It's probably better to exclude ICS files from TXT in .arclint, or define their own section, rather then add hard-coded exceptions in here.

Aug 7 2024, 11:57
avivey added a member for Trusted Contributors: arp.
Aug 7 2024, 07:47
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

It's not "impossible" on the technical level, it's just not obviously the right solution.

Aug 7 2024, 07:46

Aug 6 2024

avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

...set it by default to the space that the project belongs to...

Aug 6 2024, 13:59
avivey updated the answer details for Q145: Auto-set user task access depending on the project visibility (Answer 180).
Aug 6 2024, 12:03
avivey added Q145: Auto-set user task access depending on the project visibility (Answer 180).
Aug 6 2024, 12:00
avivey added a comment to T15903: Logged exceptions/errors should ignore user's language setting and be always in English.

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time.

Aug 6 2024, 06:41 · Localization

Aug 5 2024

avivey added a comment to D25743: Fix stripping headers from proxy requests to other cluster nodes.

I did some digging:

Aug 5 2024, 04:02

Aug 4 2024

avivey raised the priority of T15401: Make the Remarkup Help Page Extensible from Wishlist to Low.
Aug 4 2024, 07:54 · Documentation, Remarkup
avivey added a comment to D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

This entire method looks very hacky to me. I guess at the bottom of every useful UI, there's a bunch of if statements that map icon names to code.

Aug 4 2024, 07:49

Aug 3 2024

avivey accepted D25763: Misc PHPDoc additions to PhabricatorFile.
Aug 3 2024, 06:11
avivey accepted D25743: Fix stripping headers from proxy requests to other cluster nodes.

BTW - is something normalizing the header casing?

Aug 3 2024, 06:07

Aug 2 2024

avivey added a comment to T15750: Integrate CustomField into more interfaces.

Is this feature meant to include displaying custom project fields in search results as well? (and possibly for other applications that allow custom field definitions)

Aug 2 2024, 07:12
avivey accepted D25737: Log Herald rules with invalid actions via phlog().

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

Aug 2 2024, 07:05
avivey updated the summary of D25737: Log Herald rules with invalid actions via phlog().
Aug 2 2024, 06:58

Jul 30 2024

CryingWolf awarded T15750: Integrate CustomField into more interfaces a Yellow Medal token.
Jul 30 2024, 14:53

Jul 29 2024

avivey added a comment to D25750: fix PHP8 array_slice($results, null) which cause diffusion locate file broken.

You didn't have Trusted Contributors membership, which provides access to the repo. Try now

Jul 29 2024, 06:27
avivey added a member for Trusted Contributors: gemini133.
Jul 29 2024, 06:26

Jul 15 2024

avivey accepted D25672: Allow collapsing/expanding workboard column content by clicking its header.

👍👍

Jul 15 2024, 09:06

Jul 11 2024

avivey removed a project from T15705: Lower the search ranking of disabled user accounts: Discussion Needed.

I think we're all aligned here...

Jul 11 2024, 07:35 · UX

Jul 10 2024

avivey added a comment to Q143: Upgrading from Phabricator (Answer 179).

The best way is probably to make an Extension:

Jul 10 2024, 14:01
avivey accepted D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Jul 10 2024, 13:53

Jul 9 2024

avivey added Q143: Upgrading from Phabricator (Answer 179).
Jul 9 2024, 14:44

Jul 8 2024

avivey added a comment to T15879: Documentation: Macro image rendered instead of keyword when names match.

these pages should have Macro disabled, probably. A user on the install can add more macros that would break the page in some other ways. Probably.

Jul 8 2024, 16:38
avivey accepted D25691: Fix arc diff in Subversion for non-English languages.
Jul 8 2024, 07:45

Jul 3 2024

avivey added a comment to T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.

Once we remove this, we'll need to handle this edge-case:

  • I've closed a ticket as "duplicate of T1", but I was wrong and want to mark it as "duplicate of T2" instead (and say it's not a dup of T1).
Jul 3 2024, 07:54 · Maniphest, Bug Reports

Jul 2 2024

avivey added Q141: LotusLinkManiphestCustomField.php:258, occurrences: 1 (Answer 175).
Jul 2 2024, 12:26

Jul 1 2024

avivey added a comment to D25709: Fix missing file attachment in Conpherence.

OK.

@avivey what do you think about a new silly commodity method PhabricatorTransactions::findOneByType(array, string) ?

Jul 1 2024, 18:39
avivey added a comment to D25607: Add docs for color code formatting.

(BTW, in D25698 we started deprecating remarkup.diviner for RemarkupReferenceController)

Jul 1 2024, 06:53

Jun 30 2024

avivey added a comment to D25706: Remove workaround for IE8 to avoid mixed content warning.

what will this do?

Jun 30 2024, 06:20

Jun 28 2024

avivey edited the content of Next Up.
Jun 28 2024, 08:10
avivey added a comment to Q140: Drag and drop: view policies.

I'm assuming you're talking about dropping a file in the text area when editing the page, right? Not just dropping it when viewing a wiki page?

Jun 28 2024, 08:04
avivey accepted rP90f9da643d16: Add and use new RemarkupMetadata class.

Presumably resolved by D25134.

Jun 28 2024, 08:00
avivey added Q140: Drag and drop: view policies (Answer 174).
Jun 28 2024, 08:00

Jun 27 2024

avivey added inline comments to D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.
Jun 27 2024, 10:39
avivey added a comment to D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.

maybe just add if ($value === null) { continue; } somewhere before the this?

Jun 27 2024, 10:36
avivey created T15869: Herald rule referring to a disabled rule silently fails.
Jun 27 2024, 10:26 · Herald
avivey added a comment to D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.

grep for PHUIDiffTableOfContentsItemView in the codebase to see where we might be using this class.

Jun 27 2024, 08:44
avivey added a comment to D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.

If we can't find the problem, that probably means we have some dead code here that should be removed.

Jun 27 2024, 08:40
avivey added a comment to D25658: Fix call to non-existing renderChangesetLink() in PHUIDiffTableOfContentsItemView.

Is there something that's not working here?

Jun 27 2024, 07:52
avivey accepted D25667: Redirect back to object after clicking "Log In to Comment" and login.
Jun 27 2024, 07:51
avivey accepted D25646: Correct rendering of workboard column move feed stories when a single transaction performs moves on multiple boards.

:shrug:

Jun 27 2024, 07:50
avivey reopened T15401: Make the Remarkup Help Page Extensible as "Open".

(re-opening, there's more work left here)

Jun 27 2024, 06:27 · Documentation, Remarkup

Jun 26 2024

avivey accepted D25698: Make the Remarkup Help Page Extensible.

bwahaha

Jun 26 2024, 18:51
avivey added inline comments to D25698: Make the Remarkup Help Page Extensible.
Jun 26 2024, 08:55
avivey added inline comments to D25698: Make the Remarkup Help Page Extensible.
Jun 26 2024, 07:56
avivey added a comment to T15285: It's damn difficult to type a "Thumb Up" emojii.

Do we still need the auto-complete feature? In modern times, the OS has the "insert emoji" feature built-in (at least, Windows and Android and KDE do).

Jun 26 2024, 07:54

Jun 24 2024

avivey added a comment to D25698: Make the Remarkup Help Page Extensible.

Ok, this looks much better then what we have today, so yay.

Jun 24 2024, 20:17
avivey added a comment to D25698: Make the Remarkup Help Page Extensible.

Looks good! I want to play with it locally before accepting.

Jun 24 2024, 08:41
avivey awarded D25698: Make the Remarkup Help Page Extensible a Yellow Medal token.
Jun 24 2024, 08:34

Jun 23 2024

avivey added a comment to D25698: Make the Remarkup Help Page Extensible.

It also collected lots of commits, since May 2023.

Jun 23 2024, 20:28
avivey accepted D25652: Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngine.
Jun 23 2024, 07:31
avivey added a comment to D25697: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.

I obviously failed to run ./bin/celerity map one more time before running arc diff.

There should really be some way to detect and prevent that mistake. It's one I've made probably 100 times before.

Jun 23 2024, 06:21

Jun 22 2024

avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Jun 22 2024, 15:44

Jun 21 2024

avivey updated the task description for T15750: Integrate CustomField into more interfaces.
Jun 21 2024, 19:09
avivey updated the task description for T15750: Integrate CustomField into more interfaces.
Jun 21 2024, 19:09
avivey edited the content of Next Up.
Jun 21 2024, 09:48
avivey closed D25549: Add Standard Custom Fields to Item List.
Jun 21 2024, 09:45
avivey committed rP587530a9bf7b: Add Standard Custom Fields to Item List.
Add Standard Custom Fields to Item List
Jun 21 2024, 09:45
avivey added inline comments to D25549: Add Standard Custom Fields to Item List.
Jun 21 2024, 09:39
avivey accepted D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy.
Jun 21 2024, 09:25
avivey accepted D25695: Add fallback languages for locale files.
Jun 21 2024, 09:23
avivey renamed Blog Post: 2024 "Not Officially Summer" release blog post from 2024 "Not officially summer" release to 2024 "Not Officially Summer" release.
Jun 21 2024, 09:11
avivey created Blog Post: 2024 "Not Officially Summer" release.
Jun 21 2024, 09:11
avivey edited the content of Change Log.
Jun 21 2024, 09:06