Page MenuHomePhorge

Handle security issues in Aphlict
Open, NormalPublic

Description

Follow-up to T16037 - known vulnerability in the ws module took us almost a year to notice and fix.
We should be doing better.

This is special to Aphlict, which is a very small piece of code written in Node, that most people never interact with.

Some options to prevent this from happening again:

  • Rewrite Aphlict in php
  • Have a dedicated Setup Check that will run in each install and just run npm audit
  • Add a "unit test" that will run npm audit (and will be triggered when?)
  • Have a periodic test check for this (and other things), on master every night/week/etc.
  • Have a manual search, every once in a while, for known vulnerabilities on any of our Dependencies.

Event Timeline

avivey triaged this task as Normal priority.

Re "implement in php" - AFAICT, there's no built-in support for websockets in php, but I found at least 2 pure-php implementations out there that might work.