Remove setup check for safe_mode removed in PHP 5.4
ClosedPublic
Actions

Authored by aklapper on Sat, Apr 5, 13:39.

Details

Reviewers

mainframe98
avivey

Group Reviewers

O1: Blessed Committers

Commits

rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4

Summary

Phorge requires PHP 7.2 so don't check for stuff removed in PHP 5.4.
See https://www.php.net/releases/5_4_0.php and https://web.archive.org/web/20190217003515/https://php.net/features.safe-mode

Test Plan

Set up Phorge, I'd guess.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Sat, Apr 5, 13:39

Owners added a reviewer: O1: Blessed Committers.Sat, Apr 5, 13:39

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Apr 5, 13:39

aklapper requested review of this revision.Sat, Apr 5, 13:39

Harbormaster completed remote builds in B1842: Diff 2834.Sat, Apr 5, 13:39

git rebase master

Harbormaster completed remote builds in B1846: Diff 2839.Sat, Apr 5, 14:05

Setup phorge, saw nothing unusual in the setup issues.

avivey accepted this revision.Mon, Apr 7, 06:08

This revision is now accepted and ready to land.Mon, Apr 7, 06:08

Closed by commit rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4. · Explain WhyMon, Apr 7, 20:12

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4.

aklapper mentioned this in Next Up.Mon, Apr 7, 20:13

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

config/

check/

PhabricatorPHPPreflightSetupCheck.php

19 lines

O1: Blessed Committers

Diff 2841

View Options

src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php

Remove setup check for safe_mode removed in PHP 5.4ClosedPublicActions