Page MenuHomePhorge

Remove use of deprecated E_STRICT PHP constant
Needs ReviewPublic

Authored by aklapper on Feb 17 2025, 11:49.
Tags
None
Referenced Files
F3290487: D25887.1742867067.diff
Mon, Mar 24, 01:44
F3280695: D25887.1742656504.diff
Fri, Mar 21, 15:15
F3246037: D25887.1742199897.diff
Sun, Mar 16, 08:24
F3225381: D25887.1742112686.diff
Sat, Mar 15, 08:11
F3225357: D25887.1742110002.diff
Sat, Mar 15, 07:26
F3221356: D25887.1741830854.diff
Wed, Mar 12, 01:54
F3214493: D25887.1741557972.diff
Sat, Mar 8, 22:06
F3213377: D25887.1741552510.diff
Sat, Mar 8, 20:35

Details

Summary

The E_STRICT PHP constant is deprecated since PHP 8.4 per https://www.php.net/manual/en/migration84.deprecated.php.
Per https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant, the E_STRICT constant was still in use in-between PHP 7.0 and 7.4 for PHP's mysqli extension and PHP's htmlentities() function. Since rP23a49eb403c9ea6c58f4ae2f22416e90a9d24c14, Phorge requires 7.2.25. Phorge neither uses PHP's mysqli extension nor calls PHP's htmlentities() function.
Thus remove its usage, as E_STRICT is a part of E_ALL since PHP 5.4.0 per https://github.com/php/php-src/blob/php-5.4.0/NEWS#L69.

Closes T15989

Test Plan

None.

Diff Detail

Repository
rP Phorge
Branch
T15989 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1725
Build 1725: arc lint + arc unit