Page MenuHomePhorge

Remove use of deprecated E_STRICT PHP constant
Needs ReviewPublic

Authored by aklapper on Mon, Feb 17, 11:49.
Tags
None
Referenced Files
F2992134: D25887.1740201514.diff
Fri, Feb 21, 05:18
F2990727: D25887.1740181465.diff
Thu, Feb 20, 23:44
F2988196: D25887.1740130461.diff
Thu, Feb 20, 09:34
F2988166: D25887.1740123800.diff
Thu, Feb 20, 07:43
F2987703: D25887.1740117214.diff
Thu, Feb 20, 05:53
F2986176: D25887.1740095013.diff
Wed, Feb 19, 23:43
F2982825: D25887.1739971940.diff
Tue, Feb 18, 13:32
F2982777: D25887.1739971821.diff
Tue, Feb 18, 13:30

Details

Summary

The E_STRICT PHP constant is deprecated since PHP 8.4 per https://www.php.net/manual/en/migration84.deprecated.php.
Per https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant, the E_STRICT constant was still in use in-between PHP 7.0 and 7.4 for PHP's mysqli extension and PHP's htmlentities() function. Since rP23a49eb403c9ea6c58f4ae2f22416e90a9d24c14, Phorge requires 7.2.25. Phorge neither uses PHP's mysqli extension nor calls PHP's htmlentities() function.
Thus remove its usage, as E_STRICT is a part of E_ALL since PHP 5.4.0 per https://github.com/php/php-src/blob/php-5.4.0/NEWS#L69.

Closes T15989

Test Plan

None.

Diff Detail

Repository
rP Phorge
Branch
T15989 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1725
Build 1725: arc lint + arc unit