PHPDoc: Make some parameter types match type in signatures
ClosedPublic
Actions

Authored by aklapper on Sun, Mar 30, 21:06.

Tags

None

Referenced Files

	F3552918: D25937.1744911925.diff
	Wed, Apr 16, 17:45

	F3552661: D25937.1744904803.diff
	Wed, Apr 16, 15:46

	F3552076: D25937.1744903386.diff
	Wed, Apr 16, 15:23

	F3551918: D25937.1744902890.diff
	Wed, Apr 16, 15:14

	F3551840: D25937.1744902680.diff
	Wed, Apr 16, 15:11

	F3550911: D25937.1744901331.diff
	Wed, Apr 16, 14:48

	F3485523: D25937.1744776015.diff
	Tue, Apr 15, 04:00

	F3415903: D25937.1744610409.diff
	Sun, Apr 13, 06:00

Subscribers

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Commits

rP75d8c84c1372: PHPDoc: Make some parameter types match type in signatures

Summary

For explicitly mentioned Phorge class types in the function signature, use the same type in the PHPDoc for the parameter.

Test Plan

Compare classname type in function signature and in PHPDoc; run static code analysis.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Sun, Mar 30, 21:06

Owners added a reviewer: O1: Blessed Committers.Sun, Mar 30, 21:06

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Mar 30, 21:06

aklapper requested review of this revision.Sun, Mar 30, 21:06

Harbormaster completed remote builds in B1830: Diff 2814.Sun, Mar 30, 21:06

avivey accepted this revision.Tue, Apr 8, 06:16

This revision is now accepted and ready to land.Tue, Apr 8, 06:16

Closed by commit rP75d8c84c1372: PHPDoc: Make some parameter types match type in signatures. · Explain WhyTue, Apr 8, 09:00

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP75d8c84c1372: PHPDoc: Make some parameter types match type in signatures.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

harbormaster/

engine/

HarbormasterBuildEngine.php

2 lines

O1: Blessed Committers

infrastructure/

customfield/

field/

PhabricatorCustomField.php

3 lines

O1: Blessed Committers

markup/

PhabricatorMarkupInterface.php

2 lines

O1: Blessed Committers

Diff 2846

View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

View Options

src/infrastructure/markup/PhabricatorMarkupInterface.php

PHPDoc: Make some parameter types match type in signaturesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2846

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

src/infrastructure/customfield/field/PhabricatorCustomField.php

src/infrastructure/markup/PhabricatorMarkupInterface.php

PHPDoc: Make some parameter types match type in signatures
ClosedPublic
Actions

Revision Contents
Changeset List