Paths

Table of Contentst

-
src/applications/auth/engine/
-
applications/
-
auth/
-
engine/
-
PhabricatorAuthSessionEngine.php

Differential D25949

Complete session digest migration from SHA1 to SHA256
ClosedPublic
Actions

Authored by aklapper on Sat, Apr 5, 14:00.

Tags

None

Referenced Files

	F3374523: D25949.1744291382.diff
	Wed, Apr 9, 13:23

	F3374329: D25949.1744288180.diff
	Wed, Apr 9, 12:29

	F3364270: D25949.1744149400.diff
	Mon, Apr 7, 21:56

	F3362641: D25949.1744089853.diff
	Mon, Apr 7, 05:24

	F3361544: D25949.1744037776.diff
	Sun, Apr 6, 14:56

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256

Commits

rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256

Summary

Followup to 1d34238dc94555466e15039ff6991b371ae294ef.
Crossing fingers that nobody complains about a one-time logout after their six year long user session.

Closes T16025

Test Plan

Log in, log out, do stuff.
More specifically, with my session expired, successfully logging in created a database row added to phabricator_user.phabricator_session as expected, and logout removed the row.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Sat, Apr 5, 14:00

Owners added a reviewer: O1: Blessed Committers.Sat, Apr 5, 14:00

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Apr 5, 14:00

aklapper requested review of this revision.Sat, Apr 5, 14:00

Harbormaster completed remote builds in B1844: Diff 2836.Sat, Apr 5, 14:00

Sure, 7 years is probably long enough to migrate cookies.

This revision is now accepted and ready to land.Sun, Apr 6, 06:53

aklapper edited the test plan for this revision. (Show Details)Mon, Apr 7, 20:43

Closed by commit rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256. · Explain WhyMon, Apr 7, 21:46

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

engine/

PhabricatorAuthSessionEngine.php

25 lines

O1: Blessed Committers

Diff 2843

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...