Mark Phorge.it Home as non-launchable
ClosedPublic
Actions

Authored by Cigaryno on Sun, Mar 30, 10:02.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

(Owns No Changed Paths)

Commits

R10:4fac8b0aa67c: Mark Phorge.it Home as non-launchable

Summary

Phorge.it Home is an app meant to be installed at www.phorge.it, so it should be marked as non-launchable.
Bonus: Fix arc unit by loading src/ on .arcconfig (knowing there is nothing to unit).

Test Plan

Go to https://we.phorge.it/applications/query/advanced/
Set Launchable dropdown to Show Launchable Applications
Ensure Phorge.it Home does not show up in the query results

Diff Detail

Repository

R10 PhorgeIt Extension

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Cigaryno created this revision.Sun, Mar 30, 10:02

Herald added subscribers: Matthew, tobiaswiese. · View Herald TranscriptSun, Mar 30, 10:02

Cigaryno requested review of this revision.Sun, Mar 30, 10:02

Harbormaster completed remote builds in B1828: Diff 2812.Sun, Mar 30, 10:02

I don't know why, but O1 has to be manually added as a reviewer as it does not own R10.

@Cigaryno: Thanks! Could you elaborate why the change in .arcconfig is needed?

aklapper edited the test plan for this revision. (Show Details)Sun, Mar 30, 19:54

In D25936#25132, @aklapper wrote:

@Cigaryno: Thanks! Could you elaborate why the change in .arcconfig is needed?

So that users won't have to use the --nounit option. Because there are no unit tests, the unit tests path hasn't been taken care of properly and as a result, I get a non-loaded library exception with arc diff that can be fixed by making the changes to .arcconfig this revision has.