Page MenuHomePhorge
Feed All Stories

Sep 5 2024

valerio.bozzolan added a comment to T15848: newOAuth1Future doesn't set a User-Agent.

I would like to better understand the root problem. I see that Cloudflare was showing a captcha to Phorge (what Phorge?). It seems it was because an user agent was missing. But aklapper said that we are already setting an user agent.

Sep 5 2024, 19:24 · Auth
valerio.bozzolan accepted D25801: Fix PHP 8.1 "preg_match(null)" exception in XHPASTNode.

sgtm

Sep 5 2024, 19:17
valerio.bozzolan added a comment to T15749: Display warning about commenting on a task which is closed as a duplicate.

I just discovered that sometime we can spawn warnings above the comment box.

Sep 5 2024, 19:16 · Feature Requests
Wikivu accepted rP7157dd96b34a: T15006: Update .arcconfig to point to we.phorge.it.
Sep 5 2024, 19:12
Wikivu added a comment to rP7157dd96b34a: T15006: Update .arcconfig to point to we.phorge.it.

güncelleme

Sep 5 2024, 19:12
valerio.bozzolan added a comment to D25818: PHPDoc: Replace "@return this" with "@return $this".

(In general thanks and please do whatever needed change in PHPDoc but let's reduce the commits on single files for different PHPDoc changes; so if you have lot of warnings on a single file, just do them all thanksl

Sep 5 2024, 15:37
aklapper requested review of D25818: PHPDoc: Replace "@return this" with "@return $this".
Sep 5 2024, 15:21
valerio.bozzolan accepted D25789: Remove unused *ParallelQueries() database connection methods.
Sep 5 2024, 13:19
valerio.bozzolan added a comment to D25789: Remove unused *ParallelQueries() database connection methods.

This sounds like something that folks at Facebook were overriding / patching. But, the class is final so it's difficult to believe that really somebody is using this.

Sep 5 2024, 13:19
valerio.bozzolan updated the summary of D25789: Remove unused *ParallelQueries() database connection methods.
Sep 5 2024, 13:13
aklapper closed D25805: Correct PHPDoc @return value of methods that can return null.
Sep 5 2024, 12:55
aklapper committed rARCc01198d55f6d: Correct PHPDoc @return value of methods that can return null.
Correct PHPDoc @return value of methods that can return null
Sep 5 2024, 12:55
valerio.bozzolan accepted D25805: Correct PHPDoc @return value of methods that can return null.

yesyes

Sep 5 2024, 12:10
aklapper updated the diff for D25805: Correct PHPDoc @return value of methods that can return null.

Leave out special case src/workflow/ArcanistWorkflow.php for now

Sep 5 2024, 11:11
aklapper closed T15912: PHP 8.1 "strlen(null)" exceptions creating OAuth provider as Resolved by committing rPb4bc480817cd: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.
Sep 5 2024, 10:28 · PHP 8 support
aklapper closed T15912: PHP 8.1 "strlen(null)" exceptions creating OAuth provider, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sep 5 2024, 10:28 · PHP 8 support
aklapper closed D25771: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.
Sep 5 2024, 10:28
aklapper committed rPb4bc480817cd: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.
Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider
Sep 5 2024, 10:28
valerio.bozzolan accepted D25771: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.

sgtm

Sep 5 2024, 09:20
valerio.bozzolan added Q149: [BUG] Conduit API call error: Call to phutil_nonempty_string() expected null or a string, got: float. (Answer 186).
Sep 5 2024, 08:31
tiantiandas changed the visibility for F2482777: image.png.
Sep 5 2024, 06:29
tiantiandas asked Q149: [BUG] Conduit API call error: Call to phutil_nonempty_string() expected null or a string, got: float..
Sep 5 2024, 06:29 · Bug Reports, Phorge

Sep 4 2024

aklapper updated the task description for T15940: Update copy of external mimemailparser library.
Sep 4 2024, 20:07
aklapper updated the task description for T15940: Update copy of external mimemailparser library.
Sep 4 2024, 20:07
aklapper added a comment to T15766: Cleanup a bit MimeMailParser.

I'd prefer not to increase the diff to upstream (as a side effect of this very task) but instead to pull a more recent upstream version - see T15940.

Sep 4 2024, 19:58 · Mail, Good Starter Task
aklapper created T15940: Update copy of external mimemailparser library.
Sep 4 2024, 19:57
valerio.bozzolan added a parent task for T15564: Allow yourself to be Invited in Imported Events: T15939: Calendar Import Invitees 2.0.
Sep 4 2024, 17:59 · User-valerio.bozzolan, Calendar
valerio.bozzolan added a parent task for T15803: Calendar Import: add field "Default Invitees": T15939: Calendar Import Invitees 2.0.
Sep 4 2024, 17:59 · User-valerio.bozzolan, Calendar
valerio.bozzolan added subtasks for T15939: Calendar Import Invitees 2.0: T15938: Understand if Diffusion public identities could be used to expand Calendar invitees, T15803: Calendar Import: add field "Default Invitees", T15564: Allow yourself to be Invited in Imported Events.
Sep 4 2024, 17:59 · Calendar
valerio.bozzolan added a parent task for T15938: Understand if Diffusion public identities could be used to expand Calendar invitees: T15939: Calendar Import Invitees 2.0.
Sep 4 2024, 17:59 · Discussion Needed, Calendar
valerio.bozzolan created T15939: Calendar Import Invitees 2.0.
Sep 4 2024, 17:59 · Calendar
valerio.bozzolan updated the task description for T15938: Understand if Diffusion public identities could be used to expand Calendar invitees.
Sep 4 2024, 17:57 · Discussion Needed, Calendar
valerio.bozzolan created T15938: Understand if Diffusion public identities could be used to expand Calendar invitees.
Sep 4 2024, 17:56 · Discussion Needed, Calendar
THYDUX edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: Cigaryno; added 1: THYDUX.
Sep 4 2024, 16:20
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

fix typos in documentation

Sep 4 2024, 14:54 · Projects
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

add a bit of documentation - just because we can

Sep 4 2024, 14:40 · Projects
THYDUX awarded rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator. a Manufacturing Defect? token.
Sep 4 2024, 10:19
aklapper edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: THYDUX; added 1: Cigaryno.
Sep 4 2024, 10:19
THYDUX edited 2 auditor(s) for rP1ddb953b9f77: Update Diviner documentation to reference Phorge instead of Phabricator., removed 1: Cigaryno; added 1: THYDUX.
Sep 4 2024, 10:17
aklapper closed D25802: Remove trivial cases of unreachable code.
Sep 4 2024, 10:17
aklapper committed rP43539b220ce2: Remove trivial cases of unreachable code.
Remove trivial cases of unreachable code
Sep 4 2024, 10:17
aklapper closed D25803: Remove trivial cases of unreachable code.
Sep 4 2024, 10:16
aklapper committed rARCb888963f6ff5: Remove trivial cases of unreachable code.
Remove trivial cases of unreachable code
Sep 4 2024, 10:16
aklapper closed D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Sep 4 2024, 10:14
aklapper committed rP8c3a62d6afd0: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
Sep 4 2024, 10:14
aklapper closed D25804: Correct parameter name of PhpunitTestEngine::parseTestResults().
Sep 4 2024, 09:46
aklapper committed rARC201fc1d981a9: Correct parameter name of PhpunitTestEngine::parseTestResults().
Correct parameter name of PhpunitTestEngine::parseTestResults()
Sep 4 2024, 09:46
aklapper closed D25782: Remove unused PhutilConsoleProgressSink::getWidth().
Sep 4 2024, 09:46
aklapper committed rARC9f9413edd226: Remove unused PhutilConsoleProgressSink::getWidth().
Remove unused PhutilConsoleProgressSink::getWidth()
Sep 4 2024, 09:46
valerio.bozzolan accepted D25782: Remove unused PhutilConsoleProgressSink::getWidth().
Sep 4 2024, 09:37
valerio.bozzolan accepted D25804: Correct parameter name of PhpunitTestEngine::parseTestResults().

yesyes

Sep 4 2024, 09:33
valerio.bozzolan accepted D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.

sgtm

Sep 4 2024, 09:33
aklapper requested review of D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Sep 4 2024, 08:13
aklapper added a revision to T15936: PHP8.1 strlen(): Passing null to parameter is deprecated: D25817: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text.
Sep 4 2024, 08:13 · PHP 8 support
aklapper added a comment to T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.

Right, should have probably also covered that line in D25186 which is more or less the same...

Sep 4 2024, 08:02 · PHP 8 support
aklapper added a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.
Sep 4 2024, 08:01 · PHP 8 support
aklapper added a parent task for T15936: PHP8.1 strlen(): Passing null to parameter is deprecated: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.
Sep 4 2024, 08:01 · PHP 8 support
aklapper merged T15937: Exception when viewing diff while not logged in into T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
Sep 4 2024, 07:51 · Bug Reports, Differential
aklapper merged task T15937: Exception when viewing diff while not logged in into T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
Sep 4 2024, 07:51 · Phorge
speck added a comment to D25535: T15011: Update support for XHPast on Windows.

Maybe this is wild, but: should we consider removing the compiled xhpast.exe file from the repository, and host is externally?

Sep 4 2024, 02:07
speck updated the task description for T15937: Exception when viewing diff while not logged in.
Sep 4 2024, 02:04 · Phorge
speck created T15937: Exception when viewing diff while not logged in.
Sep 4 2024, 02:03 · Phorge

Sep 3 2024

speck accepted D25673: Fix error in Mercurial when no offset is specified.

Ty. I’m still confused how “limit” is required but doesn’t throw an error when not specified. Can address that later if needed.

Sep 3 2024, 21:53
Universal-Omega updated the task description for T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.
Sep 3 2024, 20:28 · PHP 8 support
Universal-Omega created T15936: PHP8.1 strlen(): Passing null to parameter is deprecated.
Sep 3 2024, 20:27 · PHP 8 support
RhinosF1 added a member for Trusted Contributors: Universal-Omega.
Sep 3 2024, 20:24
THYDUX awarded Welcome to the Phorge Wiki a Yellow Medal token.
Sep 3 2024, 18:30 · Phorge
valerio.bozzolan renamed Next Up from 2024.35 to Next Up.
Sep 3 2024, 15:12
valerio.bozzolan edited the content of Next Up.
Sep 3 2024, 15:12
valerio.bozzolan edited the content of Next Up.
Sep 3 2024, 14:50
valerio.bozzolan renamed Welcome to the Phorge Wiki from Welcome to Welcome to the Phorge Wiki.
Sep 3 2024, 10:25 · Phorge
aklapper closed D25800: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.
Sep 3 2024, 10:08
aklapper committed rARCf9749273778b: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.
Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
Sep 3 2024, 10:08
avivey accepted D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Sep 3 2024, 07:57
valerio.bozzolan added inline comments to D25805: Correct PHPDoc @return value of methods that can return null.
Sep 3 2024, 05:26
valerio.bozzolan accepted D25800: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.

sgtm

Sep 3 2024, 05:13
valerio.bozzolan added a comment to D25810: Fix PHP 8.1 "strlen(null)" exception in HTTPFutureHTTPResponseStatus.

Thanks. Premising that $body can be null and that's a feature

Sep 3 2024, 05:12

Sep 2 2024

Sten accepted D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.

Not before time!

Sep 2 2024, 10:56
valerio.bozzolan added a comment to D25731: Set default menu item to Project Details when archiving a project.

I don't favor implementing non-obvious behavior ("why does it sometimes do this but not always"). :)

Sep 2 2024, 08:55
aklapper added a comment to D25731: Set default menu item to Project Details when archiving a project.

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Sep 2 2024, 08:37
aklapper closed D25783: Remove unused ArcanistGitLocalState::getDisplayStashRef().
Sep 2 2024, 06:55
aklapper committed rARC995072b31fff: Remove unused ArcanistGitLocalState::getDisplayStashRef().
Remove unused ArcanistGitLocalState::getDisplayStashRef()
Sep 2 2024, 06:55

Sep 1 2024

valerio.bozzolan added a comment to D25731: Set default menu item to Project Details when archiving a project.

An additional check to make milestone owners happy might be: look to see if the board shows at least one task. If not, proceed.

Sep 1 2024, 22:12
valerio.bozzolan resigned from D25731: Set default menu item to Project Details when archiving a project.

Since you helped a lot in D25774 - I'm not sure this is needed anymore. Maybe better to get better opinions. For example I found this a bit irritating for my archived Milestones.

Sep 1 2024, 22:10
valerio.bozzolan added a comment to D25673: Fix error in Mercurial when no offset is specified.

Thanks aklapper. Seems good from our side @speck?

Sep 1 2024, 22:07
valerio.bozzolan accepted D25783: Remove unused ArcanistGitLocalState::getDisplayStashRef().

yesyes

Sep 1 2024, 21:20
valerio.bozzolan edited the content of 2024 week 35.
Sep 1 2024, 07:40

Aug 31 2024

aklapper updated the summary of D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 31 2024, 12:44
aklapper requested review of D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 31 2024, 12:43
aklapper added a revision to T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: D25816: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 31 2024, 12:43 · PHP 8 support
Iniquity awarded T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards. a Love token.
Aug 31 2024, 09:48 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard
Iniquity added a comment to T15801: Mention on landing page that Phorge is a community fork of Phabricator.

It seems to me that in general more information should be added to the main page: screenshots, main features, as is usually done in other large projects.

Aug 31 2024, 09:37 · Phorge
aklapper added a revision to T15047: Officially raise minimum required PHP version to 7.2: D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Aug 31 2024, 08:21 · Phorge
aklapper requested review of D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Aug 31 2024, 08:21
aklapper added a comment to T15047: Officially raise minimum required PHP version to 7.2.

Supporting PHP 8.4 (currently planned for 2024-11-21) will require PHP syntax introduced in PHP 7.1 per T15935.

Aug 31 2024, 08:20 · Phorge
aklapper added a parent task for T15047: Officially raise minimum required PHP version to 7.2: T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated.
Aug 31 2024, 07:48 · Phorge
aklapper added a subtask for T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated: T15047: Officially raise minimum required PHP version to 7.2.
Aug 31 2024, 07:48 · PHP 8 support

Aug 30 2024

aklapper updated the task description for T15935: PHP 8.4 fatal error / exceptions: Implicitly nullable parameter declarations deprecated.
Aug 30 2024, 15:19 · PHP 8 support
aklapper updated the summary of D25813: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:57
valerio.bozzolan updated the summary of D25814: Fix implicitly nullable parameter declarations for PHP 8.4.
Aug 30 2024, 14:57