In D25500#15024, @aklapper wrote:

and thus remove the only newly added call which returned null in src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php)

In D25500#15027, @aklapper wrote:

Maybe we can return ClassName::class - that is supported since PHP 5.5

there's a lot more code to update in random *Query.php classes defining getQueryApplicationClass() functions, in a separate future patch

What issues did you run into when using ./bin/mail send-test?

It makes sense thanks. Minor note:

Right. Sorry, my previous comment was very misleading!

In what case, a class can be installed "for the viewer", but generally uninstalled?

double-accept

Sorry for the confusion. I mean that the /mail/ page is the Mail Dashboard that allows to see both Inbox and Outbox (visible from the left sidebar menu). For example this is the exact Outbox sub-page:

Maybe we can return ClassName::class - that is supported since PHP 5.5

Note to myself: Makes sense; there's a lot more code to update in random *Query.php classes defining getQueryApplicationClass() functions, in a separate future patch

Revert turning getQueryApplicationClass() abstract in the parent class src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php and make it return null again (and thus remove the only newly added call which returned null in src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php); also return ::class as proposed by Valerio

Fix D25501#14443: Do not show an "Query overheated" error when the user is anonymous and the application has been uninstalled

Once I get back to working with that instance, I suppose I'll go to my inbox -- where (you seem to be implying) it will show me errors from when the system sent me the initial authentication email? That seems like an odd location, but ok.

Indeed :)

That sends me to my inbox here -- do you mean, on my own instance?

Nice trick for you: to register a new identity try adding +something after your email username. Example: smith+test1@example.com. That is a secret feature of mailboxes.

Have you already seen this page? maybe useful?

In D25501#14458, @20after4 wrote:

Are there any feed transactions that are visible to logged out users?

Also, the authorization process is rate-limited to 3 emails per hour, preventing me from using that to send an additional test email that way

Play it safe by using phutil_nonempty_scalar() and do not assume that integers are actually integers (because "1" and such)

• Update Map

• Increase line height

Updates map

In D25521#14952, @speck wrote:

Thanks!

(By the way the Filesystem::readFile() does not return a pointer to a (potentially read-only) resource, but it just returns its content - so the concern was nonsense)

In D25515#14983, @aklapper wrote:

In D25515#14842, @valerio.bozzolan wrote:

I wonder if it then, upon deletion of the profile image, it attempts to delete the builtin image

@valerio.bozzolan How is attempting to delete a built-in (!) profile image related to this patch? If I misunderstood, please elaborate. Thanks!

In D25515#14957, @avivey wrote:

I was able to trigger the "missing gd" warning (By uninstalling php*gd), so we're good there.
A bit puzzled about how you got the error if you already have it installed?

In D25515#14842, @valerio.bozzolan wrote:

I wonder if it then, upon deletion of the profile image, it attempts to delete the builtin image

Nice. Maybe a start-extension Arcanist workflow is a bit overkill, but a boilerplate extension would be lovely

Thanks again. Since this is a WIP, let's mark as such.

In an ideal world 1030-1313 could become just:

I've read your awesome travel in T15659 but I've also read this inline comment:

It's nice and it works. So... thanks!

@aklapper @valerio.bozzolan I think the styles for remarkup should stay seperated. We shouldn't blur modular css definitions just to safe some lines or multiple declarations.

• Seperates styles

## Contents

- is Phorge good for my Organization?
- differences between Phorge and GitLab, GitHub, Launchpad, Mantis, ...
- what's new in Phorge (that is not in Phabricator)
- practical workflows and pitfalls
- how to join the Phorge community
- how to propose code patches

Uh, right. So maybe we can:

Also remove unused $result array

I propose to remove that unused $result array. It's been unused before and looks we were not aware of any issues created by that fact.

Original change which triggered this: rP324470e39b0d4539a7487c2144157d686f5d0906

I cannot test it now, can you check who was setting that margin? Maybe we can try to avoid that !important

I was able to trigger the "missing gd" warning (By uninstalling php*gd), so we're good there.
A bit puzzled about how you got the error if you already have it installed?

@aklapper This task created a small regression. It is really so small I don‘t think it needs a task. Maybe you can accept my revision D25522.

User content is also content, thus yes.

Good question. Maybe also related to L2.

I'm still puzzled by the unused $result variable in line 46.

Is it assumed that using the site will automatically license the user’s content under these, or should there be a line for that?

In T15322#15031, @aklapper wrote:

+1 on Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses.

Thanks!

In T15645#15201, @speck wrote:

@bekay while in this area of code would you have any pointers on these other issues I’d like to fix at some point?

1. File browse widget doesn’t work unless logged in, for publicly accessible repos
2. The search results pop up width is often too narrow to show the full results path, and truncates the end of the path instead of beginning.

Values given in em units may produce unexpected results...

Adds return value to annotation and fixes wrong path when locating file from within a directory.

Tested locally and works in most cases, however would love to avoid creating broken (404) URIs due to T15579 before merging

Note that at least for Phame, http://phorge.localhost/J1 seems to always redirect to http://phorge.localhost/phame/post/view/1/blogpost/ instead of keeping the monogram in the URI.
So the baseURI is already wrong (not being http://phorge.localhost/ only) before concatenating the $ref (monogram and anchor).
As an ugly workardound, could probably make "Quote Comment" work by calling getObjectNamePrefix() in PhamePostRemarkupRule and LegalpadDocumentRemarkupRule and then use them in a preg_match to remove the monogram from the $ref but function is protected and... still ugly.

@bekay while in this area of code would you have any pointers on these other issues I’d like to fix at some point?

1. File browse widget doesn’t work unless logged in, for publicly accessible repos
2. The search results pop up width is often too narrow to show the full results path, and truncates the end of the path instead of beginning.

Looks good! Thank you so much for this!

In D25505#14533, @avivey wrote:

How about other functions that might require a logged-in user? "current Viewer's Projects" for example?

Yes. I think we should wait for a kind Administrator to implement the first one.

@speck @valerio.bozzolan My revision is ready to be tested 😄