Page MenuHomePhorge
Create Task
Maniphest T15326

PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring()
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. PHP 8.1.8 without GD installed
  2. Create a project
  3. Go to http://phorge.localhost/project/manage/1/
  4. Select Edit Picture in the sidebar on the right to go to the Edit Project Picture at http://phorge.localhost/project/picture/1/
  5. On Custom: Choose Icon and Color..., Choose Background Color and Choose Icon, then click the Save Image button.

Actual outcome:

[2023-05-01 22:25:09] EXCEPTION: (Error) Call to undefined function imagecreatefromstring() at [<phorge>/src/applications/files/builtin/PhabricatorFilesComposeIconBuiltinFile.php:131]
arcanist(head=T15263, ref.master=82d1abd4edd1, ref.T15263=4324d11c8b49), phorge(head=master, ref.master=8f669ea08289)
  #0 phlog(Error) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
  #1 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, Error) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
  #2 AphrontApplicationConfiguration::handleThrowable(Error) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
  #3 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
  #4 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]

Expected outcome:
Either a friendlier error message explaining what to do.
Or no error message at all.

Other comments:
Since PHP 8.0.0, PHP's imagecreatefromstring() "returns a GDImage instance on success; previously, a resource was returned."
Thus there is a currently undocumented requirement to have the PHP GD extension installed: https://www.php.net/manual/en/image.installation.php

I can confirm that installing php-gd-8.1.18 fixes the problem.

Revisions and Commits

rP Phorge
D25515rP7a86040f8a46 Avoid exception setting project profile image when GD not installed

Related Objects

Event Timeline

aklapper created this task.May 1 2023, 22:35
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptMay 1 2023, 22:35
aklapper renamed this task from PHP 8.0 without GD installed: Unhandled Exception setting a project profile image to PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().May 1 2023, 22:35
aklapper added a comment.May 2 2023, 14:22

Pseudo code, not tested as other exceptions block me from testing:

diff --git a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
index 02c1134dc3..adb8cafd8d 100644
--- a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
+++ b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
@@ -146,5 +146,22 @@ final class PhabricatorPHPPreflightSetupCheck extends PhabricatorSetupCheck {
         ->setMessage($message);
     }
 
+    if (version_compare($version, 8, '>=') && !extension_loaded('gd')) {
+      $message = pht(
+        "The PHP GD extension is not installed. GD is required for processing ".
+        "image files, such as user profile or project profile pictures.".
+        "\n\n".
+        "Please install the PHP GD extension.");
+
+      $this->newIssue('php.gd')
+        ->setIsFatal(true)
+        ->setName(pht('PHP GD Extension Not Installed'))
+        ->setMessage($message)
+        ->addLink(
+          'https://www.php.net/manual/image.installation.php',
+          pht('Install GD Support in PHP'));
+      return;
+    }
+
   }
 }
valerio.bozzolan subscribed.May 3 2023, 13:05
aklapper added a comment.May 3 2023, 16:46

I just realized that src/applications/config/check/PhabricatorGDSetupCheck.php exists. Thus please ignore my last comment. Still, things should fail gracefully instead of showing an exception.

valerio.bozzolan awarded a token.May 3 2023, 19:07
aklapper added a comment.May 4 2023, 10:58

Also, trying to Upload Picture in a user Profile, not having php-gd installed leads to a confusing error message not listing any file formats:
This server only supports these image formats: .

Cigaryno added a comment.Jun 29 2023, 20:41

Do you mean PHP 8.0 or PHP 8.1? I'm confused.

aklapper added a comment.Jun 30 2023, 10:16
In T15326#11073, @Cigaryno wrote:

Do you mean PHP 8.0 or PHP 8.1? I'm confused.

Since PHP 8.0.0, PHP's imagecreatefromstring() "returns a GDImage instance on success; previously, a resource was returned."

aklapper mentioned this in T15498: PHP 8.2 "strlen(null)" exception when viewing image details.Jul 5 2023, 17:45
aklapper updated the task description. (Show Details)Jan 13 2024, 14:32
aklapper added a revision: D25515: Avoid exception setting project profile image when GD not installed.Jan 13 2024, 20:54
aklapper closed this task as Resolved by committing rP7a86040f8a46: Avoid exception setting project profile image when GD not installed.Jan 23 2024, 14:11
aklapper claimed this task.
aklapper added a commit: rP7a86040f8a46: Avoid exception setting project profile image when GD not installed.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0