Page MenuHomePhorge

Consider adopting the "search results context highlighting" feature from Wikimedia's fork
Open, Needs TriagePublic

Assigned To
Authored By
Dec 14 2023, 17:30
Referenced Files
F498772: image.png
Dec 14 2023, 17:30
F498748: image.png
Dec 14 2023, 17:30
"Love" token, awarded by Iniquity."Like" token, awarded by avivey.


In Wikimedia's phabricator( T230787) I implemented contextual highlighting of (full-text) search results. In upstream Phab (and Phorge) the search results only include the title of matching documents. There is significant amount of extra processing involved in extracting the document bodies and highlighting the matching search terms, however, I never noticed enough performance impact to worry about optimizing it.

For upstream we might want to make it into a configurable setting so that installs can choose to disable the feature if they are running on very limited hardware. Wikimedia has very powerful hardware (as far as I remember, 64 cores Xeon systems with 128gb ram) running their phabricator nodes, so that might be why it never seemed to have a noticeable performance impact.

Another possible improvement that would be fairly easy to implement (I think so anyway) :

The highlighting process could track elapsed time and stop highlighting any further documents after a fixed amount of time elapses, so results get context and highlights but avoid timeouts and keep user experience and perceived performance from degrading.

To see the feature in action you can just try a search on, for example: search for phorge upstream. The results page features excerpts from each matching document, complete with highlights on the matching search terms.

image.png (961×1 px, 235 KB)
image.png (961×1 px, 141 KB)
With contextWithout