make linter happy

Note that this patch does NOT default to admin as proposed in T15443#9918 as I could imagine confusion by overwriting that value on existing installations. Happy to adjust though...

In P13#202, @smith wrote:

Shouldn't Create and Edit be lowercase?

I don't have much of an attention span these days, sorry.

I had communicated these upstream (almost exactly a year ago~) and some helpful information was provided

Partially related to

I've done my best to implement all proposed improvements

Before this change NULL was indeed implicitly casted to ''

Ah, sorry @20after4 if I broke "your" Wikimedia Phabricator ihih

In T15653#13929, @valerio.bozzolan wrote:

Yeah so we are all for "let's just append as default and maybe think about something more for the future, if they ask"

Yeah so we are all for "let's just append as default and maybe think about something more for the future, if they ask"

What if it were possible to intentionally remove a tag by passing the tag prepended with - to signify removal? like ?tags=-ABCDE to remove a tag but otherwise the behavior would be to just append. I realize this doesn't have the same compatibility advantages but it does offer slightly more flexibility for use in ad-hoc workflows.

Hi @Matthew can I help in landing this useful change?

You have green light, feel free to land and thanks

@valerio.bozzolan: I've lost track a bit given the latest comments. Shall I commit the accepted version, or are changes required?

Where to find the test plan? (And is expanding a hard requirement to get this reviewed?)

Maybe we can expand the test plan:

Thanks for reporting.

After applying this patch locally, after selecting Import .ics file, I can confirm that /calendar/import/edit/ does not show an URI field anymore, and that selecting an ICS File and importing it successfully creates calendar/import/8/ with expected name, date, and time.

Hi @bekay, feel free to look at D25408. It should fix your original problem. Thanks for your reporting

I've probably understood what is going on here

What about something like this?

Hoping to be useful, let's land this.

move comment

Yeah, the first run of arc lint creates the file, and subsequent runs do not update it.

smallcow test case added.

add useful comment (at least in my opinion) about $idx

I'm trying to propose two unit tests, but I'm not able to make them "fail" before the change. The unit always says "OK" so I think I'm not useful :( But here as reference:

Replace $m with $matches, as per review.

git rebase master

I triage this to Wishlist since it's indeed useful to some people but it's somehow still controversial. In order to attract more eyes, adding also Discussion Needed.