Page MenuHomePhorge

smith (Smith)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 22 2023, 09:15 (40 w, 2 d)
Availability
Available

Recent Activity

Jul 18 2023

smith renamed T15556: Improve Diffusion identity reassignment propagation from Show the Assigned Identity from Diffusion Commits pages to Improve Diffusion identity reassignment propagation.
Jul 18 2023, 12:53 · Bug Reports, Diffusion

Jun 29 2023

smith added a comment to P13 T15443.

<bikeshedding>

+    return pht('Can Create and Edit Identities');

Shouldn't Create and Edit be lowercase?
</bikeshedding>

Jun 29 2023, 12:25

Jun 7 2023

smith awarded T15453: Diffusion: Create Identity form is incomplete a Like token.
Jun 7 2023, 18:04
smith added a comment to T15443: Add Diffusion policy capability "Can Edit and View Identities".

It also might make sense to hide the actual list from the general public

I agree. Wouldn't it make sense to put it behind repository.identity.view?

Jun 7 2023, 12:04 · Diffusion, Policy
smith closed T15451: Implement Diffusion identity reassignment access control as Invalid.

It turns out that this is a duplicate:
T15443: Add Diffusion policy capability "Can Edit and View Identities"

Jun 7 2023, 12:01 · Policy, Security, Feature Requests, Diffusion
smith updated Q59: Diffusion Identity reassignment doesn't propagate correctly from Identity reassignment doesn't propagate correctly in Diffusion Commits search results to Identity reassignment doesn't propagate correctly in Diffusion.
Jun 7 2023, 10:20 · People, Diffusion, Bug Reports
smith added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

No, your edit is not correct. The same happens in search, as I indicated in the description:

or craft a query for Diffusion commits, specifying X as author

So if after following my instructions you go to /diffusion/commit/query/all/, you see all of the commits with the author field correctly displayed. If, however, you proceed to editing a query and you select user X as author, you get the "old state".

Jun 7 2023, 10:17 · People, Diffusion, Bug Reports
valerio.bozzolan awarded Q59: Diffusion Identity reassignment doesn't propagate correctly a Mountain of Wealth token.
Jun 7 2023, 10:12 · People, Diffusion, Bug Reports
smith added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly (Answer 76).

I ran repository rebuild-identities --all-repositories --all-identities, but it didn't change anything.

Jun 7 2023, 10:12
smith added a comment to T15451: Implement Diffusion identity reassignment access control.

But, they identities probably should be editable only for:

  • people who can edit the repository (people who administer it)
  • you, if the email matches yours (since you somehow pushed in the repository)
Jun 7 2023, 10:08 · Policy, Security, Feature Requests, Diffusion
smith updated the question details for Q59: Diffusion Identity reassignment doesn't propagate correctly.
Jun 7 2023, 08:58 · People, Diffusion, Bug Reports
smith added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Done.

Jun 7 2023, 08:34 · People, Diffusion, Bug Reports
smith changed the visibility for F307447: image.png.
Jun 7 2023, 08:33
smith changed the visibility for F307448: image.png.
Jun 7 2023, 08:32
smith changed the visibility for F307449: image.png.
Jun 7 2023, 08:32
smith changed the visibility for F307450: image.png.
Jun 7 2023, 08:32
smith added Q60: Diffusion identity reassignment access control (Answer 73).
Jun 7 2023, 08:14
smith closed Q60: Diffusion identity reassignment access control as invalid.
Jun 7 2023, 08:14 · Diffusion, Feature Requests
smith created T15451: Implement Diffusion identity reassignment access control.
Jun 7 2023, 08:14 · Policy, Security, Feature Requests, Diffusion
smith added a comment to Q60: Diffusion identity reassignment access control.

Ah, sorry. I'll create the ticket in a minute.

Jun 7 2023, 07:58 · Diffusion, Feature Requests
smith added a project to Q60: Diffusion identity reassignment access control: Diffusion.
Jun 7 2023, 07:40 · Diffusion, Feature Requests
smith added a project to Q59: Diffusion Identity reassignment doesn't propagate correctly: Diffusion.
Jun 7 2023, 07:40 · People, Diffusion, Bug Reports
smith added a comment to T15449: Herald commit hooks run for non-published refs.

Just trying to convince you.
If the feature works, it adds functionality that can't be easily replicated. You can have a bunch of complex Herald rules and bypass them all just by declaring that ^temp/ refs are now non-permanent. If the feature doesn't work (or maybe doesn't exist, rather), you have to go to each Herald rule and explicitly exclude ^temp/ branches, which is a lot of work for something that (at least for me) looks like it should be simple.

Jun 7 2023, 07:38 · Herald, Bug Reports
smith asked Q60: Diffusion identity reassignment access control.
Jun 7 2023, 07:30 · Diffusion, Feature Requests
smith added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Here, I assigned one of your identities to myself:

image.png (362×370 px, 18 KB)

Now when you go to the list of your commits, there is some entry from "me", but there shouldn't.
image.png (383×503 px, 27 KB)

And when you look at my commits, there are none — but there should, as this commit is now mine, as far as Diffusion is concerned.
image.png (376×475 px, 15 KB)

image.png (234×757 px, 17 KB)

Jun 7 2023, 07:23 · People, Diffusion, Bug Reports
smith added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

This is about Diffusion identity assignment feature. List of identities is here: https://we.phorge.it/diffusion/identity/
The simplest way to test it would be to make a test repository and proceed according to the instructions as above. I hope the process is laid out quite clearly.

Jun 7 2023, 07:16 · People, Diffusion, Bug Reports

Jun 6 2023

smith updated the question details for Q59: Diffusion Identity reassignment doesn't propagate correctly.
Jun 6 2023, 19:33 · People, Diffusion, Bug Reports
smith updated the question details for Q59: Diffusion Identity reassignment doesn't propagate correctly.
Jun 6 2023, 14:53 · People, Diffusion, Bug Reports
smith asked Q59: Diffusion Identity reassignment doesn't propagate correctly.
Jun 6 2023, 14:51 · People, Diffusion, Bug Reports

Jun 3 2023

smith added a comment to Q56: Herald runs even for non-permanent refs (Answer 72).

Usually it's a fair point, but this is Herald, which is one big custom settings panel, essentially. But maybe enabling it by default shouldn't be too bad — I don't imagine that workflows that include pushing a lot of unknown commits to non-published branch and then changing a published ref to include those would be very common.

Jun 3 2023, 12:58
smith added a comment to Q56: Herald runs even for non-permanent refs (Answer 72).

…only if that new ref contains commits which were not visible to Herald before, which shouldn't be too common. Also the Herald commit rule could have an option to enable or disable that behavior.

Jun 3 2023, 12:34
smith added a comment to Q56: Herald runs even for non-permanent refs (Answer 72).

Technically, I think a commit may be pushed without being in any ref?

Jun 3 2023, 11:49

May 22 2023

smith added a comment to Q42: How to put a line break in a Remarkup cell?.

Thanks a lot!

May 22 2023, 12:58 · Remarkup
smith added Q42: How to put a line break in a Remarkup cell? (Answer 69).
May 22 2023, 12:53
smith added a comment to Q42: How to put a line break in a Remarkup cell?.

You can do it using HTML tags and literal line breaks, like this:

1122
AAB
B

But you probably already know that, given that the task you quoted was closed by committing this revision.
(<br> doesn't work here, but I think it should, even if it's ignored in plain Remarkup.)

May 22 2023, 09:45 · Remarkup
smith asked Q56: Herald runs even for non-permanent refs.
May 22 2023, 09:33 · Bug Reports, Herald