Page MenuHomePhorge

Allow branch names to be integer values to avoid an InvalidArgumentException
Needs RevisionPublic

Authored by aklapper on Sat, Sep 16, 13:51.
Referenced Files
F357906: D25438.id1388.diff
Mon, Sep 25, 05:47
F357704: D25438.id1388.diff
Sun, Sep 24, 13:57
Unknown Object (File)
Sat, Sep 23, 16:25
Unknown Object (File)
Fri, Sep 22, 08:53
Unknown Object (File)
Thu, Sep 21, 06:29



phutil_nonempty_string() is too strict for branch names, as there seem to be
cases that an integer value is passed. Thus us phutil_nonempty_scalar() instead.

EXCEPTION: (InvalidArgumentException) Call to phutil_nonempty_string() expected null or a string, got: int. at [<arcanist>/src/utils/utils.php:2124]
 arcanist(), ava(), phorge(), translations(), wmf-ext-misc()
   #0 <#2> phutil_nonempty_string(integer) called at [<phorge>/src/applications/repository/storage/PhabricatorRepository.php:749]

Closes T15640

Test Plan


Diff Detail

rP Phorge
T15640 (branched from master)
Lint Passed
Tests Passed
Build Status
Buildable 844
Build 844: arc lint + arc unit

Event Timeline

avivey requested changes to this revision.Sun, Sep 17, 07:35
avivey subscribed.

Why would a branch name be an integer and not a string?

Without a test plan / reproduction, these kind of changes could be hiding a real issue.

This revision now requires changes to proceed.Sun, Sep 17, 07:35