- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Aug 4 2023
After this change it's probably no longer possible to persist NULL.
Tested thanks!
I just applied the patch to our instance and it works. :) Thanks again. I'll monitor this so I see when I can stop manually applying the patch… ;-)
Raised PHP bug https://github.com/php/php-src/issues/11871
In T15586#12570, @Ekubischta wrote:
Just to illustrate my point - here are the repositories of phorge: https://we.phorge.it/diffusion/
Aug 3 2023
What is even stranger is that theoretically, php should not be able to exit with a status code of -1 - If you try, it changes it to 255
Hi @20after4 what do you think about the attached video? Do you like this feature? :)
This ticket seems to mix several different things (block people who harass versus filtering content that you want to see). This ticket does not describe an underlying root problem but a potential solution. @Quartz: Please see https://we.phorge.it/book/contrib/article/describing_problems/ and improve this ticket - thanks.
Please do not add random project tags, as this is not a problem in Wikimedia at all. Thanks!
We do need the null check - but only for the unit test when the diff is not associated with a repository.
For live use, getSourceControlBaseRevision() will always return a string.
- Just checked the getSourceControlBaseRevision() functions
I honestly still do not understand what is happening here, what does it mean disabled:3:1:E043 or error:3:1:E019 or anything, but:
And, just to clarify, have MediaWiki something similar? Probably the "Mute User". Is Mute user the needed thing?
We could expand a bit the Task description to clarify why the Disable User button and the Remove User are not sufficient for this purpose.
I think that D25359 is a nice example of a complete use case, where one Diff from one repo depends from another Diff from another repo.
Aug 2 2023
I noticed that Phorge exports the date in this format:
Nice. Let's file a Task for that. We can work with arc patch D25359 --skip-dependencies in the meanwhile
looks like arc patch tries to patch D25358 first, because this diff "Depends on" that one - but that one is in arcanist, not phorge.
$ phorge (master)> arc patch D25359 INFO Base commit is not in local repository; trying to fetch. Branch name arcpatch-D25359 already exists; trying a new name. Branch name arcpatch-D25359_1 already exists; trying a new name. Created and checked out branch arcpatch-D25359_2. INFO Base commit is not in local repository; trying to fetch. Checking patch src/workflow/ArcanistExportWorkflow.php... error: src/workflow/ArcanistExportWorkflow.php: does not exist in index Checking patch src/parser/ArcanistBundle.php... error: src/parser/ArcanistBundle.php: does not exist in index
Can you share a nice A/B test on Microsoft Windows to upload?
Premising that I never manually "use" the scrollbar: I always use the mouse roll on desktop, or the finger swipe on mobile.
git rebase master
Soft+1 but let's wait for another +1. Thanks!
+1 with just that inline suggestion
Tested, no nuclear implosions, thanks as usual :)
Soft-accept! Tested and it works. Waiting for another tester.
Soft-accept. Thanks! I will test this a bit over additional integer fields
Aug 1 2023
Remove unrelated Credentials change now covered in T15580 instead
Handle empty $value in PhabricatorStandardCustomFieldPHIDs.php instead
In D25346#10708, @aklapper wrote:In D25346#10087, @avivey wrote:I think this should be implemented using the getHead() method that's already defined.
Could you elaborate a bit, please? I'm not sure what exactly not to do here, and what to do instead. Thanks in advance!
clicking such a link w/javascript disabled will do nothing. Changing it to #123 and no JS will do something....
Implicitly, Phorge generally works fine for browsers where Javascript is completely disabled.
- Why these nice URLs are set in these links, if nobody visit them?
Less priority of course, since this Task I authored is super-stupid
In D25346#10087, @avivey wrote:I think this should be implemented using the getHead() method that's already defined.
OK I've done my best :D I admit it helped me psychologically.
If this is a feature request, then add all the things needed for a feature request - as in, "why would this feature be needed" and "what problem you're trying to solve".
Is this a bug or a feature request?
Why would it need to be a that?
Is this a bug or a feature request?
OK this was easy, but it really cannot be improved more than this in Legalpad or Phame. And this deserves a dedicated fix.
I'm 99% sure that this only affects Phame and Legalpad. I tested in Audit, Maniphest, Paste, Pholio and Files without issues.
This situation could be improved even more doing:
Increasing priority to normal since this feature is supposed to help to collaborate with others, but at the moment you only collaborate with yourself as default