Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication
ClosedPublic
Actions

Authored by aklapper on Aug 4 2023, 15:01.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15587: PHP 8.1 "strlen(null)" exception adding LDAP authentication

Commits

rP9fe2bfebe8d6: Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=788098096e11), phorge(head=master, ref.master=840a7fab2bc8)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php:430]

Closes T15587

Test Plan

Go to /auth/config/edit/?provider=PhabricatorLDAPAuthProvider and see that "Add Auth Provider: LDAP" page is rendered.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Aug 4 2023, 15:01

Owners added a reviewer: O1: Blessed Committers.Aug 4 2023, 15:01

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptAug 4 2023, 15:01

aklapper requested review of this revision.Aug 4 2023, 15:01

Harbormaster completed remote builds in B726: Diff 1203.Aug 4 2023, 15:01

Tested thanks!

I've debugged the involved line with phlog to verify that it only assumes NULL or the following string:

Optionally, specify a username attribute to use to prefill usernames when registering a new account. This is purely cosmetic and does not affect the login process, but you can configure it to make sure users get the same default username as their LDAP username, so usernames remain consistent across systems.

Any other unexpected value will create a super-nuclear-implosion, and indeed Phorge/Phabricator likes that.

sgtm