Thanks bob, ready for land
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 10 2023
Aug 10 2023
bob published D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument for review.
bob updated the task description for T15598: PHP 8.2 : rtrim(): Passing null to parameter #1 ($string) of type string is deprecated when checking notification servers.
bob updated the task description for T15598: PHP 8.2 : rtrim(): Passing null to parameter #1 ($string) of type string is deprecated when checking notification servers.
Great news, thanks for your review valerio !
Can you attach the stack trace of when you try to re-upload an image?
valerio.bozzolan updated the diff for D25078: Trigger: Capitalize most Buzzwords in our Weird Way as usual.
let's also fix a typo (thanks Sten)
Thanks bob! Ready to land
valerio.bozzolan updated the test plan for D25380: Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController.
Aug 9 2023
Aug 9 2023
bob added a comment to T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.
I finally found it, D25381 fix the issue.
Sorry for the noise on this diff, I did something wrong during another diff creation procedure (I'm not an arcanist pro since I don't use it in my professional workflow).
bob updated the task description for T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.
bob added a comment to T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.
Great, I'll give it a try as soon as I can.
Sten added a comment to T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.
What was your strategy to locate strlen(null) issue without any stacktrace, manual code analysis ?
'git grep' to find where the error page was generated, then adding the missing phlog($ex) to get the stack trace.
Contact Amazon ASAP?
valerio.bozzolan awarded Q71: Starting over after catastrophic S3 loss a The World Burns token.
bob added a comment to T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.
I applied this diff but unfortunately, it doesn't fix the issue...
What was your strategy to locate strlen(null) issue without any stacktrace, manual code analysis ?
Partially related to T15578: The action "Quote comment" has an incomplete fragment URL
Aug 8 2023
Aug 8 2023
Sten added a comment to T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.
Testing with my PHP 8.1, I can't replicate this. But I do have a bunch of PHP 8.1 fixes in place which are still awaiting approval.
Hi, I can also see this one that looks weird in big pannels available on dashboards
Apart from the pre-existing 'Statues' typo, looks good to me...
valerio.bozzolan awarded D25380: Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController a Love token.
Aug 7 2023
Aug 7 2023
Also, I apologize for not completing this, hadn't had much spare time until recently. I will work on this soon.
valerio.bozzolan updated the answer details for Q70: PHP 8.2 bug report "strlen() null exception" when using the top bar search tool (Answer 94).
valerio.bozzolan updated the answer details for Q70: PHP 8.2 bug report "strlen() null exception" when using the top bar search tool (Answer 94).
valerio.bozzolan updated the answer details for Q70: PHP 8.2 bug report "strlen() null exception" when using the top bar search tool (Answer 94).
bob updated the question details for Q70: PHP 8.2 bug report "strlen() null exception" when using the top bar search tool.
bob updated the question details for Q70: PHP 8.2 bug report "strlen() null exception" when using the top bar search tool.
bob updated the question details for Q70: PHP 8.2 bug report "strlen() null exception" when using the top bar search tool.
aklapper added a comment to T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1!.
For the records, I did not compile from source, I had used the official Fedora package php-8.2.9-1.fc38 created on Aug 1st from https://koji.fedoraproject.org/koji/packageinfo?packageID=72
Sten added a comment to T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1!.
The issue is in a change which went in with PHP 8.1.22, and is being reverted in PHP 8.1.23.
@aklapper - as PHP 8.2.9 isn't released yet, I assume you compiled from source? If you 'git pull' and recompile, the latest 8.2.9-dev should work. The fix was committed Aug 2 21:08:52.
Matthew requested changes to D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.
Please fix unit errors
I see no problem with consistency.
Aug 6 2023
Aug 6 2023
aklapper retitled D25378: Fix PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster from Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster
aklapper renamed T15593: PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster from PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster to PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster.
aklapper requested review of D25376: Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
valerio.bozzolan renamed T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends from Generate [From, Subject, Date] fields in download raw .diff URL to Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
- Automatically continued bulleted list upon new line
Done.
aklapper added a comment to T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.
In T15486#10906, @golyalpha wrote:I'd expect that a user's contact numbers might show up on their profile to other registered users.
Aug 5 2023
Aug 5 2023
aklapper closed T15581: PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rP226f3150933d: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy
Add HTML header for Atom/RSS discovery on Phame blog pages
aklapper added a comment to T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1!.
Three days ago I ran into the same output (though different steps in Phorge that I don't perfectly remember) after upgrading from PHP 8.2.8 to PHP 8.2.9 on Fedora 38. Thus I downgraded again.
Aug 4 2023
Aug 4 2023
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0