Should this be documented here? I think yes
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Aug 1 2023
I'm mentioning this small thing in the Changelog since some people may have legacy Dashboards with a Panel that was Archived just to try. So there is less surprise on your Phorge homepage.
fix comment
LGTM, except for the comment text.
Jul 31 2023
Yeah just try "arc land" and, if it does not work, we can land this for you
Okay, now how do I land this? Just arc land? Again, in my current setup there is no way of unit testing, so I don't know if it is possible...
Optimizes querying of project edges of multiple documents.
In T15540#12393, @avivey wrote:I don't think it's related ...
Also maybe Macro app could deserve a nice Hovercard :)
I'm quite sure we have to set PhabricatorApplicationTransaction.php::setIgnoreOnNoEffect(bool) somewhere but I don't know where ihih
In T15540#11723, @valerio.bozzolan wrote:Partially related? Sometime I put my pointer hover the "Authored By <foo>" or similar fields, but they have no Hovercards. Probably easy-peasy?
Small issue in the query, but otherwise looks good.
Complete some issues.
Remove count.
In D25303#10646, @bekay wrote:In D25303#10634, @valerio.bozzolan wrote:Probably, the tags, if present, should be listed as last entry.
Would be, as already said, a big rewrite ...
In D25303#10634, @valerio.bozzolan wrote:Probably, the tags, if present, should be listed as last entry. I suggest this since it's an info of variable-length, that is probably better in the footer.
Uh thanks!
Created repo rQR QR Stickers and project QR Codes Extension
Created repo rQR QR Stickers and project QR Codes Extension
Address code review comments
Jul 30 2023
Yeah, we can use isset() and strlen() in place of phutil_nonempty_string(), and I'm happy to do it.
Premising that I liked this before, and I like this even more now,
I hope, this is now ready to land... sorry for the long delay 😅
Fix linting problem.
Use willRenderHovercards() to get all project and ancestor handles of potential multiple documents and rewrites inline SQL query.
In D25303#9015, @avivey wrote:Showing project tags might be unique to tasks - Revisions don't show them, and neither do Owners or Commits. It might make sense not to show it here either.
Jul 29 2023
In D25364#10593, @avivey wrote:$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.
maybe add that as a comment in there...
$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.
maybe add that as a comment in there...
I've added a couple of screenshots