We should definitely prioritize this, as after November of this year we won’t support any stable/maintained versions of PHP

rollback last changes made by mistake using arc diff

This is how it will render after this change:

fix "Undefined index: icon" when visiting Search Servers using MySQL

I need a little help from a Phorge admin, to understand if this page also gives an exception now:

What is the value of your Default View Policy of the Files application?

(Don't tell anyone that I tried to corrupt the blessed committers with a doubloon to try this lovely patch)

Yes, I guess we could add Mantis to that page also. :)

@Dylsss Wow. It would be nice to upload such files into Wikimedia Commons, since it renders SVG files.

Expanding task to also include adding compatibility with PHP 8.2

This is the very same of T15147: Prefill tags when user opens new task form in new tab from workboard column but specifying also the Column PHID.

(I agree that internally, the Herald rule should be saved as a Global Task-based. And I agree that it should be easily added and edited from the Workboard. I think that, in the future, this still need the Project Tag to be saved internally - as a kind of Object rule - so that, in the future, it will allow a more efficient query to find all global Herald rules without a Tag + all global Herald rules that are assigned to a Tag where that Tag is IN the list of Task's Tags.)

@rraval Could you or someone else verify that a project that is made visible only to Administrators still shows up when a user opens the search selection list on the Subscribers field? And is this considered to be a bug or a feature? Of course i can set up a new Task for this if that makes sense.

Is this related to Phorge itself?

I tested locally following the test plan and I've found this edit very useful.

arc lint

Rebased on master, ran bin/celerity map to resolve merge conflict.

Wow! Thank you so much.

Thank you.

I'm not assigned to this since I'm not really active. I was just curious. Feel free to give it a try and add more notes.

In T15047#3542, @avivey wrote:

I personally hate the $a = []; style, at least for empty arrays - I find it not-explicit enough.

Looks like that's because PhabricatorBadgesSearchConduitAPIMethod extends PhabricatorSearchEngineAPIMethod, and TransactionSearchConduitAPIMethod extends ConduitAPIMethod directly...

In T15047#3538, @valerio.bozzolan wrote:

Maybe unrelated. Can we - right now - update the coding standard to avoid $a = array() (that is a tremendous old approach) to just adopt $a = []? Note that the short version was introduced in PHP 5.4, that already is the minimum version right now. I'm talking about this document:

https://we.phorge.it/book/contrib/article/php_coding_standards/

Maybe unrelated. Can we - right now - update the coding standard to avoid $a = array() (that is a tremendous old approach) to just adopt $a = []? Note that the short version was introduced in PHP 5.4, that already is the minimum version right now. I'm talking about this document:

Thank you for this question.

Here a stupid spoiler of this. Milestone before: