Do you want an hand to land this accepted revision?

As a proof of concept I've uploaded a GIMP image (GIMP = green is my pepper) as Task image.

For some historical context, this current patch comes from another one from the Phabricator of Wikimedia Foundation:

OK no sorry, it already does not show any content.

This fluffy rabbit is released in the public domain by user Clevername.

@Dylsss thanks - can I ask if you agree with the edit suggestion?

This patch also tries improves the user experience of this diff:

So the goal is:

I tried to keep the diff as much small as possible. That is why I just added a small piece of code with a return; instead of a bigger refactoring.

I would like to fix this lint:

simplify ( $a->b() )->$b() to just $a->b()->c() since the first it's only supported in PHP 7.0

I have an ironical situation. This syntax is very supported:

skip the replacement of __CLASS__ to self::class since it can be just confusing

avoid to replace CLASS to self::class since it's probably nonsense

I'm pretty impressed by the power of Rector. I almost figured out how to use the 2% of it: Rector put my whole house in order, including Phorge and Arcanist that were on the bedside table.

This also contains an extra Bash line:

This is partially related:

I discovered that the ?tags= parameter both supports a PHID but... also any "Additional Hashtags". So for instance if we have a Project named "Test" we can then identify it as "?tags=test" instead of "tags=PHID-PROJ-sw7q6bislsityhc7isgp".

I will land since the author asked this kind of help, and avivey confirmed, and also asked to keep the same "no newline at end of file" and that's respected.

Now with 80% more cringe:

If somebody could land this at some point, that would be great!

If you think this patch is too complicated to review, I can do a middleware patch to just propose a small refactor without introducing any feature, and than turn back on this one.

Thanks - this logic could use some more love, as you say.