Page MenuHomePhorge

Fix middle-click, CTRL+click, right-click etc. on Typehead search results
ClosedPublic

Authored by valerio.bozzolan on Feb 26 2023, 21:51.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 21, 18:59
Unknown Object (File)
Fri, Jul 19, 20:38
Unknown Object (File)
Tue, Jul 16, 17:17
Unknown Object (File)
Tue, Jul 16, 08:57
Unknown Object (File)
Tue, Jul 16, 08:56
Unknown Object (File)
Tue, Jul 16, 03:11
Unknown Object (File)
Sun, Jul 14, 19:29
Unknown Object (File)
Tue, Jul 9, 17:50
Tokens
"Love" token, awarded by 20after4."Cup of Joe" token, awarded by valerio.bozzolan."Yellow Medal" token, awarded by avivey.

Details

Summary

Fix middle-click, CTRL+click, right-click etc. on Typehead search results.

Closes T15149

Test Plan

Try the following actions on various typeheads:

  • right-click
  • middle-click
  • CTRL+click
  • normal click

Demonstration video (2M) showing After patch (on localhost) and Before patch (here on we.phorge.it), where I middle-click and normal-click on menu entries:

Notes:

  • the middle click now works (opening in new tab)
  • the CTRL+click (or "command" key + click) now works (opening in new tab)
  • the right click now opens the context menu (previously broken)
  • the normal click should just click (as usual)

Try on:

  • search results while typing in main search bar
  • search results when editing a Task Tags / assigned to, etc.
  • try to click on other weird places
  • $$$

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rollback last changes made by mistake using arc diff

avivey awarded a token.
This revision is now accepted and ready to land.Mar 3 2023, 10:24