Page MenuHomePhorge

Fix middle-click, CTRL+click, right-click etc. on Typehead search results
ClosedPublic

Authored by valerio.bozzolan on Feb 26 2023, 21:51.
Tags
None
Referenced Files
F3553866: D25069.1744959841.diff
Thu, Apr 17, 07:04
F3529272: D25069.1744862009.diff
Wed, Apr 16, 03:53
F3387246: D25069.1744433867.diff
Fri, Apr 11, 04:57
F3379025: D25069.1744363762.diff
Thu, Apr 10, 09:29
F3374814: D25069.1744297451.diff
Wed, Apr 9, 15:04
F3371501: D25069.1744242413.diff
Tue, Apr 8, 23:46
F3368448: D25069.1744209171.diff
Tue, Apr 8, 14:32
F3367789: D25069.1744203204.diff
Tue, Apr 8, 12:53
Tokens
"Love" token, awarded by 20after4."Cup of Joe" token, awarded by valerio.bozzolan."Yellow Medal" token, awarded by avivey.

Details

Summary

Fix middle-click, CTRL+click, right-click etc. on Typehead search results.

Closes T15149

Test Plan

Try the following actions on various typeheads:

  • right-click
  • middle-click
  • CTRL+click
  • normal click

Demonstration video (2M) showing After patch (on localhost) and Before patch (here on we.phorge.it), where I middle-click and normal-click on menu entries:

Notes:

  • the middle click now works (opening in new tab)
  • the CTRL+click (or "command" key + click) now works (opening in new tab)
  • the right click now opens the context menu (previously broken)
  • the normal click should just click (as usual)

Try on:

  • search results while typing in main search bar
  • search results when editing a Task Tags / assigned to, etc.
  • try to click on other weird places
  • $$$

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rollback last changes made by mistake using arc diff

avivey awarded a token.
This revision is now accepted and ready to land.Mar 3 2023, 10:24