Page MenuHomePhorge
Create Task
Maniphest T15144

Conduit transaction.search: Missing "Constraint" section in the documentation
Open, NormalPublic
Actions

Description

I noticed that in the transaction.search the Constraint documentation is not displayed in the left menu bar:

https://we.phorge.it/conduit/method/transaction.search/

Instead, badge.search has that:

https://we.phorge.it/conduit/method/badge.search/

Maybe it's a feature, but I don't get it.

Event Timeline

valerio.bozzolan created this task.Feb 14 2023, 16:23
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptFeb 14 2023, 16:23
avivey triaged this task as Normal priority.Feb 17 2023, 08:29
avivey subscribed.

Looks like that's because PhabricatorBadgesSearchConduitAPIMethod extends PhabricatorSearchEngineAPIMethod, and TransactionSearchConduitAPIMethod extends ConduitAPIMethod directly...

avivey added a project: Good Starter Task.Feb 17 2023, 08:34
valerio.bozzolan added a project: User-valerio.bozzolan.Mar 28 2023, 09:04
avivey removed a project: Deprecated Conduit.May 9 2023, 10:51
valerio.bozzolan removed a project: Good Starter Task.Jun 17 2023, 15:11

This is probably not so simple. Doing that change causes this problem:

>>> UNRECOVERABLE FATAL ERROR <<<

Cannot override final method PhabricatorSearchEngineAPIMethod::defineParamTypes()

/var/www/phorge/src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php:86


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
valerio.bozzolan added a project: Conduit.Jun 19 2023, 07:28
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0