Page MenuHomePhorge

Missing Diffusion Admin "Actions" on mobile
Closed, ResolvedPublic


Current situation

At the moment there is a bug in the Diffusion UI since you cannot manage a repository from mobile.

In short, this administration box is not visible on mobile, for example if you visit this page:

Note that on mobile there are no "Actions":

Diffusion before D25109.png (366×670 px, 32 KB)

So you don't see these actions:

image.png (316×320 px, 16 KB)

Desired situation

If you see this page on mobile:

The "Actions" button should be visible:

Diffusion after D25109.png (366×670 px, 33 KB)

Steps to reproduce

  • take a smartphone
  • visit a Diffusion repository > Actions > Manage Repository

Description of the problem

It seems there are these rules hiding the thing on mobile:

.device .curtain-no-panels {
 display: none;
.device .phabricator-action-list-view {
  display: none;

This has partially sense since, generally, the actions list view should be hidden on mobile, since it's supposed to be there a curtain.

But, in this case, where there is no curtain, this has probably not much sense.

Proposed solution n. 1 (general approach)

NOTE: I'm not bold enough to do this.

Since I think that one day someone sayd "it makes sense to hide all listviews on a small device without a Curtain Actions button" maybe it has sense to do not just rollback it but do a little more.

For example, we can replace this rule:

.device .phabricator-action-list-view {
  display: none;

With a more generic one like:

.device .hide-on-device {
  display: none;

In this way we can just adopt class="hide-on-device" to hide specific elements on a small device, when needed, instead of assuming that a certain class of elements should be just always invisible on mobile as default.

So, if there is no Curtain, that element is not marked as "hide-on-device".

Proposed solution n. 2 (specific fix)

Adopt the "Curtain" menu in the Diffusion admin page.

Example of the Curtain menu:

Screenshot_2022_12_17_154833.png (161×317 px, 9 KB)

Source code related to Curtain generation in Diffusion:

Note that the Diffusion section "Storage" instead has a Curtain that works:


Part of the problem in DiffusionRepositoryBasicsManagementPanel.php was probably introduced here:

That was an incomplete rollback of this change:

Event Timeline

valerio.bozzolan renamed this task from Fix Diffusion administration on mobile to Missing Diffusion Admin actions on mobile.Dec 17 2022, 14:50
valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan renamed this task from Missing Diffusion Admin actions on mobile to Missing Diffusion Admin "Actions" on mobile.Apr 3 2023, 10:28
valerio.bozzolan claimed this task.
valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan added a project: UX.