Current situation

At the moment there is a bug in the Diffusion UI since you cannot manage a repository from mobile.

In short, this administration box is not visible on mobile, for example if you visit this page:

https://we.phorge.it/source/phorge/manage/

Note that on mobile there are no "Actions":

So you don't see these actions:

Desired situation

If you see this page on mobile:

https://we.phorge.it/source/phorge/manage/

The "Actions" button should be visible:

Steps to reproduce

• take a smartphone
• visit a Diffusion repository > Actions > Manage Repository

Description of the problem

It seems there are these rules hiding the thing on mobile:

.device .curtain-no-panels {
 display: none;
}
.device .phabricator-action-list-view {
  display: none;
}

This has partially sense since, generally, the actions list view should be hidden on mobile, since it's supposed to be there a curtain.

But, in this case, where there is no curtain, this has probably not much sense.

Proposed solution n. 1 (general approach)

Since I think that one day someone sayd "it makes sense to hide all listviews on a small device without a Curtain Actions button" maybe it has sense to do not just rollback it but do a little more.

For example, we can replace this rule:

.device .phabricator-action-list-view {
  display: none;
}

With a more generic one like:

.device .hide-on-device {
  display: none;
}

In this way we can just adopt class="hide-on-device" to hide specific elements on a small device, when needed, instead of assuming that a certain class of elements should be just always invisible on mobile as default.

So, if there is no Curtain, that element is not marked as "hide-on-device".

Proposed solution n. 2 (specific fix)

Adopt the "Curtain" menu in the Diffusion admin page.

Example of the Curtain menu:

Source code related to Curtain generation in Diffusion:

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/controller/DiffusionRepositoryManagePanelsController.php

Note that the Diffusion section "Storage" instead has a Curtain that works:

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php

History

Part of the problem in DiffusionRepositoryBasicsManagementPanel.php was probably introduced here:

https://secure.phabricator.com/rPbb369c7b711f6eb5f6b3ca9a0c8b85a088b05dc1

That was an incomplete rollback of this change:

https://secure.phabricator.com/rPe1fd74ddb545a2de3963fd60a6c5f4c1d5075814