In T15526#16806, @aklapper wrote:Which exact page(s) is this ticket about?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Apr 22 2024
Apr 22 2024
Apr 21 2024
Apr 21 2024
Jack_who_built_the_house added a comment to Q128: How deeply is Ponder integrated with the rest of Phorge? (Answer 159).
@20after4 Thanks for the response. Integration with search is something I overlooked, but you're right; tasks can naturally come from questions, and questions can naturally come from tasks. Their joint discoverability and interplay is a fertile soil for education and development. As volunteers, our role is kind of limited in many cases to being passive recipients of what is decided in WMF internal communications. Having public discussions of components could add more dynamism to the process.
20after4 added a comment to Q128: How deeply is Ponder integrated with the rest of Phorge? (Answer 159).
I think ponder is sort of a minimal viable product state currently. It lacks some features like putting questions on workboards and there just aren't many
(or any?) integrations with the rest of Phorge. That wouldn't take much effort to improve it, most likely.
Jack_who_built_the_house added a comment to Q128: How deeply is Ponder integrated with the rest of Phorge? (Answer 159).
But this is the exact reason I started to consider Ponder in the first place. All previous attempts implied fragmentation, while Ponder is integrated in the system people already use (Phabricator), both developers and volunteers, and in numbers. I've explained in more details how I see the current situation at https://meta.wikimedia.org/wiki/User_talk:SDeckelmann-WMF#How_volunteer_developer_support_could_be_improved_in_Wikimedia. Please share your view if you'd like. You can also join the discussion in the English Wikimedia Discord I started here.
Which exact page(s) is this ticket about?
Iniquity awarded Q128: How deeply is Ponder integrated with the rest of Phorge? a Love token.
Apr 20 2024
Apr 20 2024
In D25080#16551, @valerio.bozzolan wrote:Eeeh but in that way it's 84 and 87 chars long.
Note that $xaction->getOldValue() in https://we.phorge.it/source/phorge/browse/master/src/applications/people/xaction/PhabricatorUserUsernameTransaction.php$62 seems to always return null. It does not provide the old/current username, while generateOldValue() actually does.
aklapper requested review of D25601: Fix exception trying to rename user to their previous username.
Jack_who_built_the_house updated the question details for Q128: How deeply is Ponder integrated with the rest of Phorge?.
Jack_who_built_the_house updated the question details for Q128: How deeply is Ponder integrated with the rest of Phorge?.
Jack_who_built_the_house updated the question details for Q128: How deeply is Ponder integrated with the rest of Phorge?.
Apr 19 2024
Apr 19 2024
aklapper added a comment to D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.
Screenshot before (M17) and after (M18) applying D25600:
aklapper updated the task description for T15792: Dashboard query panel requiring a Current Viewer throws exception when not logged in.
Apr 18 2024
Apr 18 2024
aklapper renamed T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined from PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel to PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
aklapper updated the task description for T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Mormegil added a comment to T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.
Yeah, that might help (like specifically in the case of the Clone dialog) even though it wouldn't help with dialogs containing writable inputs. (E.g. on the repository page, click Flag For Later instead and press Shift+Tab and Escape.) A better fix would lie at https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/externals/javelin/lib/Workflow.js$413 where either the getSpecialKey would need improvement itself to return true for these non-modifying keys, or it would need to be amended with a custom check in that regard. However, I don't know where that function comes from.
valerio.bozzolan added a comment to T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.
Probably something here should be expanded to check if the form contains at least a visible input without read-only
Mormegil added a comment to Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction.
Thanks, created as T15788
valerio.bozzolan awarded Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction a Yellow Medal token.
valerio.bozzolan added a comment to Q127: [bug] “Form data changed” confirmation is shown after even read-only keyboard interaction.
You are now in the family of Trusted Contributors 🎇
Apr 17 2024
Apr 17 2024
Thanks again avivey. I liked the idea of using applyExternalEffects(). I have not found a way to do it efficiently, without introducing another static method.
aklapper committed rP5444e1c885c3: Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without…
aklapper committed rP5fe2fc33fb1c: Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without…
aklapper committed rPdb3e68137dcc: Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter
aklapper committed rP85903f968fda: Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format"….
Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format"…
aklapper committed rP412c01ffa6fb: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without…
aklapper committed rP0e53f91c9701: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter
aklapper committed rPd630f2281bcc: Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter
valerio.bozzolan reassigned T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType") from valerio.bozzolan to bekay.
(Credit to bekay indeed)
valerio.bozzolan closed T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType") as Resolved.
Nice :) Thanks
README: run upgrade after installation
aklapper committed rP98cbf5fa19e2: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as….
Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as…
aklapper committed rP0bdfcc47e7de: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
Bonus point: maybe instead of "#123" we can use "#L123" since both GitLab and GitHub use that (and that's not a stupid specification). Just because we can.
valerio.bozzolan added a comment to D25578: Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.
If we find 10 minutes, let's test this on every provider, as last time it gave us a little surprise on one of them
valerio.bozzolan accepted D25595: Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as parameter.
valerio.bozzolan accepted D25594: Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter.
Apr 16 2024
Apr 16 2024
aklapper committed rPc59a883e9de7: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/herald rule" without parameter
aklapper committed rPb29e5aa7ca22: Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/search query" without parameter
aklapper committed rP102c43fb6a87: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth refresh" without parameter
aklapper committed rP2c7be156a8c3: Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/auth unlimit" without parameter
aklapper committed rP9101c0b63df4: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter
aklapper committed rP6a2f2a589a0f: Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter.
Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance import" without parameter
aklapper committed rP05798a630120: Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without….
Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without…
You are right of course!
Yeah, there are some malformed URLs we should tackle for sure.
valerio.bozzolan triaged T15787: Diagrams: avoid double slash in the URL after Saving as Low priority.
valerio.bozzolan retitled D25593: README: run upgrade after installation from README: run upgrade after installation
Ref T15745
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0