Steps to reproduce:
- PHP 8.3.6, Phorge at 5444e1c885c337ede0f1fb4ad1916ae0b49b1413
- As an admin, go to http://phorge.localhost/people/manage/8/
- Select "Change Username" in the sidebar
- In the "Change Username" dialog, as "New Username", keep the old username, and click "Rename User"
Expected outcome:
Show an error message within the "Change Username" dialog, for consistency with behavior when entering an empty string as new username.
Actual outcome:
Get an Unhandled Exception ("PhabricatorApplicationTransactionNoEffectException"):
[2024-04-20 15:48:50] EXCEPTION: (PhabricatorApplicationTransactionNoEffectException) Transactions have no effect: - Transaction (of type "user.rename") has no effect. at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2823] arcanist(head=master, ref.master=ef73b12b580e), phorge(head=master, ref.master=5444e1c885c3) #0 <#2> PhabricatorApplicationTransactionEditor::filterTransactions(PhabricatorUser, array) called at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1283] #1 <#2> PhabricatorApplicationTransactionEditor::applyTransactions(PhabricatorUser, array) called at [<phorge>/src/applications/people/controller/PhabricatorPeopleRenameController.php:62] #2 <#2> PhabricatorPeopleRenameController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #3 phlog(PhabricatorApplicationTransactionNoEffectException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41] #4 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, PhabricatorApplicationTransactionNoEffectException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751] #5 AphrontApplicationConfiguration::handleThrowable(PhabricatorApplicationTransactionNoEffectException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296] #6 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #7 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]