Test plan:

Thanks for this patch

Interestingly, it seems that also avivey fixed this in another change, in this way:

Also, this mashes up Diffusion and Repositories to add confusion

I don't get the code.
src/applications/diffusion/controller/DiffusionIdentityViewController.php (note the View in its name) includes stuff like
$edit_uri = $this->getApplicationURI("identity/edit/{$id}/") defining ->setName(pht('Edit Identity')) (note the Edit here).
Also, this mashes up Diffusion and Repositories to add confusion (DiffusionIdentityEditController calls PhabricatorRepositoryIdentityEditEngine?).
I think I give up.

Hopefully fix unit test by running arc liberate locally first

In D25321#9358, @Cigaryno wrote:

The assertion for Harbormaster Unit 10862 has failed. Does anyone know why?

The assertion for Harbormaster Unit 10862 has failed. Does anyone know why?

Thanks.
Yes, it will be open source

Oh yeah - you can even host it here under Phactory: Community Projects (if you want to and it's open-source).

Cool extension! We still need to build a proper extension ecosystem for Phorge. Maybe we could start with a wiki page linking to known extensions, then you'll have a place to share your extension, should you decide to do so.

Maybe we should hide profile details for newly registered users as well? Requiring approval would reduce the value that spammers derive from registering accounts. At least it would raise the amount of effort required of the spammers but unfortunately would also raise the effort required of us to monitor / approve accounts . and we would need to define what the user is required to do to prove themselves.

Did some digging, and it looks like it would be more involved - it would require adding support code in the query engine (like Spaces), and making another DB call (Flags are their own objects), or re-implement Flags using Edges.

I was honestly not aware of that. Interesting. Thanks!

In D25319#9336, @speck wrote:

Is there another place not specifying the method for a form? I don’t think that attribute should be optional and instead the fix is to explicitly declare GET or POST or PUT for forms.

DO you know about arc browse?

It's enabled by default - https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$48

Is there another place not specifying the method for a form? I don’t think that attribute should be optional and instead the fix is to explicitly declare GET or POST or PUT for forms.

Nice! I flagged you as Trusted Contributors. (and if a friend of yours is also able to create such beautiful bug reports, feel free to flag them as well by yourself :D)

Thanks for the quick reply. I updated the question with the backtrace and a shell reproducer

The task had a heavy dose of "describe a solution, not a problem", so I cleaned it up.

Tested locally, and logged the values with phlog to verify with my big eyes that everything was under control. I was able to capture both cases:

Yes - much nicer. Thanks!

Thanks! You can just leave $http_method without any bracket :)

In T15129#11054, @Cigaryno wrote:

.. and vice versa

In T15326#11073, @Cigaryno wrote:

Do you mean PHP 8.0 or PHP 8.1? I'm confused.

more cases