Paths

Table of Contentst

Differential D25321

Fix PHP 8.1 "preg_split()(null)" exception registering account without Real Name
AbandonedPublic
Actions

Authored by aklapper on Jul 2 2023, 14:58.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15514: PHP 8.1 "preg_split()(null)" exception trying to register user account without setting Real Name

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=T15443, ref.master=8ffa6044626d, ref.T15443=8ffa6044626d)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #1 <#2> preg_split(string, NULL) called at [<phorge>/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php:159]

Closes T15514

Test Plan

After applying the patch, /auth/register/ shows expected error "Real name is required." after attempting to register an account.

Diff Detail

Repository

rP Phorge

Branch

registerAccountEmailRequired (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 618
Build 618: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 2 2023, 14:58

Owners added a reviewer: O1: Blessed Committers.Jul 2 2023, 14:58

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 2 2023, 14:58

Harbormaster completed remote builds in B617: Diff 1045.Jul 2 2023, 14:58

aklapper requested review of this revision.Jul 2 2023, 14:58

The assertion for Harbormaster Unit 10862 has failed. Does anyone know why?

In D25321#9358, @Cigaryno wrote:

The assertion for Harbormaster Unit 10862 has failed. Does anyone know why?

Because my tree was not clean though I told arc diff to ignore all other files. Guess I need to amend.

Hopefully fix unit test by running arc liberate locally first

Harbormaster completed remote builds in B618: Diff 1048.Jul 2 2023, 17:22

Thanks for this patch

Marking as request changes, since fortunately it seems that master is already fixed thanks to @avivey, just before the loop in the master :)

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
152	In the master, in line 153 here now there is a function that should already fix this thing https://we.phorge.it/source/phorge/browse/master/src/applications/auth/engine/PhabricatorAuthPasswordEngine.php;d725ffaa7728bdbcd07870e9e8f4d244eb9dcf41$153 Interesting edit conflict, look at the dates :O

This revision now requires changes to proceed.Jul 3 2023, 07:15

Looks like a mid-air collision, heh :)

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

engine/

PhabricatorAuthPasswordEngine.php

6 lines

O1: Blessed Committers

Diff 1048

View Options

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php

Fix PHP 8.1 "preg_split()(null)" exception registering account without Real NameAbandonedPublicActions