Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is NULL
ClosedPublic
Actions

Authored by Sten on Jun 30 2023, 12:43.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T15507: Going to Phorge website fails with strlen() error under PHP 8.1 when database replication is configured but not replicating

Commits

rP101ce834b8ad: Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is…

Summary

When MySQL database replication is configured, but not running, the slave status Seconds_Behind_Master is NULL.
When this value is passed to strlen() an error is thrown.

Fixes T15507

Test Plan

Configure database replication such that Seconds_Behind_Master is NULL
Restart php-fpm
Go to Phorge web site.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Jun 30 2023, 12:43

Owners added a reviewer: O1: Blessed Committers.Jun 30 2023, 12:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJun 30 2023, 12:43

Sten requested review of this revision.Jun 30 2023, 12:43

Harbormaster completed remote builds in B613: Diff 1038.Jun 30 2023, 12:43

chris accepted this revision.Jun 30 2023, 12:44

This revision is now accepted and ready to land.Jun 30 2023, 12:44

Sten edited the summary of this revision. (Show Details)Jun 30 2023, 12:45

Sten added a task: T15507: Going to Phorge website fails with strlen() error under PHP 8.1 when database replication is configured but not replicating.

Closed by commit rP101ce834b8ad: Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is…. · Explain WhyJun 30 2023, 12:49

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP101ce834b8ad: Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is….

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

cluster/

PhabricatorDatabaseRef.php

2 lines

O1: Blessed Committers

Diff 1039

View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is NULLClosedPublicActions