Page MenuHomePhorge
Feed All Stories

Jun 22 2023

valerio.bozzolan added a comment to Q48: Escaping elements in remarkup.

If you want to see a funny thing, visit this page in your Phorge:

Jun 22 2023, 10:34
valerio.bozzolan added a comment to T15011: Build a Phorge Developer Environment.

I would like to help in creating an account in docker.io for phorge, to publish again a similar image. It's not that difficult. But we need to use an official phorge.it email address, not a personal one.

Jun 22 2023, 06:32 · Extension Development

Jun 21 2023

bd808 added a comment to T15011: Build a Phorge Developer Environment.

There is a fully self-contained bitnami vm image which some people have had some luck with.

Jun 21 2023, 22:46 · Extension Development
valerio.bozzolan added a comment to D25304: Add resources/ssl/custom.pem to .gitignore.
In D25304#8910, @Sten wrote:

Wanted to ensure you had a chance to check the changes I made based on your review first...

Jun 21 2023, 19:20
Sten added a comment to D25304: Add resources/ssl/custom.pem to .gitignore.

Wanted to ensure you had a chance to check the changes I made based on your review first...

Jun 21 2023, 18:58
Sten closed D25304: Add resources/ssl/custom.pem to .gitignore.
Jun 21 2023, 18:57
Sten committed rARC8130241a11ac: Add resources/ssl/custom.pem to .gitignore.
Add resources/ssl/custom.pem to .gitignore
Jun 21 2023, 18:57
speck added a comment to D25291: Fix UX regression in Dashboard Tabs Panel.

No worries, I haven’t had time to dig in. I wanted to review D25067

Jun 21 2023, 17:08
aklapper added a comment to T15129: Unmark Audit as a required application.

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

Jun 21 2023, 13:31 · Diffusion, User-Cigaryno
valerio.bozzolan added a comment to D25304: Add resources/ssl/custom.pem to .gitignore.

Hi @Sten also here feel free to

Jun 21 2023, 13:19
valerio.bozzolan updated the summary of D25302: Workboard Columns: avoid page reload on Edit > Cancel.
Jun 21 2023, 13:16
valerio.bozzolan updated the summary of D25291: Fix UX regression in Dashboard Tabs Panel.
Jun 21 2023, 13:02
valerio.bozzolan changed the visibility for F312798: After D25291.png.
Jun 21 2023, 13:02
valerio.bozzolan changed the visibility for F312797: Before D25291.png.
Jun 21 2023, 13:02
valerio.bozzolan added a comment to D25291: Fix UX regression in Dashboard Tabs Panel.

Sorry again for this regression @speck

Jun 21 2023, 12:55
valerio.bozzolan edited the content of Next Up.
Jun 21 2023, 10:26
valerio.bozzolan abandoned D25073: Replace dirname(__FILE__) with __DIR__ (available since PHP 5.3).

I understand that nobody in the world likes refactoring. Even if it makes stuff more readable and a CPU cycle faster.

Jun 21 2023, 10:16
valerio.bozzolan added a comment to D25303: Implements a more informative hovercard for wiki documents.

If a third person leaves a positive comment I would be for approving it in the master, also to receive more feedback, or eventual follow-up graphical suggestions :)

Jun 21 2023, 10:00
valerio.bozzolan updated subscribers of D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

Jun 21 2023, 08:12

Jun 20 2023

20after4 added a comment to T15483: EditEngine: allow to Duplicate a Form.

This is a feature that was invaluable on wikimedia's use of phabricator, however, proliferation of a lot of forms can be troublesome / difficult to manage. Ideally the forms system could use some improvements to make things more manageable.

Jun 20 2023, 22:25 · Affects-Wikimedia
20after4 awarded T15483: EditEngine: allow to Duplicate a Form a Like token.
Jun 20 2023, 22:23 · Affects-Wikimedia
20after4 awarded rP478012cd463d: Add serious business string for defrocking a user (remove admin rights) a Mountain of Wealth token.
Jun 20 2023, 22:17
20after4 updated 20after4.
Jun 20 2023, 22:12
20after4 updated 20after4.
Jun 20 2023, 22:11
20after4 updated 20after4.
Jun 20 2023, 22:09
valerio.bozzolan added inline comments to D25118: Remarkup: make less internal links open in new tabs.
Jun 20 2023, 13:54
bekay added a comment to T15161: Internal resources should avoid to become external links, as default.

I think the current revision is a good compromise. The current behavior makes no sense from the perspective of modern UX patterns:

Jun 20 2023, 13:51 · User-valerio.bozzolan, Discussion Needed, Remarkup
bekay added inline comments to D25303: Implements a more informative hovercard for wiki documents.
Jun 20 2023, 13:29
valerio.bozzolan added inline comments to D25303: Implements a more informative hovercard for wiki documents.
Jun 20 2023, 13:16
bekay added inline comments to D25303: Implements a more informative hovercard for wiki documents.
Jun 20 2023, 13:15
speck added a comment to D25303: Implements a more informative hovercard for wiki documents.

Thank you for clarifying!

Jun 20 2023, 12:18
speck added inline comments to D25303: Implements a more informative hovercard for wiki documents.
Jun 20 2023, 12:18
valerio.bozzolan moved T15225: Conpherence: add a dedicated "Send" button (not just the Enter key) from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Jun 20 2023, 11:05 · Conpherence, Mobile, User-valerio.bozzolan, UX
valerio.bozzolan moved T15415: Notifications: Fix message "Notification server not enabled" from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Jun 20 2023, 11:04 · User-valerio.bozzolan, UX
valerio.bozzolan added a project to T15415: Notifications: Fix message "Notification server not enabled": User-valerio.bozzolan.
Jun 20 2023, 11:04 · User-valerio.bozzolan, UX
valerio.bozzolan added a comment to T15152: MFA: Avoid to having to wait a minute so often, for example right after login.

Thank you speck since you helped me a lot in clarifying the situation.

Jun 20 2023, 10:15 · User-valerio.bozzolan
valerio.bozzolan updated the task description for T15152: MFA: Avoid to having to wait a minute so often, for example right after login.
Jun 20 2023, 10:14 · User-valerio.bozzolan
valerio.bozzolan updated the name of F312403: Partial High Security Mode MOCKUP.png from "image.png" to "Partial High Security Mode MOCKUP.png".
Jun 20 2023, 10:09
valerio.bozzolan updated the name of F312401: Phorge High Security Mode after MFA.png from "image.png" to "Phorge High Security Mode after MFA.png".
Jun 20 2023, 09:47
valerio.bozzolan added a comment to T15152: MFA: Avoid to having to wait a minute so often, for example right after login.

Ah yeah please share that :) Premising I agree that losing the current token is a problem that can be fixed with "hey, prepare your token, 3, 2, 1, go!"

Jun 20 2023, 09:37 · User-valerio.bozzolan
valerio.bozzolan moved T15161: Internal resources should avoid to become external links, as default from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Jun 20 2023, 09:32 · User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan moved T15366: Archived Panels: are still visible from Dashboard from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Jun 20 2023, 09:32 · Dashboards, User-valerio.bozzolan
valerio.bozzolan lowered the priority of T15472: Support Open Graph protocol (at least in Maniphest) from Low to Wishlist.
Jun 20 2023, 09:31 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest
valerio.bozzolan claimed T15256: Diffusion file: add a way to copy permalink.
Jun 20 2023, 09:31 · User-valerio.bozzolan, Diffusion
valerio.bozzolan edited the content of Next Up.
Jun 20 2023, 09:28
valerio.bozzolan updated the answer details for Q63: Thin scrollbars on workboards in Firefox on Windows (Answer 79).
Jun 20 2023, 07:40
valerio.bozzolan updated the answer details for Q63: Thin scrollbars on workboards in Firefox on Windows (Answer 79).
Jun 20 2023, 07:40
valerio.bozzolan added Q63: Thin scrollbars on workboards in Firefox on Windows (Answer 79).
Jun 20 2023, 07:39
matmarex added a comment to Q63: Thin scrollbars on workboards in Firefox on Windows.

Oh, if your OS doesn't always show scrollbars, then I guess this wouldn't make a difference for you. There's probably an option somewhere to change that, if you wanted to test how it works for others. But this means that my proposed change shouldn't affect you either. :)

Jun 20 2023, 07:36
valerio.bozzolan updated the task description for T15041: Starmap.
Jun 20 2023, 07:36 · Phorge
valerio.bozzolan added a comment to Starmap.

@Cigaryno Probably we should wait a bit before mentioning T15131 here

Jun 20 2023, 07:36
valerio.bozzolan added a project to T15131: Add Workboards support for Differential: Discussion Needed.
Jun 20 2023, 07:35 · Clarification Needed, Differential, Workboard, User-Cigaryno
valerio.bozzolan renamed Next Up from | to Next Up.
Jun 20 2023, 07:26
valerio.bozzolan attached a referenced file: F310033: Screenshot from 2023-06-14 20-29-29.png.
Jun 20 2023, 07:24
valerio.bozzolan attached a referenced file: F310031: Screenshot from 2023-06-14 20-30-01.png.
Jun 20 2023, 07:24
valerio.bozzolan renamed Next Up from Next Up (since 2023 Week 24) to | .
Jun 20 2023, 07:24
valerio.bozzolan added a comment to Q63: Thin scrollbars on workboards in Firefox on Windows.

So probably as you can see, you are right that the operating system version is in use, but, in my operating system the bar is just awesome XD

Jun 20 2023, 07:13
valerio.bozzolan added a comment to Q63: Thin scrollbars on workboards in Firefox on Windows.

Firefox on GNU/Linux with KDE desktop environment:

Jun 20 2023, 07:12
valerio.bozzolan changed the visibility for F312337: firefox-linux-kde.gif.
Jun 20 2023, 07:11
valerio.bozzolan changed the visibility for F312338: firefox-chromium-kde.gif.
Jun 20 2023, 07:11
valerio.bozzolan updated Q63: Thin scrollbars on workboards in Firefox on Windows from Thin scrollbars on workboards in Firefox to Thin scrollbars on workboards in Firefox on Windows.
Jun 20 2023, 07:09
valerio.bozzolan renamed T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks from Support language highlighting for "GitHub Flavored Markdown" code blocks to Support language highlighting for GitHub+GitLab "Flavored Markdown" code blocks.
Jun 20 2023, 07:05 · Feature Requests, Remarkup
matmarex added a comment to Q63: Thin scrollbars on workboards in Firefox on Windows.

Firefox 115, Chromium 114, on Windows 10. Can you share screenshots from Firefox and Chromium on your device?

Jun 20 2023, 07:05
valerio.bozzolan awarded T15423: PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding a Manufacturing Defect? token.
Jun 20 2023, 06:56 · Diffusion, PHP 8 support
valerio.bozzolan added a member for Trusted Contributors: matmarex.
Jun 20 2023, 06:51
valerio.bozzolan added a comment to Q63: Thin scrollbars on workboards in Firefox on Windows.

I cannot reproduce this problem with Firefox 113 provided by my distribution. What version are you using?

Jun 20 2023, 06:50
valerio.bozzolan updated the summary of D25303: Implements a more informative hovercard for wiki documents.
Jun 20 2023, 06:46
bekay attached a referenced file: F311192: image.png.
Jun 20 2023, 06:46
bekay added a comment to D25303: Implements a more informative hovercard for wiki documents.
In D25303#8876, @speck wrote:

I like this idea. A few things I want to note

  1. Could you post a screenie for what the breadcrumb rendering appears as?
  2. Does the name of this new class follow other classes that extend the hierarchy? I’m guessing yes but just want to double-check.
  3. Maniphest tasks will render their primary Space (assuming non-default) as a prefix to the title. I think wiki docs should do similar.
  4. Do wiki docs have a description field?
Jun 20 2023, 06:45
bekay awarded Q63: Thin scrollbars on workboards in Firefox on Windows a Like token.
Jun 20 2023, 06:36
matmarex asked Q63: Thin scrollbars on workboards in Firefox on Windows.
Jun 20 2023, 05:33

Jun 19 2023

speck added a comment to T15152: MFA: Avoid to having to wait a minute so often, for example right after login.

I had discussed this with Evan previously and he gave a great explanation for why the current behavior exists, something he refers to as “spyglass attack”. I’d have to go back and review the explanation. What I recall the outcome being a few options, one of which was prompting the user that they are about to be promoted for MFA before issuing the challenge, to give the user time to prepare.

Jun 19 2023, 23:27 · User-valerio.bozzolan
speck accepted D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

Thanks - the behavior I was seeing I think mirrors your own but the error I was getting was more directly related which confused me. It seems using @ does not clear the previous error from its use? Bleh.

Jun 19 2023, 23:00
speck added a comment to T15470: Include user email address in Conduit output when query is run by admin.

I think updating the user script is a good idea if this functionality is needed.

Jun 19 2023, 22:56 · Conduit, Discussion Needed, Feature Requests
speck added a comment to D25303: Implements a more informative hovercard for wiki documents.

I like this idea. A few things I want to note

  1. Could you post a screenie for what the breadcrumb rendering appears as?
  2. Does the name of this new class follow other classes that extend the hierarchy? I’m guessing yes but just want to double-check.
  3. Maniphest tasks will render their primary Space (assuming non-default) as a prefix to the title. I think wiki docs should do similar.
  4. Do wiki docs have a description field?
Jun 19 2023, 22:55
speck added a comment to T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.

I wonder if there were plans to incorporate contact numbers with the prototype app for handling support (the name escapes me).

Jun 19 2023, 22:45 · Policy
aklapper added a comment to T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.

Eh, grep'ing the source, src/applications/metamta/engine/PhabricatorMailSMSEngine.php seems to be the only place reading those values.

Jun 19 2023, 21:12 · Policy
valerio.bozzolan awarded T15485: error when running arc liberate after deleting a source file a Yellow Medal token.
Jun 19 2023, 19:44 · Arcanist, Bug Reports
valerio.bozzolan added a project to T15485: error when running arc liberate after deleting a source file: Arcanist.
Jun 19 2023, 19:44 · Arcanist, Bug Reports
valerio.bozzolan awarded T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge a Yellow Medal token.
Jun 19 2023, 19:38 · Policy
valerio.bozzolan added a comment to T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.

Also, is it something shared to somebody? I think nope so I totally agree

Jun 19 2023, 19:37 · Policy
aklapper created T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.
Jun 19 2023, 18:06 · Policy
goddenrich created T15485: error when running arc liberate after deleting a source file.
Jun 19 2023, 16:11 · Arcanist, Bug Reports
aklapper added a comment to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
In D25300#8786, @Sten wrote:

IMHO we should just do a global replacement on all 'if (strlen(<someVar>)) and have done with it. I have done this on my phabricator copy to get it working.

Jun 19 2023, 15:01
valerio.bozzolan accepted D25304: Add resources/ssl/custom.pem to .gitignore.
Jun 19 2023, 14:33
Sten updated the diff for D25304: Add resources/ssl/custom.pem to .gitignore.

Agreed. The more often we specify the path, the more likely the reader will remember it.
Downside is we need to lose the path/to/ in order to keep lint happy.

Jun 19 2023, 14:09
Sten updated the diff for D25304: Add resources/ssl/custom.pem to .gitignore.

Agreed. The more often we specify the path, the more likely the reader will remember it.

Jun 19 2023, 14:06
valerio.bozzolan awarded D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php a Party Time token.
Jun 19 2023, 14:03
Sten closed D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 13:55
Sten committed rARC677e117b97fc: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php
Jun 19 2023, 13:55
valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.
In T15161#4416, @avivey wrote:

I agree with this, but I think we should let this wait for broader discussion - there maybe good counter-arguments.

Jun 19 2023, 13:30 · User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan updated the diff for D25118: Remarkup: make less internal links open in new tabs.

add dedicated CSS class

Jun 19 2023, 13:25
valerio.bozzolan updated the summary of D25118: Remarkup: make less internal links open in new tabs.
Jun 19 2023, 13:24
valerio.bozzolan added a comment to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

At this point, feel free to download the patch again and land it

Jun 19 2023, 13:06
aklapper closed T15456: Pholio: RuntimeException: Undefined variable $dictionary when adding an empty Inline Comment as Resolved by committing rP7c1487e4dcfa: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an….
Jun 19 2023, 12:13
aklapper closed D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).
Jun 19 2023, 12:13
aklapper committed rP7c1487e4dcfa: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an….
Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an…
Jun 19 2023, 12:13
aklapper added a comment to D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).

I've tested the new revision with the soft error and this is a way better UX - thanks!

Jun 19 2023, 12:13
valerio.bozzolan updated the diff for D25303: Implements a more informative hovercard for wiki documents.

Run tests again (since they are marked as skipped now)

Jun 19 2023, 11:59
valerio.bozzolan updated the summary of D25303: Implements a more informative hovercard for wiki documents.
Jun 19 2023, 11:57