User Details
User Details
- User Since
- Nov 25 2021, 15:28 (96 w, 6 d)
- Availability
- Available
Jun 19 2023
Jun 19 2023
valerio.bozzolan awarded T15485: error when running arc liberate after deleting a source file a Yellow Medal token.
Apr 24 2023
Apr 24 2023
goddenrich added inline comments to D25129: Fix PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php.
goddenrich added inline comments to D25129: Fix PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php.
Apr 20 2023
Apr 20 2023
goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled as Resolved by committing rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.
goddenrich committed rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow (authored by goddenrich).
Fix idx default empty string in ArcanistWorkflow
Apr 19 2023
Apr 19 2023
valerio.bozzolan awarded T15259: arc patch broken on php 8.2 when certificate is uninstalled a Grey Medal token.
goddenrich updated the summary of D25128: Fix idx default empty string in ArcanistWorkflow.
goddenrich requested review of D25128: Fix idx default empty string in ArcanistWorkflow.
goddenrich closed T15257: arc lint broken on php 8.2, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
goddenrich closed T15257: arc lint broken on php 8.2 as Resolved by committing rARC75af13abe917: Fix early exit from getMatchSeverity on null severity.
goddenrich committed rARC75af13abe917: Fix early exit from getMatchSeverity on null severity (authored by goddenrich).
Fix early exit from getMatchSeverity on null severity
goddenrich updated the diff for D25126: Fix early exit from getMatchSeverity on null severity.
addressing other possible nulls in this linter
goddenrich added inline comments to D25126: Fix early exit from getMatchSeverity on null severity.
goddenrich updated the diff for D25126: Fix early exit from getMatchSeverity on null severity.
oneliner
goddenrich added a comment to D25126: Fix early exit from getMatchSeverity on null severity.
looking at those failing test cases puppet-lint for my version puppet-lint 2.4.2 uses
goddenrich updated the diff for D25126: Fix early exit from getMatchSeverity on null severity.
use not isset instead
goddenrich added inline comments to D25126: Fix early exit from getMatchSeverity on null severity.
Apr 18 2023
Apr 18 2023
goddenrich requested review of D25126: Fix early exit from getMatchSeverity on null severity.
goddenrich added a comment to D25125: Update "how to file bugs".
do you think https://we.phorge.it/book/contrib/article/contributing_code/ needs updating too? I went there rather than to bug filing because I thought I would take a crack at raising a fix hence why I din't go down the bug report route
Sep 12 2022
Sep 12 2022
goddenrich closed Q15: Can you allow git fetching specific commits? as resolved.
goddenrich added a comment to Q15: Can you allow git fetching specific commits? (Answer 7).
Great that works perfectly thanks
Sep 5 2022
Sep 5 2022
goddenrich added a comment to Q15: Can you allow git fetching specific commits?.
The specific set of commands im looking at are
mkdir -p phabricator_git_repo && cd phabricator_git_repo && git init && git remote add origin https://we.phorge.it/source/phorge.git && git fetch origin b11c6fcacd8bceafc2a2f223037952dc817f4d7f && git reset --hard FETCH_HEAD && rm -rf .git && true
this commit does exist https://we.phorge.it/rPb11c6fcacd8bceafc2a2f223037952dc817f4d7f
we use a build system which fetches the code from a git repo and makes it available to the next stage of the build
Nov 25 2021
Nov 25 2021
goddenrich added a comment to T15045: Support SSL/TLS for MariaDB connections.
Is there an update on this? we would love to see this feature soon