Page MenuHomePhorge

goddenrich (Richard Godden)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 25 2021, 15:28 (124 w, 4 d)
Availability
Available

Recent Activity

Jun 19 2023

valerio.bozzolan awarded T15485: error when running arc liberate after deleting a source file a Yellow Medal token.
Jun 19 2023, 19:44 · Arcanist, Bug Reports
goddenrich created T15485: error when running arc liberate after deleting a source file.
Jun 19 2023, 16:11 · Arcanist, Bug Reports

Apr 24 2023

goddenrich added inline comments to D25129: Fix PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php.
Apr 24 2023, 11:08
goddenrich added inline comments to D25129: Fix PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php.
Apr 24 2023, 11:06

Apr 20 2023

goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Apr 20 2023, 10:18 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich closed D25128: Fix idx default empty string in ArcanistWorkflow.
Apr 20 2023, 10:18
goddenrich closed T15259: arc patch broken on php 8.2 when certificate is uninstalled as Resolved by committing rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.
Apr 20 2023, 10:18 · PHP 8 support, Arcanist
goddenrich committed rARCca5f5cd1522c: Fix idx default empty string in ArcanistWorkflow.
Fix idx default empty string in ArcanistWorkflow
Apr 20 2023, 10:18

Apr 19 2023

valerio.bozzolan awarded T15259: arc patch broken on php 8.2 when certificate is uninstalled a Grey Medal token.
Apr 19 2023, 20:27 · PHP 8 support, Arcanist
goddenrich added a revision to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: D25128: Fix idx default empty string in ArcanistWorkflow.
Apr 19 2023, 17:12 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich updated the summary of D25128: Fix idx default empty string in ArcanistWorkflow.
Apr 19 2023, 17:12
goddenrich added a task to D25128: Fix idx default empty string in ArcanistWorkflow: T15259: arc patch broken on php 8.2 when certificate is uninstalled.
Apr 19 2023, 17:09
goddenrich added a revision to T15259: arc patch broken on php 8.2 when certificate is uninstalled: D25128: Fix idx default empty string in ArcanistWorkflow.
Apr 19 2023, 17:09 · PHP 8 support, Arcanist
goddenrich requested review of D25128: Fix idx default empty string in ArcanistWorkflow.
Apr 19 2023, 17:09
goddenrich added a subtask for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15259: arc patch broken on php 8.2 when certificate is uninstalled.
Apr 19 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich added a parent task for T15259: arc patch broken on php 8.2 when certificate is uninstalled: T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 19 2023, 17:06 · PHP 8 support, Arcanist
goddenrich created T15259: arc patch broken on php 8.2 when certificate is uninstalled.
Apr 19 2023, 17:05 · PHP 8 support, Arcanist
goddenrich closed T15257: arc lint broken on php 8.2, a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
Apr 19 2023, 16:21 · PHP 8 support, Arcanist, User-valerio.bozzolan
goddenrich closed T15257: arc lint broken on php 8.2 as Resolved by committing rARC75af13abe917: Fix early exit from getMatchSeverity on null severity.
Apr 19 2023, 16:21 · PHP 8 support, Arcanist
goddenrich closed D25126: Fix early exit from getMatchSeverity on null severity.
Apr 19 2023, 16:21
goddenrich committed rARC75af13abe917: Fix early exit from getMatchSeverity on null severity.
Fix early exit from getMatchSeverity on null severity
Apr 19 2023, 16:21
goddenrich updated the diff for D25126: Fix early exit from getMatchSeverity on null severity.

addressing other possible nulls in this linter

Apr 19 2023, 11:58
goddenrich added inline comments to D25126: Fix early exit from getMatchSeverity on null severity.
Apr 19 2023, 11:48
goddenrich updated the diff for D25126: Fix early exit from getMatchSeverity on null severity.

oneliner

Apr 19 2023, 11:47
goddenrich added a comment to D25126: Fix early exit from getMatchSeverity on null severity.

looking at those failing test cases puppet-lint for my version puppet-lint 2.4.2 uses

Apr 19 2023, 10:47
goddenrich updated the diff for D25126: Fix early exit from getMatchSeverity on null severity.

use not isset instead

Apr 19 2023, 09:48
goddenrich added inline comments to D25126: Fix early exit from getMatchSeverity on null severity.
Apr 19 2023, 09:38

Apr 18 2023

goddenrich added a task to D25126: Fix early exit from getMatchSeverity on null severity: T15257: arc lint broken on php 8.2.
Apr 18 2023, 18:02
goddenrich added a revision to T15257: arc lint broken on php 8.2: D25126: Fix early exit from getMatchSeverity on null severity.
Apr 18 2023, 18:02 · PHP 8 support, Arcanist
goddenrich requested review of D25126: Fix early exit from getMatchSeverity on null severity.
Apr 18 2023, 17:56
goddenrich added a comment to D25125: Update "how to file bugs".

do you think https://we.phorge.it/book/contrib/article/contributing_code/ needs updating too? I went there rather than to bug filing because I thought I would take a crack at raising a fix hence why I din't go down the bug report route

Apr 18 2023, 15:27

Sep 12 2022

goddenrich closed Q15: Can you allow git fetching specific commits? as resolved.
Sep 12 2022, 17:24
goddenrich added a comment to Q15: Can you allow git fetching specific commits? (Answer 7).

Great that works perfectly thanks

Sep 12 2022, 10:36

Sep 5 2022

goddenrich added a comment to Q15: Can you allow git fetching specific commits?.

The specific set of commands im looking at are

mkdir -p phabricator_git_repo && cd phabricator_git_repo && git init && git remote add origin https://we.phorge.it/source/phorge.git && git fetch origin b11c6fcacd8bceafc2a2f223037952dc817f4d7f && git reset --hard FETCH_HEAD && rm -rf .git && true

this commit does exist https://we.phorge.it/rPb11c6fcacd8bceafc2a2f223037952dc817f4d7f
we use a build system which fetches the code from a git repo and makes it available to the next stage of the build

Sep 5 2022, 15:05
goddenrich asked Q15: Can you allow git fetching specific commits?.
Sep 5 2022, 12:33

Nov 25 2021

goddenrich added a comment to T15045: Support SSL/TLS for MariaDB connections.

Is there an update on this? we would love to see this feature soon

Nov 25 2021, 15:29 · Security