Page MenuHomePhorge

Fix UX regression in Dashboard Tabs Panel
ClosedPublic

Authored by valerio.bozzolan on Jun 12 2023, 14:22.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 21, 17:49
Unknown Object (File)
Tue, Jul 16, 18:50
Unknown Object (File)
Mon, Jul 15, 15:36
Unknown Object (File)
Sun, Jul 14, 03:06
Unknown Object (File)
Sat, Jul 13, 13:03
Unknown Object (File)
Thu, Jul 11, 08:41
Unknown Object (File)
Wed, Jul 10, 06:10
Unknown Object (File)
Tue, Jul 9, 17:50

Details

Summary

Before this change, it seems that the Dashboard Tabs Panel could be empty
as default. This was the regression:

cbc0e661544a31290099ab3d88481bb8d4a3003c

The variable $is_selected was defined inside a foreach loop, but that loop
was terminated when it was then read again. This redefines that variable in
the right scope.

BeforeAfter
Before D25291.png (596×591 px, 31 KB)
After D25291.png (596×591 px, 25 KB)

Closes T15474

Test Plan
  • see that now you have something visibile in your Dashboard Tabs Panel

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

put the change nearby the problem

valerio.bozzolan added inline comments.
src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
114

Note this, that just lives inside the above loop. So it needs to be re-defined in the below loop.

Premising that I would like to see this comparison logic to be in a separate static method, but honestly it would just be an equality, so we can just have a green light for this copy-pasta.

I double-checked and I'm quite sure that this fixes the issue reported by the kind @speck

No worries, I haven’t had time to dig in. I wanted to review D25067

This revision is now accepted and ready to land.Jun 26 2023, 23:44