Thank you Rector.php for making this repository even more performant,
recent and readable. I also donated 15€ to Rector.php since I was really
impressed by its potential.

God bless Rector.php. I love you Rector.php. Thank you Rector.php. Such wow.

Ref T15158

Test Plan

I checked every single line with my big eyes
matrioska test: I hot-used my Arcanist to run arc diff and it worked

Diff Detail

Repository

rARC Arcanist

Branch

T15158-modernize-dirname

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 129
Build 129: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	4,914 ms	ArcanistCoffeeLintLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "no_trailing_whitespace.lint-test". MISSING MESSAGES Message with severity "error" at "1:0"
	101 ms	ArcanistCppcheckLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "zblair.lint-test". MISSING MESSAGES Message with severity "error" at "10:<null>"
	254 ms	ArcanistCpplintLinterTestCase::testLinter Assertion failed, expected values to be equal (at ArcanistLinterTestCase.php:180): Some linters failed: - CommandException: Command failed with error #1! COMMAND
	2,544 ms	ArcanistJSHintLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "too-many-errors.lint-test". MISSING MESSAGES Message with severity "disabled" at "2:22" (E043)
	1,127 ms	ArcanistJscsLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "curly-brace.lint-test". MISSING MESSAGES Message with severity "error" at "2:3"
		View Full Test Results (7 Failed · 256 Passed · 17 Skipped)

Event Timeline

valerio.bozzolan created this revision.Mar 11 2023, 21:33

Owners added a reviewer: O1: Blessed Committers.Mar 11 2023, 21:33

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 11 2023, 21:33

valerio.bozzolan requested review of this revision.Mar 11 2023, 21:33

Harbormaster completed remote builds in B128: Diff 335.Mar 11 2023, 21:33

NOTE: I spent 4 hours to fight with the lints, to then realize with maximum certitude that the linters are simply broken, on outdated pieces of software, blessed by dead Gods, and their errors have nothing to do with my life on this planet.

valerio.bozzolan mentioned this in T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum).Mar 11 2023, 21:38

valerio.bozzolan retitled this revision from Replace dirname(__FILE__) with __DIR__ (available since PHP 5.5 - yeah!) to Replace dirname(__FILE__) with __DIR__ (available since PHP 5.3- yeah!).

try to fix lint again - but I don't hope for it

Harbormaster completed remote builds in B129: Diff 336.Mar 11 2023, 21:41

valerio.bozzolan retitled this revision from Replace dirname(__FILE__) with __DIR__ (available since PHP 5.3- yeah!) to Replace dirname(__FILE__) with __DIR__ (available since PHP 5.3).Mar 11 2023, 21:48

Replace dirname(__FILE__) with __DIR__ (available since PHP 5.3)AbandonedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 336

scripts/__init_script__.php

scripts/arcanist.php

scripts/hgdaemon/hgdaemon_client.php

scripts/hgdaemon/hgdaemon_server.php

src/__phutil_library_init__.php

src/console/__tests__/PhutilConsoleWrapTestCase.php

src/filesystem/__tests__/FileFinderTestCase.php

src/filesystem/__tests__/FilesystemTestCase.php

src/filesystem/memory/__tests__/ArcanistHostMemorySnapshotTestCase.php

src/init/init-library.php

src/lexer/__tests__/PhutilPHPFragmentLexerTestCase.php

src/lexer/__tests__/PhutilShellLexerTestCase.php

src/lint/linter/__tests__/ArcanistCSSLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistChmodLinterTestCase.php

src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php

src/lint/linter/__tests__/ArcanistCoffeeLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistCppcheckLinterTestCase.php

src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php

src/lint/linter/__tests__/ArcanistFilenameLinterTestCase.php

src/lint/linter/__tests__/ArcanistFlake8LinterTestCase.php

src/lint/linter/__tests__/ArcanistGeneratedLinterTestCase.php

src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistHLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistJSHintLinterTestCase.php

src/lint/linter/__tests__/ArcanistJSONLinterTestCase.php

src/lint/linter/__tests__/ArcanistJscsLinterTestCase.php

src/lint/linter/__tests__/ArcanistLesscLinterTestCase.php

src/lint/linter/__tests__/ArcanistMergeConflictLinterTestCase.php

src/lint/linter/__tests__/ArcanistNoLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistPEP8LinterTestCase.php

src/lint/linter/__tests__/ArcanistPhpLinterTestCase.php

src/lint/linter/__tests__/ArcanistPhpcsLinterTestCase.php

src/lint/linter/__tests__/ArcanistPuppetLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistPyFlakesLinterTestCase.php

src/lint/linter/__tests__/ArcanistPyLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistRuboCopLinterTestCase.php

src/lint/linter/__tests__/ArcanistRubyLinterTestCase.php

src/lint/linter/__tests__/ArcanistSpellingLinterTestCase.php

src/lint/linter/__tests__/ArcanistTextLinterTestCase.php

src/lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php

src/lint/linter/__tests__/ArcanistXMLLinterTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistAliasFunctionXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayCombineXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayIndexSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistArraySeparatorXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistArrayValueXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistBinaryExpressionSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistBinaryNumericScalarCasingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistBlacklistedFunctionXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistBraceFormattingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistCallParenthesesXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistCallTimePassByReferenceXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistCastSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistClassExtendsObjectXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistClassNameLiteralXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistCommentStyleXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistConcatenationOperatorXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistConstructorParenthesesXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistControlStatementSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistDeclarationParenthesesXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistDefaultParametersXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistDeprecationXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistDoubleQuoteXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistDuplicateKeysInArrayXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistDuplicateSwitchCaseXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistDynamicDefineXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistEachUseXHPASTLinterRuleTestCase.php

Replace dirname(FILE) with DIR (available since PHP 5.3)
AbandonedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List

src/console/tests/PhutilConsoleWrapTestCase.php

src/filesystem/tests/FileFinderTestCase.php

src/filesystem/tests/FilesystemTestCase.php

src/filesystem/memory/tests/ArcanistHostMemorySnapshotTestCase.php

src/lexer/tests/PhutilPHPFragmentLexerTestCase.php

src/lexer/tests/PhutilShellLexerTestCase.php

src/lint/linter/tests/ArcanistCSSLintLinterTestCase.php

src/lint/linter/tests/ArcanistChmodLinterTestCase.php

src/lint/linter/tests/ArcanistClosureLinterTestCase.php

src/lint/linter/tests/ArcanistCoffeeLintLinterTestCase.php

src/lint/linter/tests/ArcanistCppcheckLinterTestCase.php

src/lint/linter/tests/ArcanistCpplintLinterTestCase.php

src/lint/linter/tests/ArcanistFilenameLinterTestCase.php

src/lint/linter/tests/ArcanistFlake8LinterTestCase.php

src/lint/linter/tests/ArcanistGeneratedLinterTestCase.php

src/lint/linter/tests/ArcanistGoLintLinterTestCase.php

src/lint/linter/tests/ArcanistHLintLinterTestCase.php

src/lint/linter/tests/ArcanistJSHintLinterTestCase.php

src/lint/linter/tests/ArcanistJSONLinterTestCase.php

src/lint/linter/tests/ArcanistJscsLinterTestCase.php

src/lint/linter/tests/ArcanistLesscLinterTestCase.php

src/lint/linter/tests/ArcanistMergeConflictLinterTestCase.php

src/lint/linter/tests/ArcanistNoLintLinterTestCase.php

src/lint/linter/tests/ArcanistPEP8LinterTestCase.php

src/lint/linter/tests/ArcanistPhpLinterTestCase.php

src/lint/linter/tests/ArcanistPhpcsLinterTestCase.php

src/lint/linter/tests/ArcanistPuppetLintLinterTestCase.php

src/lint/linter/tests/ArcanistPyFlakesLinterTestCase.php

src/lint/linter/tests/ArcanistPyLintLinterTestCase.php

src/lint/linter/tests/ArcanistRuboCopLinterTestCase.php

src/lint/linter/tests/ArcanistRubyLinterTestCase.php

src/lint/linter/tests/ArcanistSpellingLinterTestCase.php

src/lint/linter/tests/ArcanistTextLinterTestCase.php

src/lint/linter/tests/ArcanistXHPASTLinterTestCase.php

src/lint/linter/tests/ArcanistXMLLinterTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistAliasFunctionXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistArrayCombineXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistArrayIndexSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistArraySeparatorXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistArrayValueXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistBinaryExpressionSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistBinaryNumericScalarCasingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistBlacklistedFunctionXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistBraceFormattingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistCallParenthesesXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistCallTimePassByReferenceXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistCastSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistClassExtendsObjectXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistClassNameLiteralXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistCommentStyleXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistConcatenationOperatorXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistConstructorParenthesesXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistControlStatementSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistDeclarationParenthesesXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistDefaultParametersXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistDeprecationXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistDoubleQuoteXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistDuplicateKeysInArrayXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistDuplicateSwitchCaseXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistDynamicDefineXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistEachUseXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistElseIfUsageXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistEmptyStatementXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistExitExpressionXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistExtractUseXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistFormattedStringXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistGlobalVariableXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistHexadecimalNumericScalarCasingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistImplicitConstructorXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistImplicitFallthroughXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistImplicitVisibilityXHPASTLinterRuleTestCase.php