custom.pem to .gitignore
ClosedPublic
Actions

Authored by Sten on Jun 19 2023, 10:59.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC8130241a11ac: Add resources/ssl/custom.pem to .gitignore

Summary

When arcanist connects to a phorge site which uses an SSL certificate signed by a local CA, then the client needs to have a resources/ssl/custom.pem file as per resources/ssl/README

As this is client specific it should be in the .gitignore file.

Also update resources/ssl/README to replace [Pp]habricator with [Pp]horge.

Test Plan

touch resources/ssl/custom.pem
git status

The 'git status' should show no changes.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Jun 19 2023, 10:59

Owners added a reviewer: O1: Blessed Committers.Jun 19 2023, 10:59

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJun 19 2023, 10:59

Sten requested review of this revision.Jun 19 2023, 10:59

Harbormaster completed remote builds in B580: Diff 992.Jun 19 2023, 10:59

Thanks :)

This seems very legit to me. As additional context, in my local installation I have not that file:

tree resources/ssl/
resources/ssl/
├── default.pem
├── default.pem.rej
└── README

0 directories, 3 files

Tested locally. No nuclear implosions :D

lgtm

This revision is now accepted and ready to land.Jun 19 2023, 11:43

valerio.bozzolan added inline comments.Jun 19 2023, 11:44

resources/ssl/README
39	I wonder if the example should mention `path/to/arcanist/resources/ssl/custom.pem`

Agreed. The more often we specify the path, the more likely the reader will remember it.

Harbormaster completed remote builds in B583: Diff 997.Jun 19 2023, 14:05

Agreed. The more often we specify the path, the more likely the reader will remember it.
Downside is we need to lose the path/to/ in order to keep lint happy.

Harbormaster completed remote builds in B584: Diff 998.Jun 19 2023, 14:09

Sten marked an inline comment as done.Jun 19 2023, 14:09

valerio.bozzolan accepted this revision.Jun 19 2023, 14:33

Hi @Sten also here feel free to