Page MenuHomePhorge

Notifications: Fix message "Notification server not enabled"
Closed, ResolvedPublic

Description

There is probably something in HTML/CSS that could be improved in the "Notification server not enabled" case.

At the moment it seems like the message is floating over another icon on the "N" letter:

CurrentExpected
Phorge notification server not enabled Before.png (35ร—360 px, 2 KB)
Phorge notification server not enabled After.png (35ร—360 px, 2 KB)

Also when "Connecting" the icon could be adjusted a bit:

CurrentExpected
Phorge notification connecting Before.png (35ร—360 px, 1 KB)
Phorge notification connecting After.png (35ร—360 px, 1 KB)

The visual problem seems caused by this HTML structure:

<span class="connection-status-text aphlict-connection-status-notenabled">
  <span class="visual-only phui-icon-view phui-font-fa fa-circle-o grey" data-meta="2_40" aria-hidden="true"></span>
  Notification server not enabled
</span>

To fix the graphic, this structure is needed instead:

<span class="visual-only phui-icon-view phui-font-fa fa-circle-o grey" data-meta="2_40" aria-hidden="true"></span>
<span class="connection-status-text aphlict-connection-status-notenabled">Notification server not enabled</span>

All the other messages are OK as-is and should not be touched.

In fact, this is the green icon when connected, that is already OK:

<span class="phui-icon-view phui-font-fa fa-circle green"></span>
<span class="connection-status-text aphlict-connection-status-open">Connected</span>

Related Objects

Event Timeline

valerio.bozzolan renamed this task from Notification server not enabled to CSS: Fix message "Notification server not enabled".May 24 2023, 06:47
valerio.bozzolan triaged this task as Low priority.
valerio.bozzolan renamed this task from CSS: Fix message "Notification server not enabled" to Notifications: Fix message "Notification server not enabled".Jun 26 2023, 19:42
valerio.bozzolan claimed this task.
valerio.bozzolan updated the task description. (Show Details)