Page MenuHomePhorge
Feed All Stories

Jun 19 2023

valerio.bozzolan added a comment to D25303: Implements a more informative hovercard for wiki documents.

Feel free to replace the screenshot with something else ihih

Jun 19 2023, 11:55
valerio.bozzolan updated the summary of D25303: Implements a more informative hovercard for wiki documents.
Jun 19 2023, 11:54
valerio.bozzolan added inline comments to D25304: Add resources/ssl/custom.pem to .gitignore.
Jun 19 2023, 11:44
valerio.bozzolan accepted D25304: Add resources/ssl/custom.pem to .gitignore.

This seems very legit to me. As additional context, in my local installation I have not that file:

Jun 19 2023, 11:43
aklapper placed T15470: Include user email address in Conduit output when query is run by admin up for grabs.
Jun 19 2023, 11:39 · Conduit, Discussion Needed, Feature Requests
aklapper closed T15470: Include user email address in Conduit output when query is run by admin as Wontfix.

Then let's decline this ticket to reflect the status.

Jun 19 2023, 11:39 · Conduit, Discussion Needed, Feature Requests
Sten requested review of D25304: Add resources/ssl/custom.pem to .gitignore.
Jun 19 2023, 10:59
valerio.bozzolan claimed T15474: Dashboard Tabs is not open anymore as default at startup.
Jun 19 2023, 10:27 · Affects-Wikimedia, User-valerio.bozzolan, Dashboards, Bug Reports
valerio.bozzolan added projects to T15366: Archived Panels: are still visible from Dashboard: User-valerio.bozzolan, Dashboards.
Jun 19 2023, 10:26 · Dashboards, User-valerio.bozzolan
valerio.bozzolan added a project to T15229: Customize query for Projects in Dashboard returns 404: Dashboards.
Jun 19 2023, 10:26 · Dashboards, Bug Reports
valerio.bozzolan added a project to T15438: Add policy capability "Can create Dashboards": Dashboards.
Jun 19 2023, 10:26 · Dashboards, Policy
valerio.bozzolan added projects to T15474: Dashboard Tabs is not open anymore as default at startup: Dashboards, User-valerio.bozzolan.
Jun 19 2023, 10:25 · Affects-Wikimedia, User-valerio.bozzolan, Dashboards, Bug Reports
valerio.bozzolan added a project to T15146: Dashboards: Tab panel sometimes displays the content of two tabs: Dashboards.

Premising that now we have a regression here :D

Jun 19 2023, 10:25 · Dashboards, Bug Reports
valerio.bozzolan added a parent task for T15474: Dashboard Tabs is not open anymore as default at startup: T15146: Dashboards: Tab panel sometimes displays the content of two tabs.
Jun 19 2023, 10:25 · Affects-Wikimedia, User-valerio.bozzolan, Dashboards, Bug Reports
valerio.bozzolan added a subtask for T15146: Dashboards: Tab panel sometimes displays the content of two tabs: T15474: Dashboard Tabs is not open anymore as default at startup.
Jun 19 2023, 10:25 · Dashboards, Bug Reports
valerio.bozzolan added a task to D25291: Fix UX regression in Dashboard Tabs Panel: T15146: Dashboards: Tab panel sometimes displays the content of two tabs.
Jun 19 2023, 10:24
valerio.bozzolan added a revision to T15146: Dashboards: Tab panel sometimes displays the content of two tabs: D25291: Fix UX regression in Dashboard Tabs Panel.
Jun 19 2023, 10:24 · Dashboards, Bug Reports
valerio.bozzolan renamed Dashboards from Dashboard to Dashboards.
Jun 19 2023, 10:23
valerio.bozzolan edited Description on Dashboards (archived).
Jun 19 2023, 10:23
valerio.bozzolan created Dashboards.
Jun 19 2023, 10:23
valerio.bozzolan edited the content of Next Up.
Jun 19 2023, 10:17
aklapper closed D25270: Dashboards: add capability who can create Dashboards.
Jun 19 2023, 10:12
aklapper closed T15438: Add policy capability "Can create Dashboards" as Resolved by committing rP1c59b6542136: Dashboards: add capability who can create Dashboards.
Jun 19 2023, 10:12 · Dashboards, Policy
aklapper committed rP1c59b6542136: Dashboards: add capability who can create Dashboards.
Dashboards: add capability who can create Dashboards
Jun 19 2023, 10:12
aklapper updated the diff for D25270: Dashboards: add capability who can create Dashboards.

fix capitalization

Jun 19 2023, 10:11
valerio.bozzolan updated the task description for T15224: Mobile hamburger menu in User Profile page contains only useless stuff.
Jun 19 2023, 10:03 · User-valerio.bozzolan, People, User-Cigaryno, Mobile
valerio.bozzolan updated the name of F311948: People desktop menu.png from "Screenshot_2023_06_19_120248.png" to "People desktop menu.png".
Jun 19 2023, 10:03
aklapper closed T15473: Give embedded image files with transparency (alpha channel) a checkered background as Resolved by committing rP324470e39b0d: Give embedded image files with transparency a checkered background.
Jun 19 2023, 09:57
aklapper closed D25294: Give embedded image files with transparency a checkered background.
Jun 19 2023, 09:57
aklapper committed rP324470e39b0d: Give embedded image files with transparency a checkered background.
Give embedded image files with transparency a checkered background
Jun 19 2023, 09:57
aklapper updated the diff for D25294: Give embedded image files with transparency a checkered background.

rebase

Jun 19 2023, 09:55
valerio.bozzolan accepted D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

Thanks! :) Tested. No nuclear implosions.

Jun 19 2023, 08:39
valerio.bozzolan added a revision to T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 08:39 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the summary of D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 08:39
valerio.bozzolan updated the summary of D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 08:38
Sten updated the test plan for D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 08:36
Sten updated the diff for D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

Agreed - tighter check is better, and does fix the issue.

Jun 19 2023, 08:35
bekay added a comment to D25303: Implements a more informative hovercard for wiki documents.

I wonder if other Hovercards have a quantitative limitation on things like Tags, to be used as additional inspiration

Jun 19 2023, 07:57
valerio.bozzolan added a comment to D25303: Implements a more informative hovercard for wiki documents.

I wonder if other Hovercards have a quantitative limitation on things like Tags, to be used as additional inspiration

Jun 19 2023, 07:45
valerio.bozzolan added a comment to D25303: Implements a more informative hovercard for wiki documents.

I like it:

Jun 19 2023, 07:43
valerio.bozzolan updated the name of F311936: D25303 2023-06-19 proposal.png from "image.png" to "D25303 2023-06-19 proposal.png".
Jun 19 2023, 07:41
bekay updated the diff for D25303: Implements a more informative hovercard for wiki documents.

Small style changes.

Jun 19 2023, 07:35
valerio.bozzolan added a project to T15411: Clarify what the timezone is (not obvious to newcomers): User-valerio.bozzolan.
Jun 19 2023, 07:30 · User-valerio.bozzolan, UX, Calendar
valerio.bozzolan added a project to T15484: Conduit project.column.search: missing isHidden, isDefaultColumn, sequence: Conduit.
Jun 19 2023, 07:28 · Conduit, Affects-Wikimedia
valerio.bozzolan added a project to T15470: Include user email address in Conduit output when query is run by admin: Conduit.
Jun 19 2023, 07:28 · Conduit, Discussion Needed, Feature Requests
valerio.bozzolan added a project to T15144: Conduit transaction.search: Missing "Constraint" section in the documentation: Conduit.
Jun 19 2023, 07:28 · Conduit, User-valerio.bozzolan
valerio.bozzolan added a project to T15482: Conduit method for Legalpad signatures: Conduit.
Jun 19 2023, 07:28 · Legalpad, Conduit, Affects-Wikimedia
valerio.bozzolan added a project to T15141: Show a summary on the top of each Conduit API page: Conduit.

(Re-adding Conduit as a non-subproject Tag since we have 5-6 tasks about it)

Jun 19 2023, 07:28 · Conduit, User-valerio.bozzolan
valerio.bozzolan added a project to T15107: Conduit does cannot sign requests using the almanac private key: Conduit.

(Re-adding Conduit as a non-subproject Tag since we have 5-6 tasks about it)

Jun 19 2023, 07:28 · Conduit, Almanac/Drydock/Harbormaster
valerio.bozzolan created Conduit.
Jun 19 2023, 07:26
valerio.bozzolan set the color for Deprecated Conduit to Red.
Jun 19 2023, 07:26
valerio.bozzolan renamed Deprecated Conduit from Conduit to Deprecated Conduit.
Jun 19 2023, 07:25
valerio.bozzolan edited the content of Next Up.
Jun 19 2023, 07:02
valerio.bozzolan reassigned T15484: Conduit project.column.search: missing isHidden, isDefaultColumn, sequence from valerio.bozzolan to 20after4.
Jun 19 2023, 07:01 · Conduit, Affects-Wikimedia
valerio.bozzolan closed T15484: Conduit project.column.search: missing isHidden, isDefaultColumn, sequence, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Jun 19 2023, 06:59 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan closed D25038: Conduit column.search: add status, sequence and isDefault to API results.
Jun 19 2023, 06:59
valerio.bozzolan closed T15484: Conduit project.column.search: missing isHidden, isDefaultColumn, sequence as Resolved by committing rP327ac921c28b: Conduit column.search: add status, sequence and isDefault to API results.
Jun 19 2023, 06:59 · Conduit, Affects-Wikimedia
valerio.bozzolan committed rP327ac921c28b: Conduit column.search: add status, sequence and isDefault to API results (authored by 20after4).
Conduit column.search: add status, sequence and isDefault to API results
Jun 19 2023, 06:59
valerio.bozzolan updated the diff for D25038: Conduit column.search: add status, sequence and isDefault to API results.
git rebase master
Jun 19 2023, 06:58
avivey added a comment to T15470: Include user email address in Conduit output when query is run by admin.

(I'm against this, but I don't have the time to go into details right now. I suggest a CLI tool (like ./bin/user) to expose this information).

Jun 19 2023, 06:44 · Conduit, Discussion Needed, Feature Requests
valerio.bozzolan updated subscribers of T15484: Conduit project.column.search: missing isHidden, isDefaultColumn, sequence.

Thanks again @20after4 for the original idea online on Wikimedia since October 2021

Jun 19 2023, 06:43 · Conduit, Affects-Wikimedia
valerio.bozzolan added a revision to T15484: Conduit project.column.search: missing isHidden, isDefaultColumn, sequence: D25038: Conduit column.search: add status, sequence and isDefault to API results.
Jun 19 2023, 06:43 · Conduit, Affects-Wikimedia
valerio.bozzolan updated the summary of D25038: Conduit column.search: add status, sequence and isDefault to API results.
Jun 19 2023, 06:43
valerio.bozzolan triaged T15484: Conduit project.column.search: missing isHidden, isDefaultColumn, sequence as Wishlist priority.
Jun 19 2023, 06:41 · Conduit, Affects-Wikimedia
valerio.bozzolan added a comment to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

Last comment from me (promise): can you share at least a cute stack trace? You can easily copy that using this argument:

Jun 19 2023, 06:21
valerio.bozzolan added inline comments to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 19 2023, 06:07

Jun 18 2023

Sten added a comment to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

It is 'arc unit' which doesn't work for us without this patch under PHP 8.1. We are using a version of ArcanistUnitTestEngine extended to handle multiple languages in a single repo, and I unfortunately cannot share this. I'm not sure what more you want - we have a unit test demonstrating strlen() is being used against a variable which can be null.

Jun 18 2023, 11:01

Jun 17 2023

valerio.bozzolan updated the summary of D25301: Diffusion: add "Permalink" button.
Jun 17 2023, 22:17
valerio.bozzolan updated the name of F311315: Diffusion after D25301 highlighted with GIMP green peppers.png from "Diffusion after D25301.png" to "Diffusion after D25301 highlighted with GIMP green peppers.png".
Jun 17 2023, 22:16
valerio.bozzolan updated the task description for T15256: Diffusion file: add a way to copy permalink.
Jun 17 2023, 22:16 · User-valerio.bozzolan, Diffusion
valerio.bozzolan updated the diff for D25303: Implements a more informative hovercard for wiki documents.
arc liberate
Jun 17 2023, 21:55
valerio.bozzolan updated the diff for D25303: Implements a more informative hovercard for wiki documents.
./bin/celerity map
Jun 17 2023, 21:54
valerio.bozzolan accepted D25303: Implements a more informative hovercard for wiki documents.

I like this proposal :) soft +1 to allow other people to share a comment. Here how it renders:

Jun 17 2023, 21:52
valerio.bozzolan updated the name of F311301: Phriction Hovercard proposal.png from "image.png" to "Phriction Hovercard proposal.png".
Jun 17 2023, 21:49
valerio.bozzolan updated the task description for T15433: Hovercard of wiki article needs more information.
Jun 17 2023, 21:47
valerio.bozzolan updated the name of F311299: Project Hovercard.png from "image.png" to "Project Hovercard.png".
Jun 17 2023, 21:47
valerio.bozzolan updated the task description for T15433: Hovercard of wiki article needs more information.
Jun 17 2023, 21:41
valerio.bozzolan updated the name of F311294: Task Hovercard.png from "image.png" to "Task Hovercard.png".
Jun 17 2023, 21:38
valerio.bozzolan added a comment to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

Thanks for the unit test 👍

Jun 17 2023, 21:28
bekay requested review of D25303: Implements a more informative hovercard for wiki documents.
Jun 17 2023, 17:28
bekay added a revision to T15433: Hovercard of wiki article needs more information: D25303: Implements a more informative hovercard for wiki documents.
Jun 17 2023, 17:28
mturdus closed Q62: Extension: how to use PhabricatorFile::newFromFileData() as resolved.
Jun 17 2023, 16:48 · Files
valerio.bozzolan added a project to T15470: Include user email address in Conduit output when query is run by admin: Discussion Needed.
Jun 17 2023, 16:37 · Conduit, Discussion Needed, Feature Requests
valerio.bozzolan added a comment to T15470: Include user email address in Conduit output when query is run by admin.

Yep indeed. I just mentioned MediaWiki to talk about a similar situation, where being a "sysop" does not necessarily mean being a sysadmin with CLI / root access.

Jun 17 2023, 16:37 · Conduit, Discussion Needed, Feature Requests
valerio.bozzolan added a comment to T15433: Hovercard of wiki article needs more information.

So lovely!

Jun 17 2023, 16:34
bekay added a comment to T15433: Hovercard of wiki article needs more information.

Okay, this would be the new hovercard:

Jun 17 2023, 16:30
valerio.bozzolan edited the content of Graphical Kit.
Jun 17 2023, 15:45
valerio.bozzolan edited the content of Graphical Kit.
Jun 17 2023, 15:43
valerio.bozzolan updated the task description for T15005: Get Better Logo / Brand Assets.
Jun 17 2023, 15:42 · Phactory: Community Projects, Good Starter Task, Phorge
valerio.bozzolan created an object: Graphical Kit.
Jun 17 2023, 15:40
valerio.bozzolan added a subtask for T15005: Get Better Logo / Brand Assets: T15478: Graphical Kit.
Jun 17 2023, 15:37 · Phactory: Community Projects, Good Starter Task, Phorge
valerio.bozzolan added a parent task for T15478: Graphical Kit: T15005: Get Better Logo / Brand Assets.
Jun 17 2023, 15:37
valerio.bozzolan added a project to T15474: Dashboard Tabs is not open anymore as default at startup: Bug Reports.
Jun 17 2023, 15:35 · Affects-Wikimedia, User-valerio.bozzolan, Dashboards, Bug Reports
valerio.bozzolan triaged T15048: Allow awarding Tokens to individual Comments as Wishlist priority.
Jun 17 2023, 15:34 · Comments
valerio.bozzolan closed T15051: default.pem in Arcanist is out of date - maybe remove it completely? as Resolved.

I think we can consider this as resolved by our dear @jacques since I just tried and it finally works ✨

Jun 17 2023, 15:32 · Arcanist
valerio.bozzolan created P17 CA bundle 2023 expirations.
Jun 17 2023, 15:30
valerio.bozzolan added a task to D25049: Update the extracted cURL SSL CA bundle: T15051: default.pem in Arcanist is out of date - maybe remove it completely?.
Jun 17 2023, 15:26 · Arcanist (archived)
valerio.bozzolan added a revision to T15051: default.pem in Arcanist is out of date - maybe remove it completely?: D25049: Update the extracted cURL SSL CA bundle.
Jun 17 2023, 15:26 · Arcanist
valerio.bozzolan updated the summary of D25051: Destroy file attachments when file is deleted, or object is deleted.
Jun 17 2023, 15:24 · Files
valerio.bozzolan triaged T15270: "Access Denied: Restricted File" strings concatenated without whitespace as Low priority.
Jun 17 2023, 15:22 · UX, Good Starter Task, Files