Page MenuHomePhorge

Give embedded image files with transparency a checkered background
ClosedPublic

Authored by aklapper on Jun 14 2023, 18:44.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 11:28
Unknown Object (File)
Sun, May 19, 20:21
Unknown Object (File)
Tue, May 14, 12:06
Unknown Object (File)
Sun, May 12, 12:34
Unknown Object (File)
Sun, May 12, 12:34
Unknown Object (File)
Sun, May 12, 12:33
Unknown Object (File)
Sat, May 11, 18:39
Unknown Object (File)
Wed, May 8, 04:21

Details

Summary

Have a consistent rendering experience between File page and file embedded in a task for PNG image files with an alpha channel:
Show a checkered background on the embedded image instead of a white background; show full contrast when hovering over the embedded image.

Closes T15473

Test Plan

See steps in T15473 - compare an image file embedded in a task before and after applying this patch.

  • test in Task description
  • test in Task comment
  • test in Task comment inside something weird like a table

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan edited the test plan for this revision. (Show Details)

Nice catch!

lgtm

This revision is now accepted and ready to land.Jun 14 2023, 19:14